[GitHub] [spark] HyukjinKwon commented on a diff in pull request #36869: [SPARK-39472][SQL][TEST] Refactor InMemoryTableCatalog classes hierarchy

[GitBox <gi...@apache.org>]

HyukjinKwon commented on code in PR #36869:
URL: https://github.com/apache/spark/pull/36869#discussion_r897417117


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryFunctionCatalog.scala:
##########
@@ -25,7 +25,7 @@ import scala.collection.JavaConverters._
 import org.apache.spark.sql.catalyst.analysis.{NoSuchFunctionException, NoSuchNamespaceException}
 import org.apache.spark.sql.connector.catalog.functions.UnboundFunction
 
-class InMemoryCatalog extends InMemoryTableCatalog with FunctionCatalog {
+class InMemoryFunctionCatalog extends InMemoryTableCatalog with FunctionCatalog {

Review Comment:
   It looks weird. function catalog extends both table catalog and function catalog?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org