You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Romain Manni-Bucau (JIRA)" <ji...@apache.org> on 2016/06/07 15:19:20 UTC

[jira] [Resolved] (TOMEE-1832) dbcp2 datasource lock contention on createDataSource + illogical locking

     [ https://issues.apache.org/jira/browse/TOMEE-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Romain Manni-Bucau resolved TOMEE-1832.
---------------------------------------
    Resolution: Fixed

> dbcp2 datasource lock contention on createDataSource + illogical locking
> ------------------------------------------------------------------------
>
>                 Key: TOMEE-1832
>                 URL: https://issues.apache.org/jira/browse/TOMEE-1832
>             Project: TomEE
>          Issue Type: Bug
>            Reporter: Romain Manni-Bucau
>            Assignee: Romain Manni-Bucau
>             Fix For: 7.0.1
>
>
> We extend dbcp(2) datasource to add some custom features like password ciphering etc...
> We need to ensure locking is consistent (ie we dont use our own locking when parent uses synchronized) + createDataSource should absolutely avoid locking as much as possible at runtime (as its parent)
> Side note: normally it is not a high requirement to synchronize getters/setters (parent doesnt) but worse case it doesn't hurt there if we want to do runtime modification later



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)