You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Yang ZHONG (JIRA)" <tu...@ws.apache.org> on 2007/02/04 23:11:05 UTC
[jira] Created: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
------------------------------------------------------------------------------------------------
Key: TUSCANY-1091
URL: https://issues.apache.org/jira/browse/TUSCANY-1091
Project: Tuscany
Issue Type: Improvement
Components: Java SDO Implementation
Affects Versions: Java-SDO-Mx
Reporter: Yang ZHONG
Fix For: Java-SDO-Mx
<p0:quotes3>
<p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
<p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
</p0:quotes3>
can be optimized as
<p0:quotes3 xmlns:p1="http://www.example.com/simple3">
<p1:symbol3>IBM</p1:symbol3>
<p1:company3>IBM Corp.</p1:company3>
</p0:quotes3>
Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson updated TUSCANY-1091:
------------------------------------
Fix Version/s: (was: Java-SDO-Mx)
Java-SDO-M3
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-M3
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang ZHONG updated TUSCANY-1091:
--------------------------------
Attachment: bindLessNS
The new patch has passed all build tests.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473444 ]
Yang ZHONG commented on TUSCANY-1091:
-------------------------------------
Can't explain twice XMLStreamHelperPerformanceTestCase.java:64 either.
61: DataObject child = quote.createDataObject("quotes");
64: DataObject quote3 = quote.createDataObject("quotes3");
Success of 61 indicates some XSD similar to XMLStreamHelper.xsd has been loaded,
however maybe not http://issues.apache.org/jira/secure/attachment/12350306/XMLStreamHelper.xsd
Here is DataObjectUtil.java:476 where NullPointerException happened
475: Property property = (Property)getProperty(dataObject, propertyName);
476: Type type = property.getType()
XMLStreamHelper.xsd imports http://issues.apache.org/jira/secure/attachment/12350307/simple3.xsd
for element/Property "quotes3", if that helps.
I use Windows XP SP2, SubVersion 1.3.1 and maven 2.0.4.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson resolved TUSCANY-1091.
-------------------------------------
Resolution: Fixed
resolved at level 509538
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson updated TUSCANY-1091:
------------------------------------
Attachment: T-1091.log
Yang, I have repeated the issue from scratch
attached is a log which shows
1) creation of new directory with fresh extraction from svn
2) mvn clean followed by mvn build of clean SDO trunk (successful)
3) application of patch, addition of new files to svn, and svn diff on the directory hierarchy
4) mvn clean followed by mvn build of patched SDO trunk (1 failure in new test)
! will also attach the surefire report
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson updated TUSCANY-1091:
------------------------------------
Attachment: org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang ZHONG updated TUSCANY-1091:
--------------------------------
Attachment: bindLessNS.patch
1. XMLStreamHelperPerformanceTestCase failure
All build tests pass for me. I "mvn clean" before test, do you want to give a try please?
If the problem stays, I svn all source from scratch, do you want to give a try please?
2. introduced NameSpaceContext
NameSpaceContext isn't new. It was renamed from DelegatingNameSpaceContext (Frank http://issues.apache.org/jira/browse/TUSCANY-1091#action_12471365)
by striping "Delegating" (planned http://issues.apache.org/jira/browse/TUSCANY-1091#action_12471389).
Now it has been renamed to NamespaceContextImpl in the attached new patch.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473673 ]
Kelvin Goodson commented on TUSCANY-1091:
-----------------------------------------
Yang,
I have replicated this error on a different machine with a fresh install by following the exact same steps as above and producing the exact same exception stack. Please can you confirm that when you take a fresh extraction from svn and apply your own patch to it you do not seen this error. If you do see the error, please could you investigate.
C:\Development\patches\T-1091>ls
1091.patch LICENSE.txt STATUS impl pom.xml sdo.xml tools
BUILDING.txt NOTICE.txt distribution plugin sample target
C:\Development\patches\T-1091>echo %JAVA_HOME%
c:\Java5
C:\Development\patches\T-1091>c:\Java5\bin\java.exe -version
java version "1.5.0"
Java(TM) 2 Runtime Environment, Standard Edition (build pwi32dev-20060222a (SR1))
IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Windows XP x86-32 j9vmwi3223-20060222a (JIT enabled)
J9VM - 20060220_05389_lHdSMR
JIT - 20060220_2133_r8
GC - 20060214_AA)
JCL - 20060222a
C:\Development\patches\T-1091>mvn -version
Maven version: 2.0.4
C:\Development\patches\T-1091>svn update
At revision 508367.
o/s = Windows XP Pro Service Pack 2
Thanks, Kelvin.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473128 ]
Kelvin Goodson commented on TUSCANY-1091:
-----------------------------------------
Hi Yang,
I'm going to have to push back on a couple of things here, sorry.
First is that I'm getting a test failure when I run in maven (not in eclipse) the exception stack is ...
Test set: org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.06 sec <<< FAILURE!
testDynamic(org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase) Time elapsed: 0.03 sec <<< ERROR!
java.lang.NullPointerException
at org.apache.tuscany.sdo.util.DataObjectUtil.createDataObject(DataObjectUtil.java:476)
at org.apache.tuscany.sdo.impl.DataObjectImpl.createDataObject(DataObjectImpl.java:1196)
at org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.testDynamic(XMLStreamHelperPerformanceTestCase.java:64)
at org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.testDynamic(XMLStreamHelperPerformanceTestCase.java:64)
....
I'm not sure why line 64 appears twice in the stack, could you take a look please?
The second thing is again something I'm not sure we have a policy on but I think is could be confusing. You have introduced a class which differs in name from the interface it implements only by case.
NameSpaceContext implements NamespaceContext
I think this is potentially confusing. Would you be able to change this to perhaps a XXXImpl class please.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang ZHONG updated TUSCANY-1091:
--------------------------------
Attachment: simple3.xsd
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470678 ]
Yang ZHONG commented on TUSCANY-1091:
-------------------------------------
We can have a comment such as:
We used to have a NameSpaceContext at each DataObject level, delegating to parent DataObject NameSpaceContext. setParent was used to configure the parent NameSpaceContext.
This improvement optimizes that and uses one global NameSpaceContext not delegating to any other one. Therefore setParent is ignored.
Thanks.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12470579 ]
Kelvin Goodson commented on TUSCANY-1091:
-----------------------------------------
Hi Yang,
just a quick question before I apply this. I'm not sure I'm happy about having a public setParent method that ignores the input argument and returns. It feels like we are setting a trap here. What should we be doing here? I feel this at minimum deserves a comment.
Cheers, Kelvin.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang ZHONG updated TUSCANY-1091:
--------------------------------
Attachment: XMLStreamHelper.xsd
XMLStreamHelperPerformanceTestCase.java
bindLessNS
All SDO build tests have passed with the attached patch.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474060 ]
Yang ZHONG commented on TUSCANY-1091:
-------------------------------------
I've just installed IBM JSDK 5, patch builds fine and tests run fine.
C:\>%JAVA_HOME%\bin\java -version
java version "1.5.0"
Java(TM) 2 Runtime Environment, Standard Edition (build pwi32devifx-20060124)
IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Windows XP x86-32 j9vmwi3223ifx-2006
0124 (JIT enabled)
J9VM - 20051027_03723_lHdSMR
JIT - 20051027_1437_r8
GC - 20051020_AA)
JCL - 20060120
C:\>cd \temp\Tuscany\SDO\issues\Java\tests\java\sdo
C:\temp\Tuscany\SDO\issues\Java\tests\java\sdo>svn update
At revision 509057.
C:\temp\Tuscany\SDO\issues\Java\tests\java\sdo>mvn -version
Maven version: 2.0.4
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471389 ]
Yang ZHONG commented on TUSCANY-1091:
-------------------------------------
We still use DelegatingNameSpaceContext, just no more delegating since we only have a global one. I sure can rename it to NameSpaceContext and remove setParent method.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473392 ]
Kelvin Goodson commented on TUSCANY-1091:
-----------------------------------------
Yang,
1) I have a fresh workspace for every patch and always do mvn clean. The problem persists, I will dig deeper.
2) Thanks for renaming the class. I did understand that it was not new, However, it was the action of removing the Delegating which gave rise to the issue.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474400 ]
Kelvin Goodson commented on TUSCANY-1091:
-----------------------------------------
The issue here is that there is some generated code in the impl project using an old generator pattern which shares a namespace with the new xsd (xsdStreamHelper.xsd has namespace http://www.example.com/simple"). The old style generated code puts its metadata in the delegated registry, so when it comes to type definition using the new xsd, the first getEPackage for that namespace succeeds where you would hope that it fails. I will open a JIRA to clean up this situation along with other testcase references to helper singletons, and then commit this after committing the test case updates.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, bindLessNS.patch, org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.txt, simple3.xsd, T-1091.log, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-1091) DataObjectXMLStreamReader doesn't
have to repeat NameSpace declaration which impacts performance
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12471365 ]
Frank Budinsky commented on TUSCANY-1091:
-----------------------------------------
This sounds strange to me. If we don't use a DelegatingNameSpaceContext any more, then why not change the code to not ever call setParent() - maybe even remove the setParentNamespaceContext() method - maybe even change the class name? Just making it not do what it's interface says (i.e., "set the parent") results in totally confusing code.
Or am I misunderstanding somethiing here?
Frank.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, simple3.xsd, XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3 xmlns:p1="http://www.example.com/simple3">IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3">IBM Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3">
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes to make use of HelperContext so that it will neither interfere nor be interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org