You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2013/03/08 01:49:11 UTC

Re: svn commit: r1454037 - /commons/proper/math/trunk/src/main/assembly/src.xml

On 7 March 2013 19:29,  <tn...@apache.org> wrote:
> Author: tn
> Date: Thu Mar  7 19:29:41 2013
> New Revision: 1454037
>
> URL: http://svn.apache.org/r1454037
> Log:
> Exclude download cgi from source distribution.
>
> Modified:
>     commons/proper/math/trunk/src/main/assembly/src.xml
>
> Modified: commons/proper/math/trunk/src/main/assembly/src.xml
> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/assembly/src.xml?rev=1454037&r1=1454036&r2=1454037&view=diff
> ==============================================================================
> --- commons/proper/math/trunk/src/main/assembly/src.xml (original)
> +++ commons/proper/math/trunk/src/main/assembly/src.xml Thu Mar  7 19:29:41 2013
> @@ -36,6 +36,7 @@
>        <excludes>
>          <exclude>**/mantissa/**</exclude>
>          <exclude>**/experimental/**</exclude>
> +        <exclude>**/*.cgi</exclude>

I don't like the wild-card name here.
Why not use a more specific name such as

        <exclude>**/download*.cgi</exclude>

>        </excludes>
>      </fileSet>
>    </fileSets>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r1454037 - /commons/proper/math/trunk/src/main/assembly/src.xml

Posted by Thomas Neidhart <th...@gmail.com>.
On 03/08/2013 01:49 AM, sebb wrote:
> On 7 March 2013 19:29,  <tn...@apache.org> wrote:
>> Author: tn
>> Date: Thu Mar  7 19:29:41 2013
>> New Revision: 1454037
>>
>> URL: http://svn.apache.org/r1454037
>> Log:
>> Exclude download cgi from source distribution.
>>
>> Modified:
>>     commons/proper/math/trunk/src/main/assembly/src.xml
>>
>> Modified: commons/proper/math/trunk/src/main/assembly/src.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/assembly/src.xml?rev=1454037&r1=1454036&r2=1454037&view=diff
>> ==============================================================================
>> --- commons/proper/math/trunk/src/main/assembly/src.xml (original)
>> +++ commons/proper/math/trunk/src/main/assembly/src.xml Thu Mar  7 19:29:41 2013
>> @@ -36,6 +36,7 @@
>>        <excludes>
>>          <exclude>**/mantissa/**</exclude>
>>          <exclude>**/experimental/**</exclude>
>> +        <exclude>**/*.cgi</exclude>
> 
> I don't like the wild-card name here.
> Why not use a more specific name such as
> 
>         <exclude>**/download*.cgi</exclude>

ok changed.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org