You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/11/19 17:19:04 UTC

[GitHub] dpa99c commented on issue #341: iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on ios 12

dpa99c commented on issue #341: iOS CDVWKInAppBrowser evaluateJavascript method randomly gets blocked on ios 12
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/341#issuecomment-439972189
 
 
   @janpio yes, [WKWebView's `evaluateJavascript`](https://developer.apple.com/documentation/webkit/wkwebview/1415017-evaluatejavascript?language=objc) and the associated [addScriptMessageHandler](https://developer.apple.com/documentation/webkit/wkusercontentcontroller/1537172-addscriptmessagehandler?language=objc) used to return the async result via the postMessage API have both been present since iOS 8.
   
   The changes in the PR by @jonathanli2 simply remove the redundant return of the synchronous result which is never used in the WKWebView implementation (my bad for not removing it originally).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org