You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/10/28 23:55:31 UTC
Review Request 27316: Fix minor discrepancies in RC script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27316/
-----------------------------------------------------------
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Fix minor discrepancies in RC script.
Diffs
-----
build-support/release/release-candidate 02223362d31485c43cbad6fd66b6cfd10aa02c7b
Diff: https://reviews.apache.org/r/27316/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27316: Fix minor discrepancies in RC script.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27316/
-----------------------------------------------------------
(Updated Oct. 28, 2014, 11:26 p.m.)
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
-------
Fix minor discrepancies in RC script.
Diffs (updated)
-----
build-support/release/release-candidate 02223362d31485c43cbad6fd66b6cfd10aa02c7b
Diff: https://reviews.apache.org/r/27316/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27316: Fix minor discrepancies in RC script.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27316/#review58913
-----------------------------------------------------------
Ship it!
Master (55b946c) is green with this patch.
./build-support/jenkins/build.sh
- Aurora ReviewBot
On Oct. 28, 2014, 10:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27316/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 10:55 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix minor discrepancies in RC script.
>
>
> Diffs
> -----
>
> build-support/release/release-candidate 02223362d31485c43cbad6fd66b6cfd10aa02c7b
>
> Diff: https://reviews.apache.org/r/27316/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 27316: Fix minor discrepancies in RC script.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27316/#review58908
-----------------------------------------------------------
Ship it!
build-support/release/release-candidate
<https://reviews.apache.org/r/27316/#comment100077>
This is bash - prefer $(uname)
Also keep the branch on one line
```bash
if [[ $(uname) = Darwin ]]; then
...
fi
```
- Kevin Sweeney
On Oct. 28, 2014, 3:55 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27316/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2014, 3:55 p.m.)
>
>
> Review request for Aurora and Kevin Sweeney.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix minor discrepancies in RC script.
>
>
> Diffs
> -----
>
> build-support/release/release-candidate 02223362d31485c43cbad6fd66b6cfd10aa02c7b
>
> Diff: https://reviews.apache.org/r/27316/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>