[GitHub] [httpcomponents-core] garydgregory commented on pull request #218: Takari maven wrapper

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #218:
URL: https://github.com/apache/httpcomponents-core/pull/218#issuecomment-675180186


   FWIW, I just argued against the same request for Apache Commons components where the context was more about CI from my understanding of the request. From my POV:
   
   There is no blocking issue to fix here IMO. When you build in a CI, you know what OS you get and Maven is pre-configured, no mystery.
   
   My view here is that it would be the CI's job to toggle the Maven version just like a CI does for Java, the OS, and everything else a CI build uses.
   
   What I can see us doing is going to GitHub and asking for an actions/setup-maven just like there is an actions/setup-java. If we do anything we should create our own actions/setup-maven.
   
   I personally do not want to see or maintain copies of these files in 20+ repositories; it seems like a giant maintenance headache to me. I don't want to consider why this component does it this way and this other one that way. I've been aiming for GitHub CI builds to be as consistent as possible FWIW.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org