You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/26 09:59:17 UTC
[GitHub] [iceberg] openinx opened a new pull request #2386: Tests: Get row collection from flink sql query.
openinx opened a new pull request #2386:
URL: https://github.com/apache/iceberg/pull/2386
Currently, the FlinkTestBase#sql will returns a `List<Object[]>`, which is not friendly to assert the results of flink SQL query because for a record, we have to build a `Object` array , and then use the `Assert.assertArrayEquals((Object[])result, expected)` to check the equality. It's hard to assert the record that read from a table with nested column.
So I recommend to return a `List<Row>` for the `FlinkTestBase#sql` because the flink's row have considered the equal logic for nested columns, pls see the [equals](https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/types/Row.java#L405) method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx commented on pull request #2386: Tests: Get row collection from flink sql query.
Posted by GitBox <gi...@apache.org>.
openinx commented on pull request #2386:
URL: https://github.com/apache/iceberg/pull/2386#issuecomment-811676607
This is a very minor change in unit tests, since @stevenzwu did not response to this PR and @rdblue show an +1 on this, I plan to get this merged because the following PR https://github.com/apache/iceberg/pull/2303/files depends on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] openinx merged pull request #2386: Tests: Get row collection from flink sql query.
Posted by GitBox <gi...@apache.org>.
openinx merged pull request #2386:
URL: https://github.com/apache/iceberg/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #2386: Tests: Get row collection from flink sql query.
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #2386:
URL: https://github.com/apache/iceberg/pull/2386#issuecomment-810473537
This looks fine to me, but it would be good to have someone more familiar with Flink take a look. @stevenzwu, could you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org