You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/08/15 21:15:25 UTC
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Hello Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11238
to review the following change.
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
[site] KUDU-1951 Exclude dirs from site_tool proof
* cpp-client-api is automatically generated so it shouldn't be proofed
* www is not part of the documentation, but it's the default value of
--webserver_doc_root, so it can be there in the working directory
Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
---
M site_tool
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/11238/1
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124
PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/',
> I dunno about all this stuff to ignore directories that aren't actually in
Maybe it would be better to use a separate checkout or multiple worktrees as you mentioned on another commit, but as we're not using 'www' in gh-pages, it seemed convenient to add it to ignore. Should I remove it?
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:07:03 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124
PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/',
> well, those are tracked under master branch, so whenever you checkout gh-pa
hm, I guess it's just me, but I always have 30+ untracked non-ignored files floating around in my source tree on the master branch in my main repo.
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:13:51 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 Aug 2018 19:02:58 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
[site] KUDU-1951 Exclude dirs from site_tool proof
cpp-client-api is automatically generated so it shouldn't be proofed
Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Reviewed-on: http://gerrit.cloudera.org:8080/11238
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M site_tool
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124
PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/',
I dunno about all this stuff to ignore directories that aren't actually in this repository. Why doesn't 'www' disappear when you switch branches? Maybe we should just more strongly encourage a separate checkout?
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:01:03 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124
PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/',
> hm, I guess it's just me, but I always have 30+ untracked non-ignored files
I have several non-tracked/non-ignored files too, but not all of them break stuff (this one's breaking proof because it contains a trace.html). Also, I only wanted to ignore files/directories that seem to be common enough to be annoying for multiple people. Anyway, you're right that we should draw the line before we end up ignoring '*', so I'll remove this one
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:18:22 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2: Verified+1 Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 21:55:35 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11238
to look at the new patch set (#3).
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
[site] KUDU-1951 Exclude dirs from site_tool proof
cpp-client-api is automatically generated so it shouldn't be proofed
Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
---
M site_tool
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/11238/3
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124
PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/',
> Maybe it would be better to use a separate checkout or multiple worktrees a
I don't feel that strongly, I just think that at some point you'll end up with the entire listing of the files in master being duplicated into here or gitignore, no? eg why don't we have "src" or "java/" etc?
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:08:57 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) [site] KUDU-1951 Exclude dirs from site tool proof
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11238 )
Change subject: [site] KUDU-1951 Exclude dirs from site_tool proof
......................................................................
Patch Set 2:
(1 comment)
> Patch Set 2:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool
File site_tool:
http://gerrit.cloudera.org:8080/#/c/11238/2/site_tool@124
PS2, Line 124: '--file-ignore', '/apidocs|releases|configuration_ref|cpp-client-api|www/',
> I don't feel that strongly, I just think that at some point you'll end up w
well, those are tracked under master branch, so whenever you checkout gh-pages, they'll just disappear. the problem with www for example, and build and thirdparty on the other patch, is that they are all untracked, so if you check out gh-pages in the some directory/worktree, you need to rm or sideline them to avoid breaking these scripts
--
To view, visit http://gerrit.cloudera.org:8080/11238
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee421e4e218d40cef87db1e3f04991113afe596d
Gerrit-Change-Number: 11238
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 15 Aug 2018 22:12:11 +0000
Gerrit-HasComments: Yes