Re: Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

[belliraj hb <be...@gmail.com>]

> On Dec. 27, 2016, 7:34 a.m., Nitiraj Rathore wrote:
> > contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js, line 57
> > <https://reviews.apache.org/r/55012/diff/1/?file=1591571#file1591571line57>
> >
> >     you should send some status code from server side and check for that status code before concluding Permission denied instead of searching for a word in the message. If required please change in files view as well. it would be a nice addition.

THis particular code change may affect other components that use the FileService. So it is much safer done on UI currently.


- belliraj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55012/#review160140
-----------------------------------------------------------


On Dec. 23, 2016, 10:53 a.m., Madhan Reddy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55012/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 10:53 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19291
>     https://issues.apache.org/jira/browse/AMBARI-19291
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> User should be shown proper error message when user tries to navigate to a hdfs folder and he doesn't have access on that folder.
> Steps to reproduce :
> 1) Try to import workflow from HDFS .
> 2) In the file browser, click on a folder on which user doesn't have permission
> 3) Though api /api/v1/views/Workflow%20Manager/versions/1.0.0/instances/WFD/resources/proxy/fileServices/fileops/listdir?path=%2Ftmp%2Fhive fails with appropriate error, UI keeps on loading.
> UI should handle this error and show appropriate message to the user.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js c9be41a 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs 437640d 
> 
> Diff: https://reviews.apache.org/r/55012/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Madhan Reddy
> 
>