You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/02/09 01:33:27 UTC

[jira] Created: (HDFS-956) Improper synchronization in some FSNamesystem methods

Improper synchronization in some FSNamesystem methods
-----------------------------------------------------

                 Key: HDFS-956
                 URL: https://issues.apache.org/jira/browse/HDFS-956
             Project: Hadoop HDFS
          Issue Type: Bug
    Affects Versions: 0.21.0, 0.22.0
            Reporter: Todd Lipcon


There are some methods in FSNamesystem that check isInSafeMode while not synchronized, and then proceed to perform operations. Thus the actual operations can occur after the NN has entered safemode, which is no good.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HDFS-956) Improper synchronization in some FSNamesystem methods

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HDFS-956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon resolved HDFS-956.
------------------------------

    Resolution: Duplicate

HDFS-988 will cover these as well.

> Improper synchronization in some FSNamesystem methods
> -----------------------------------------------------
>
>                 Key: HDFS-956
>                 URL: https://issues.apache.org/jira/browse/HDFS-956
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>
> There are some methods in FSNamesystem that check isInSafeMode while not synchronized, and then proceed to perform operations. Thus the actual operations can occur after the NN has entered safemode, which is no good.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (HDFS-956) Improper synchronization in some FSNamesystem methods

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HDFS-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831218#action_12831218 ] 

Todd Lipcon commented on HDFS-956:
----------------------------------

Quick search through FSNamesystem shows:
- concat checks safemode before entering synchronization block
- setQuota isn't synchronized at all (it calls dir.setQuota with no synchronization either)
- renewLease isn't synchronized (not certain for sure if this has to be - it seems like it ought to be so that the leases serialized in an fsimage are consistent)
- computeDatanodeWork - this one is a bit tricky as well. Is blockManager.updateState() safe to call in safeMode?


> Improper synchronization in some FSNamesystem methods
> -----------------------------------------------------
>
>                 Key: HDFS-956
>                 URL: https://issues.apache.org/jira/browse/HDFS-956
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>
> There are some methods in FSNamesystem that check isInSafeMode while not synchronized, and then proceed to perform operations. Thus the actual operations can occur after the NN has entered safemode, which is no good.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.