[GitHub] [hbase] saintstack commented on a change in pull request #556: HBASE-22941 merge operation returns parent regions in random order

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #556: HBASE-22941 merge operation returns parent regions in random order
URL: https://github.com/apache/hbase/pull/556#discussion_r318661230
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStateStore.java
 ##########
 @@ -263,7 +263,7 @@ public void mergeRegions(RegionInfo child, RegionInfo [] parents, ServerName ser
       throws IOException {
     TableDescriptor htd = getDescriptor(child.getTable());
     boolean globalScope = htd.hasGlobalReplicationScope();
-    Map<RegionInfo, Long> parentSeqNums = new HashMap<>(parents.length);
+    Map<RegionInfo, Long> parentSeqNums = new TreeMap<>();
 
 Review comment:
   nit... could have been a NavigableMap... but this'll do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services