You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/29 03:58:34 UTC

[GitHub] [flink-ml] yunfengzhou-hub opened a new pull request, #185: [FLINK-30037] Use shared mini-cluster in python tests

yunfengzhou-hub opened a new pull request, #185:
URL: https://github.com/apache/flink-ml/pull/185

   ## What is the purpose of the change
   
   This pull request optimizes the efficiency of Flink ML python tests by enabling the use of shared mini cluster in python tests.
   
   ## Brief change log
   
     - Adds `flink-ml-python` module with java dependencies to be used in python tests
     - Creates a shared mini cluster for each python unit test class and reuses the cluster through all python test cases in a class.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #185: [FLINK-30037] Use shared mini-cluster in python tests

Posted by GitBox <gi...@apache.org>.
lindong28 commented on code in PR #185:
URL: https://github.com/apache/flink-ml/pull/185#discussion_r1034328331


##########
flink-ml-python/pyflink/ml/tests/test_utils.py:
##########
@@ -37,10 +39,35 @@ def update_existing_params(target: JavaWithParams, source: JavaWithParams):
 
 
 class PyFlinkMLTestCase(unittest.TestCase):
+    resource: JavaObject
+
+    @classmethod
+    def setUpClass(cls) -> None:
+        cls._load_dependency_jars()
+        cls.env = StreamExecutionEnvironment.get_execution_environment()

Review Comment:
   Is this line necessary?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 commented on pull request #185: [FLINK-30037] Use shared mini-cluster in python tests

Posted by GitBox <gi...@apache.org>.
lindong28 commented on PR #185:
URL: https://github.com/apache/flink-ml/pull/185#issuecomment-1330164677

   Thanks for the PR. It is great to see that the PR considerably reduced the overall python test time from more than 60 minutes to 10 minutes! LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-ml] lindong28 merged pull request #185: [FLINK-30037] Use shared mini-cluster in python tests

Posted by GitBox <gi...@apache.org>.
lindong28 merged PR #185:
URL: https://github.com/apache/flink-ml/pull/185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org