You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/07/27 03:46:31 UTC
[GitHub] [guacamole-client] mike-jumper opened a new pull request #630: GUACAMOLE-1386: Correct definitions of "Meta" and "Super" keys.
mike-jumper opened a new pull request #630:
URL: https://github.com/apache/guacamole-client/pull/630
Guacamole's on-screen keyboard and part of its general keyboard handling incorrectly define "Super" as the "Windows" or "Command" key. This is incorrect. The correct key for the "Windows" key (or the Mac "Command" key) is "Meta".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a change in pull request #630: GUACAMOLE-1386: Correct definitions of "Meta" and "Super" keys.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #630:
URL: https://github.com/apache/guacamole-client/pull/630#discussion_r677467871
##########
File path: guacamole-common-js/src/main/webapp/modules/Keyboard.js
##########
@@ -583,7 +583,7 @@ Guacamole.Keyboard = function Keyboard(element) {
"UIKeyInputUpArrow": [0xFF52],
"Up": [0xFF52],
"Undo": [0xFF65],
- "Win": [0xFFEB],
+ "Win": [0xFFE7, 0xFFE7, 0xFFE8],
Review comment:
Is there a reason that `0xFFE7` needs to be listed twice? I see this done for other keys that have multiple identifiers, just wondering why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #630: GUACAMOLE-1386: Correct definitions of "Meta" and "Super" keys.
Posted by GitBox <gi...@apache.org>.
necouchman merged pull request #630:
URL: https://github.com/apache/guacamole-client/pull/630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #630: GUACAMOLE-1386: Correct definitions of "Meta" and "Super" keys.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #630:
URL: https://github.com/apache/guacamole-client/pull/630#discussion_r677717866
##########
File path: guacamole-common-js/src/main/webapp/modules/Keyboard.js
##########
@@ -583,7 +583,7 @@ Guacamole.Keyboard = function Keyboard(element) {
"UIKeyInputUpArrow": [0xFF52],
"Up": [0xFF52],
"Undo": [0xFF65],
- "Win": [0xFFEB],
+ "Win": [0xFFE7, 0xFFE7, 0xFFE8],
Review comment:
Yep - it's due to the way key location is handled by JavaScript keyboard events and for compatibility. If a key has left/right variations, like Left Shift vs. Right Shift, then JavaScript may represent that with a key location value where `1` indicates left , `2` indicates right, and `3` indicates the numpad:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#keyboard_locations
`0` is used for keys that do not vary by location or if the location is unknown, thus listing `0xFFE7` twice here is effectively a fallback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org