You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Marco Massenzio <ma...@mesosphere.io> on 2015/06/03 04:25:06 UTC
Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/
-----------------------------------------------------------
Review request for mesos and Dave Lester.
Repository: mesos
Description
-------
Added installation instructions for Ubuntu 14.04 and OSX
Diffs
-----
docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
Diff: https://reviews.apache.org/r/34976/diff/
Testing
-------
This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
Thanks,
Marco Massenzio
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On June 4, 2015, 5:52 p.m., Adam B wrote:
> > docs/getting-started.md, lines 24-26
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line24>
> >
> > It was suggested that we should keep this document short&sweet and only reference the latest Ubuntu LTS release, and then we can archive the 12.04 instructions in a blog post (on mesos/mesosphere site?).
Ok - I'm lost now: what you suggest sounds to me exactly what I did (following your earlier suggestion :) - so I'm clearly missing something...
Can you please elaborate on what should be further changed (or added back) here?
BTW - instructions are exactly the same for 12.04 and/or 14.04; the change I propose here, makes this copyable & pasteable and works for 0.22 (which is what everyone should use) and thus (IMHO) friendlier than the original version.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86667
-----------------------------------------------------------
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 6:44 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 4, 2015, 10:52 a.m., Adam B wrote:
> > docs/getting-started.md, lines 24-26
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line24>
> >
> > It was suggested that we should keep this document short&sweet and only reference the latest Ubuntu LTS release, and then we can archive the 12.04 instructions in a blog post (on mesos/mesosphere site?).
>
> Marco Massenzio wrote:
> Ok - I'm lost now: what you suggest sounds to me exactly what I did (following your earlier suggestion :) - so I'm clearly missing something...
> Can you please elaborate on what should be further changed (or added back) here?
>
> BTW - instructions are exactly the same for 12.04 and/or 14.04; the change I propose here, makes this copyable & pasteable and works for 0.22 (which is what everyone should use) and thus (IMHO) friendlier than the original version.
Ping @adam :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86667
-----------------------------------------------------------
On June 2, 2015, 11:44 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:44 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86667
-----------------------------------------------------------
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment138727>
It was suggested that we should keep this document short&sweet and only reference the latest Ubuntu LTS release, and then we can archive the 12.04 instructions in a blog post (on mesos/mesosphere site?).
- Adam B
On June 2, 2015, 11:44 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:44 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 33
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line33>
> >
> > `build-essential` is no longer needed? Or pre-installed in 14.04?
it's in there - just look on L42
> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 41
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line41>
> >
> > 0.21 and newer? (sasl is 0.14+, maven is 0.18+) Otherwise why call out the version at all, if you're just going to recommend they install the latest?
>
> Marco Massenzio wrote:
> because this is the version I tested them with - I have no idea if this works with anything older
> also, this is what it was used before
s/this/this format/
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
-----------------------------------------------------------
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 6:44 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 39
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line39>
> >
> > What about these python packages? Probably still necessary if you don't `configure --disable-python`.
they are there - a few lines below
> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 41
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line41>
> >
> > 0.21 and newer? (sasl is 0.14+, maven is 0.18+) Otherwise why call out the version at all, if you're just going to recommend they install the latest?
because this is the version I tested them with - I have no idea if this works with anything older
also, this is what it was used before
> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 51
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line51>
> >
> > Can you get a Mac user to review/approve these instructions? Maybe @davelester or @nnielsen
I tested it on a Mac - and they worked
I would argue that this is better than nothing at all?
> On June 11, 2015, 10:02 a.m., Adam B wrote:
> > docs/getting-started.md, line 109
> > <https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line109>
> >
> > Probably better to recommend j=<number of cores> or j=<#GB RAM>, since j=8 could be overkill on a dual-core or smaller.
Good suggestion!
will do
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
-----------------------------------------------------------
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 6:44 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Adam B <ad...@mesosphere.io>.
> On June 11, 2015, 3:02 a.m., Adam B wrote:
> > Sorry it took me so long to get back to this. I just had a few minor comments/questions, but you ought to get a Mac user to verify the OSX instructions.
Also, for doc changes like this, it's helpful if you can post a link to a personal fork/branch with the rendered markdown. Something like https://github.com/massenz/mesos/blob/add_docs_ubuntu/docs/getting-started.md
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
-----------------------------------------------------------
On June 2, 2015, 11:44 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:44 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87539
-----------------------------------------------------------
Sorry it took me so long to get back to this. I just had a few minor comments/questions, but you ought to get a Mac user to verify the OSX instructions.
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139910>
This was a general comment that came up during our last review meeting, and I wanted to make a note so it wasn't lost. Apologies if this was confusing to you. Let me explain the intention in more detail.
_If_ there was content for 12.04 being dropped in favor of the more modern 14.04 instructions, then it would be better to archive the old instructions than lose them completely. Seems like no content was dropped, so this is a non-issue here.
Also, we agreed that it would be better to keep a single set of instructions per distro, only referencing the latest (e.g. Ubuntu LTS) release, rather than having instructions for multiple versions of the same distro. This echoes my original comment.
It seems like you've acted accordingly, and there is no content lost from 12.04, so no need to archive. Feel free to drop the issue.
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139911>
Why upgrade? Doesn't seem necessary.
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139912>
`build-essential` is no longer needed? Or pre-installed in 14.04?
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139913>
What about these python packages? Probably still necessary if you don't `configure --disable-python`.
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139915>
0.21 and newer? (sasl is 0.14+, maven is 0.18+) Otherwise why call out the version at all, if you're just going to recommend they install the latest?
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139917>
Can you get a Mac user to review/approve these instructions? Maybe @davelester or @nnielsen
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139918>
Both of these links go to `https://developer.apple.com/xcode/`
Is this intentional?
Also "on your Mac" is probably redundant.
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139919>
s/deps/dependencies/
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment139894>
Probably better to recommend j=<number of cores> or j=<#GB RAM>, since j=8 could be overkill on a dual-core or smaller.
- Adam B
On June 2, 2015, 11:44 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 11:44 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86379
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34976]
All tests passed.
- Mesos ReviewBot
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 6:44 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87664
-----------------------------------------------------------
- Marco Massenzio
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 6:44 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87768
-----------------------------------------------------------
Ship it!
Renders just fine: https://gist.github.com/nqn/e9460b7fda020c7e0b3a
Will fix the last bits and commit.
- Niklas Nielsen
On June 11, 2015, 11:23 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 11:23 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/
-----------------------------------------------------------
(Updated June 12, 2015, 10:29 p.m.)
Review request for mesos and Dave Lester.
Changes
-------
Fixed trailing whitespace
Repository: mesos
Description
-------
Added installation instructions for Ubuntu 14.04 and OSX
Diffs (updated)
-----
docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
Diff: https://reviews.apache.org/r/34976/diff/
Testing
-------
This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
File Attachments (updated)
----------------
getting-started.pdf
https://reviews.apache.org/media/uploaded/files/2015/06/12/3d39d996-4582-41b4-b8f3-c2b7cd5f69c1__getting-started.pdf
Screenshot
https://reviews.apache.org/media/uploaded/files/2015/06/12/2c395704-73b3-4683-99a5-4004a7c4c0fc__getting-started.pdf
Thanks,
Marco Massenzio
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 12, 2015, 1:22 a.m., Adam B wrote:
> > docs/getting-started.md, line 102
> > <https://reviews.apache.org/r/34976/diff/2-3/?file=977278#file977278line102>
> >
> > s/add/append/
Will fix before commit.
> On June 12, 2015, 1:22 a.m., Adam B wrote:
> > docs/getting-started.md, line 41
> > <https://reviews.apache.org/r/34976/diff/3/?file=983555#file983555line41>
> >
> > s/mesos/Mesos/
Ditto
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87686
-----------------------------------------------------------
On June 11, 2015, 11:23 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 11:23 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Niklas Nielsen <ni...@mesosphere.io>.
On Friday, June 12, 2015, Adam B <ad...@mesosphere.io> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/#review87686
> -----------------------------------------------------------
>
>
> LGTM, but I'd still like to see a Mac user review the Mac instructions.
I can get this rendered for you. I'll ping you in a bit
>
>
> docs/getting-started.md
> <https://reviews.apache.org/r/34976/#comment140107>
>
> s/add/append/
>
>
>
> docs/getting-started.md
> <https://reviews.apache.org/r/34976/#comment140108>
>
> s/mesos/Mesos/
>
>
> - Adam B
>
>
> On June 11, 2015, 11:23 p.m., Marco Massenzio wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/34976/
> > -----------------------------------------------------------
> >
> > (Updated June 11, 2015, 11:23 p.m.)
> >
> >
> > Review request for mesos and Dave Lester.
> >
> >
> > Repository: mesos
> >
> >
> > Description
> > -------
> >
> > Added installation instructions for Ubuntu 14.04 and OSX
> >
> >
> > Diffs
> > -----
> >
> > docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
> >
> > Diff: https://reviews.apache.org/r/34976/diff/
> >
> >
> > Testing
> > -------
> >
> > This are the steps I've followed to build Mesos on my Mac and on my
> Ubuntu box.
> >
> >
> > Thanks,
> >
> > Marco Massenzio
> >
> >
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87686
-----------------------------------------------------------
LGTM, but I'd still like to see a Mac user review the Mac instructions.
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment140107>
s/add/append/
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment140108>
s/mesos/Mesos/
- Adam B
On June 11, 2015, 11:23 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 11, 2015, 11:23 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review87679
-----------------------------------------------------------
Bad patch!
Reviews applied: [34976]
Failed command: ./support/apply-review.sh -n -r 34976
Error:
2015-06-12 06:31:57 URL:https://reviews.apache.org/r/34976/diff/raw/ [3323/3323] -> "34976.patch" [1]
34976.patch:79: trailing whitespace.
to speed up the build and reduce verbosity of the logs, you can add `-j=<number of cores> V=0`
warning: 1 line adds whitespace errors.
Successfully applied: Added installation instructions for Ubuntu 14.04 and OSX
Added installation instructions for Ubuntu 14.04 and OSX
Review: https://reviews.apache.org/r/34976
docs/getting-started.md:102: trailing whitespace.
+to speed up the build and reduce verbosity of the logs, you can add `-j=<number of cores> V=0`
Failed to commit patch
- Mesos ReviewBot
On June 12, 2015, 6:23 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 12, 2015, 6:23 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/
-----------------------------------------------------------
(Updated June 12, 2015, 6:23 a.m.)
Review request for mesos and Dave Lester.
Changes
-------
Addressed comments
Repository: mesos
Description
-------
Added installation instructions for Ubuntu 14.04 and OSX
Diffs (updated)
-----
docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
Diff: https://reviews.apache.org/r/34976/diff/
Testing
-------
This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
Thanks,
Marco Massenzio
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/
-----------------------------------------------------------
(Updated June 3, 2015, 6:44 a.m.)
Review request for mesos and Dave Lester.
Changes
-------
Merged the two Ubuntu sections (they were identical anyway)
Repository: mesos
Description
-------
Added installation instructions for Ubuntu 14.04 and OSX
Diffs (updated)
-----
docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
Diff: https://reviews.apache.org/r/34976/diff/
Testing
-------
This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
Thanks,
Marco Massenzio
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86354
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34976]
All tests passed.
- Mesos ReviewBot
On June 3, 2015, 2:25 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:25 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Marco Massenzio <ma...@mesosphere.io>.
> On June 3, 2015, 5:29 a.m., Adam B wrote:
> > docs/getting-started.md, line 24
> > <https://reviews.apache.org/r/34976/diff/1/?file=977149#file977149line24>
> >
> > Can you merge this in with the Ubuntu 12.04 instructions below? I don't think they're drastically different, and we can probably assume 14.04 instead of 12.04 now.
They were actually identical - but was unsure as to whether anyone cared enough to want to keep them separate.
Please see the new version (a generic `Ubuntu` one).
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86360
-----------------------------------------------------------
On June 3, 2015, 6:44 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 6:44 a.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>
Re: Review Request 34976: Added installation instructions for Ubuntu
14.04 and OSX
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34976/#review86360
-----------------------------------------------------------
docs/getting-started.md
<https://reviews.apache.org/r/34976/#comment138319>
Can you merge this in with the Ubuntu 12.04 instructions below? I don't think they're drastically different, and we can probably assume 14.04 instead of 12.04 now.
- Adam B
On June 2, 2015, 7:25 p.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34976/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 7:25 p.m.)
>
>
> Review request for mesos and Dave Lester.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added installation instructions for Ubuntu 14.04 and OSX
>
>
> Diffs
> -----
>
> docs/getting-started.md f0436575ec568e445f897ed28f50bcd823302d75
>
> Diff: https://reviews.apache.org/r/34976/diff/
>
>
> Testing
> -------
>
> This are the steps I've followed to build Mesos on my Mac and on my Ubuntu box.
>
>
> Thanks,
>
> Marco Massenzio
>
>