[GitHub] [incubator-superset] nytai commented on a change in pull request #9474: Enable beautiful json for dashboard metadata editor

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #9474: Enable beautiful json for dashboard metadata editor
URL: https://github.com/apache/incubator-superset/pull/9474#discussion_r404478343
 
 

 ##########
 File path: superset-frontend/src/dashboard/components/PropertiesModal.jsx
 ##########
 @@ -24,6 +24,7 @@ import Select from 'react-select';
 import AceEditor from 'react-ace';
 import { t } from '@superset-ui/translation';
 import { SupersetClient } from '@superset-ui/connection';
+import stringify from 'json-stringify-pretty-compact';
 
 Review comment:
   what are the advantages to using this module over the native `JSON.stringify` function with formatting (3rd arg)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org