You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2017/12/22 04:08:40 UTC
Review Request 64798: Added an utility to shrink scalar resource while
keeping its meta-data.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64798/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Added an utility to shrink scalar resource while keeping its meta-data.
Diffs
-----
include/mesos/resources.hpp eefe9eac23dd1eeb35df9ba1d109a446526ee0c3
include/mesos/v1/resources.hpp 7a5b0e3cf156b04a232e014e87c49f8f1baa9133
src/common/resources.cpp 919a03b6fa19fc9db4242a32fba3c617d1705413
src/v1/resources.cpp 365ffa7b7f05d95321a8078a91f5bb17b2ee9419
Diff: https://reviews.apache.org/r/64798/diff/1/
Testing
-------
Thanks,
Meng Zhu
Re: Review Request 64798: Added an utility to shrink scalar resource
while keeping its meta-data.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64798/#review194460
-----------------------------------------------------------
Ship it!
src/common/resources.cpp
Lines 1261 (patched)
<https://reviews.apache.org/r/64798/#comment273221>
We may want to avoid mentioning offers here and just say instead that they are indivisible?
- Benjamin Mahler
On Dec. 22, 2017, 4:08 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64798/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 4:08 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an utility to shrink scalar resource while keeping its meta-data.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp eefe9eac23dd1eeb35df9ba1d109a446526ee0c3
> include/mesos/v1/resources.hpp 7a5b0e3cf156b04a232e014e87c49f8f1baa9133
> src/common/resources.cpp 919a03b6fa19fc9db4242a32fba3c617d1705413
> src/v1/resources.cpp 365ffa7b7f05d95321a8078a91f5bb17b2ee9419
>
>
> Diff: https://reviews.apache.org/r/64798/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64798: Added an utility to shrink scalar resource
while keeping its meta-data.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64798/#review194421
-----------------------------------------------------------
PASS: Mesos patch 64798 was successfully built and tested.
Reviews applied: `['64798']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64798
- Mesos Reviewbot Windows
On Dec. 22, 2017, 4:08 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64798/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 4:08 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an utility to shrink scalar resource while keeping its meta-data.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp eefe9eac23dd1eeb35df9ba1d109a446526ee0c3
> include/mesos/v1/resources.hpp 7a5b0e3cf156b04a232e014e87c49f8f1baa9133
> src/common/resources.cpp 919a03b6fa19fc9db4242a32fba3c617d1705413
> src/v1/resources.cpp 365ffa7b7f05d95321a8078a91f5bb17b2ee9419
>
>
> Diff: https://reviews.apache.org/r/64798/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 64798: Added an utility to shrink scalar resource
while keeping its meta-data.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64798/#review194403
-----------------------------------------------------------
PASS: Mesos patch 64798 was successfully built and tested.
Reviews applied: `['64798']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64798
- Mesos Reviewbot Windows
On Dec. 22, 2017, 4:08 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64798/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2017, 4:08 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added an utility to shrink scalar resource while keeping its meta-data.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp eefe9eac23dd1eeb35df9ba1d109a446526ee0c3
> include/mesos/v1/resources.hpp 7a5b0e3cf156b04a232e014e87c49f8f1baa9133
> src/common/resources.cpp 919a03b6fa19fc9db4242a32fba3c617d1705413
> src/v1/resources.cpp 365ffa7b7f05d95321a8078a91f5bb17b2ee9419
>
>
> Diff: https://reviews.apache.org/r/64798/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Meng Zhu
>
>