[jira] [Commented] (GEOMETRY-17) Euclidean Vector Method Follow-Up

["Matt Juntunen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEOMETRY-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644366#comment-16644366 ] 

Matt Juntunen commented on GEOMETRY-17:
---------------------------------------

Do we still need this issue open?

> Euclidean Vector Method Follow-Up
> ---------------------------------
>
>                 Key: GEOMETRY-17
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-17
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>
> This is a follow-up issue to GEOMETRY-9. The following tasks should be completed:
>  # Vector2D - needs an orthogonal() method like Vector3D
>  # Vector#getMagnitude() should be removed. I originally added this as part of GEOMETRY-9 as an alias for getNorm(), but after thinking about it more and working with it, I believe it's more confusing than useful to have multiple names in the code base for the same idea.
>  # Vector#withMagnitude() should be renamed to Vector#withNorm() for the same reason as above.
>  # Vector#getRealNonZeroNorm() - This is currently a private method in the Vector implementation classes but I believe it is useful enough to be made public. The idea is that this would return the vector norm but throw an IllegalNormException if the norm is zero, NaN, or infinite. I've already come across some places in other classes (such as Rotation) where I want to use this.
>  
> Pull request: https://github.com/apache/commons-geometry/pull/11



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)