You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/24 13:40:00 UTC
[GitHub] [pulsar] sijia-w opened a new pull request #9053: [DOCS] Refine the description of jwt
sijia-w opened a new pull request #9053:
URL: https://github.com/apache/pulsar/pull/9053
Fixes #7822
Modification:
Corrections in versioned docs and master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9053: [DOCS] Refine the description of jwt
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9053:
URL: https://github.com/apache/pulsar/pull/9053#discussion_r549321663
##########
File path: site2/docs/administration-pulsar-manager.md
##########
@@ -74,9 +74,9 @@ spring.datasource.password=postgres
If you want to turn on JWT authentication, configure the following parameters:
-* `backend.jwt.token`: token for the superuser. You need to configure this parameter during cluster initialization.
-* `jwt.broker.token.mode`: two modes of generating token, SECRET and PRIVATE.
-* `jwt.broker.public.key`: configure this option if you are using the PRIVATE mode.
+* `backend.jwt.token`: token for the superuser. You need to configure this parameter during cluster initialization.
+* `jwt.broker.token.mode`: multiple modes of generating token, including PUBLIC, PRIVATE, and SECRET.
+* `jwt.broker.public.key`: configure this option if you are using the PUBLIC mode.
Review comment:
if you are using --> if you use
use present tense if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang merged pull request #9053: [DOCS] Refine the description of jwt
Posted by GitBox <gi...@apache.org>.
Jennifer88huang merged pull request #9053:
URL: https://github.com/apache/pulsar/pull/9053
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #9053: [DOCS] Refine the description of jwt
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #9053:
URL: https://github.com/apache/pulsar/pull/9053#issuecomment-751889592
@Jennifer88huang Thank you. The 2.7.1 version is updated in a separate pr since this branch was not rebased. See https://github.com/apache/pulsar/pull/9073.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org