You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/25 07:28:44 UTC

[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull request #125: fix status/value_type don't update

tianxiaoliang commented on a change in pull request #125: fix status/value_type don't update
URL: https://github.com/apache/servicecomb-kie/pull/125#discussion_r397651742
 
 

 ##########
 File path: server/service/mongo/kv/kv_dao.go
 ##########
 @@ -82,6 +82,8 @@ func updateKeyValue(ctx context.Context, kv *model.KVDoc) error {
 	ur, err := collection.UpdateOne(ctx, bson.M{"key": kv.Key, "label_id": kv.LabelID}, bson.D{
 		{"$set", bson.D{
 			{"value", kv.Value},
+			{"value_type", kv.ValueType},
 
 Review comment:
   value_type 本来就不支持修改

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services