[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2751: ARTEMIS-2322: Expose Queue.getRate() data as JMX metric

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2751: ARTEMIS-2322: Expose Queue.getRate() data as JMX metric
URL: https://github.com/apache/activemq-artemis/pull/2751#discussion_r303521994
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/QueueControlImpl.java
 ##########
 @@ -249,6 +249,21 @@ public long getMessageCount() {
       }
    }
 
+   @Override
+   public float getProducedRate() {
+      if (AuditLogger.isEnabled()) {
+         AuditLogger.getProducedRate(queue);
+      }
+      checkStarted();
+
+      clearIO();
 
 Review comment:
   Shouldnt be doing this on an attribute will cause perf issues when metric systems scrape blocking deliveries

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services