[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42615: [SPARK-44916][DOCS][TESTS] Document Spark Driver Live Log UI

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42615:
URL: https://github.com/apache/spark/pull/42615#discussion_r1302067476


##########
core/src/test/scala/org/apache/spark/util/logging/DriverLoggerSuite.scala:
##########
@@ -97,7 +97,9 @@ class DriverLoggerSuite extends SparkFunSuite with LocalSparkContext {
   test("SPARK-44214: DriverLogger.apply returns None when only spark.driver.log.localDir exists") {
     val sparkConf = new SparkConf()
     assert(DriverLogger(sparkConf).isEmpty)
-    assert(DriverLogger(sparkConf.set(DRIVER_LOG_LOCAL_DIR, "file://tmp/")).isEmpty)
+    withTempDir { dir =>
+      assert(DriverLogger(sparkConf.set(DRIVER_LOG_LOCAL_DIR, dir.getCanonicalPath)).isEmpty)
+    }

Review Comment:
   I piggy-backed this to clean up the generated log directory properly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org