DO NOT REPLY [Bug 26308] New: - fail on verify errors in borland deployment tool

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26308>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=26308

fail on verify errors in borland deployment tool 

           Summary: fail on verify errors in borland deployment tool
           Product: Ant
           Version: 1.6.0
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Optional Tasks
        AssignedTo: dev@ant.apache.org
        ReportedBy: jarekk@axit.pl


In 1.6.0 and previous releases of ANT the borland deployment tool does not 
abort the build when errors in the verify procedure are detected. For most 
applications it might be reasonable to abort the procedure, if the verification 
procedure fails. A deployment of EJB-jars which have not passed verification to 
a Borland AppServer will be surely unsuccessful.

The changes to create this functionality are minimal. An additional 
attribute "failOnVerifyError" is added to the 
org/apache/tools/ant/taskdefs/optional/ejb/BorlandDeploymentTool.java file with 
appropriate handling of the attribute: if it is set to true, the javaTask or 
execTask which execute the verification procedure have the failonerror 
attribute set. For backwards compatibility, this attribute is false on default.

The changes done to the verifyBorlandJarV4 method are tested, those done to the
verifyBorlandJarV5 method are UNTESTED. This is because we do not have such a 
version of the Borland AppServer available.

I attach a diff created between the source file BorlandDeploymentTool.java in 
the 1.6.0 version to a solution created by us. This simply adds the attribute 
and its handling to the class. The diff is suitable as a patch file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org