You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/10 18:19:15 UTC
[GitHub] [airflow] griffincosgrove opened a new pull request #13600: Add missing logos for integrations closes #13110
griffincosgrove opened a new pull request #13600:
URL: https://github.com/apache/airflow/pull/13600
Added missing logos .png images and updated provider.yaml file to point to the path for the logo image. Currently, there are many logos on the Apache Site that do not have logo images.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-760170674
@mik-laj replaced the checkers logos and the Google Data Proc logo π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757888623
> Most look fine, but I have a reservation about the few logos that have chess in the background.
Likely badly exported images. Chess usually indicates transparency, so the logos used to have transparency, but they were probably copy&pasted rather than exported from GiMP or similar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-759409978
@griffincosgrove It looks like Google has updated its icons because previously you could download diamond-shaped icons from the GCP website.
https://cloud.google.com/icons
You can also download icons from https://vecta.io/symbols/4/google-cloud-platform
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#discussion_r554925225
##########
File path: airflow/providers/apache/livy/provider.yaml
##########
@@ -26,6 +26,7 @@ versions:
integrations:
- integration-name: Apache Livy
external-doc-url: https://livy.apache.org/
+ logo: /integration-logos/apache/livy.png
Review comment:
```suggestion
logo: /integration-logos/apache/Livy.png
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-760584911
thought i followed the instructions on rebasing but I feel like I messed something up. Did i mess something up @potiuk & @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-759403920
@griffincosgrove I can still see some logos have chess backgrounds.
<img width="290" alt="Screenshot 2021-01-13 at 12 53 10" src="https://user-images.githubusercontent.com/12058428/104449663-3e668800-559f-11eb-9558-b28fc37934c8.png">
<img width="845" alt="Screenshot 2021-01-13 at 12 57 43" src="https://user-images.githubusercontent.com/12058428/104449674-41617880-559f-11eb-8407-b0046b990129.png">
<img width="216" alt="Screenshot 2021-01-13 at 12 57 51" src="https://user-images.githubusercontent.com/12058428/104449678-41fa0f00-559f-11eb-9873-63e62b6812c6.png">
<img width="210" alt="Screenshot 2021-01-13 at 12 57 57" src="https://user-images.githubusercontent.com/12058428/104449680-4292a580-559f-11eb-9ad1-87507e22145f.png">
<img width="205" alt="Screenshot 2021-01-13 at 12 58 18" src="https://user-images.githubusercontent.com/12058428/104449681-4292a580-559f-11eb-8ca7-189db65a1ef8.png">
<img width="215" alt="Screenshot 2021-01-13 at 12 58 36" src="https://user-images.githubusercontent.com/12058428/104449682-432b3c00-559f-11eb-98ab-52ca069a7cdc.png">
<img width="198" alt="Screenshot 2021-01-13 at 12 58 44" src="https://user-images.githubusercontent.com/12058428/104449684-432b3c00-559f-11eb-9975-299138544c2f.png">
I noticed one more problem. The Dataproc logo has a margin, but the other logos for GCP services have no additional margin. It looks a bit weird when several GCP services are side by side.
<img width="738" alt="Screenshot 2021-01-13 at 12 53 17" src="https://user-images.githubusercontent.com/12058428/104449670-40c8e200-559f-11eb-9708-4044ae9d5e57.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757521914
[The Workflow run](https://github.com/apache/airflow/actions/runs/475994103) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-759407000
@mik-laj Ok looks like exporting them did not fix the issue. I'll look into alternative options.
I had some difficulty with the GCP icons but I'll make that one bigger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757854415
Most look fine, but I have a reservation about the few logos that have chess in the background.
As for the AWS icon, I think it should contain an orange color.
What do you think about https://seeklogo.com/vector-logo/319188/amazon-web-services-aws ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove closed pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove closed pull request #13600:
URL: https://github.com/apache/airflow/pull/13600
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757917593
@potiuk i believe you are correct with that logic. I think for for some logos I didn't export with Gimp. I can export those and hopefully it will fix the "chess" issue.
@mik-laj i agree with the AWS logo. I can change that out as well.
Thanks for the feedback I can make these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-760881439
It looks like something is wrong. We didn't get any change. Could you please try to restore the previous versions? I'll do a rebase and it should work.
I'm not sure, but I guess you could have put the main branch together and then rebase it. This can cause problems because Git cannot find the correct commits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757520117
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#discussion_r554925397
##########
File path: airflow/providers/google/provider.yaml
##########
@@ -182,11 +191,13 @@ integrations:
tags: [gcp]
- integration-name: Google Data Proc
external-doc-url: https://cloud.yandex.com/services/data-proc
+ logo: /integration-logos/gcp/Google-Data-Proc.png
tags: [gcp]
- integration-name: Google Data Catalog
external-doc-url: https://cloud.google.com/data-catalog
how-to-guide:
- /docs/apache-airflow-providers-google/operators/cloud/datacatalog.rst
+ logo: /integration-logos/gcp/Google-Cloud-Data-Catalog.png
Review comment:
```suggestion
logo: /integration-logos/gcp/Google-Data-Catalog.png
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-760189472
Hello @griffincosgrove -> please rebase again :( - there was a problem I fixed in master just now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757523002
@mik-laj addresses issue #13110. Let me know if any further action by me is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-757826700
Pre-commit detected a few path issues so I fixed them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#discussion_r554925720
##########
File path: airflow/providers/google/provider.yaml
##########
@@ -74,11 +77,13 @@ integrations:
external-doc-url: https://cloud.google.com/dlp/
how-to-guide:
- /docs/apache-airflow-providers-google/operators/cloud/data_loss_prevention.rst
+ logo: /integration-logos/gcp/Google-Data-Loss-Prevention.png
Review comment:
```suggestion
logo: /integration-logos/gcp/google-data-loss-prevention.png
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-760881844
You can also create a new PR if you manage to recover the files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#discussion_r554926033
##########
File path: airflow/providers/google/provider.yaml
##########
@@ -216,41 +229,51 @@ integrations:
tags: [gcp]
- integration-name: Google Deployment Manager
external-doc-url: https://cloud.google.com/deployment-manager/
+ logo: /integration-logos/gcp/Google-Deployment-Manager.png
tags: [gcp]
- integration-name: Google API Python Client
external-doc-url: https://github.com/googleapis/google-api-python-client
+ logo: /integration-logos/gcp/Google-API-Python-Client.png
tags: [google]
- integration-name: Google Campaign Manager
external-doc-url: https://developers.google.com/doubleclick-advertisers
how-to-guide:
- /docs/apache-airflow-providers-google/operators/marketing_platform/campaign_manager.rst
+ logo: /integration-logos/gcp/Google-Campaign-Manager.png
tags: [gcp]
- integration-name: Google Cloud
external-doc-url: https://cloud.google.com/
+ logo: /integration-logos/gcp/Google-Cloud.png
tags: [gcp]
- integration-name: Google Discovery API
external-doc-url: https://developers.google.com/discovery
+ logo: /integration-logos/gcp/Google-Cloud-Generic.png
tags: [google]
- integration-name: Google Display&Video 360
external-doc-url: https://marketingplatform.google.com/about/display-video-360/
how-to-guide:
- /docs/apache-airflow-providers-google/operators/marketing_platform/display_video.rst
+ logo: /integration-logos/gcp/Google-Display-And-Video360.png
Review comment:
```suggestion
logo: /integration-logos/gcp/Google-Display-And-Video-360.png
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] griffincosgrove commented on pull request #13600: Add missing logos for integrations closes #13110
Posted by GitBox <gi...@apache.org>.
griffincosgrove commented on pull request #13600:
URL: https://github.com/apache/airflow/pull/13600#issuecomment-759570609
@mik-laj thanks! I downloaded and used the png/svg icons zip where appropriate. I will replace the G Data Proc icon and search for new ones for those checker icons.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org