You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jd...@apache.org on 2007/05/01 09:07:42 UTC

svn commit: r533954 - in /incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup: ComponentCreateTagTest.java ComponentCreateTag_6.java

Author: jdonnerstag
Date: Tue May  1 00:07:41 2007
New Revision: 533954

URL: http://svn.apache.org/viewvc?view=rev&rev=533954
Log:
wicket-503: Cannot use WicketTester with a custom session

this is probably outdated. I changed ComponentCreateTag_6 which is referenced in the mail and it works.

Modified:
    incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTagTest.java
    incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTag_6.java

Modified: incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTagTest.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTagTest.java?view=diff&rev=533954&r1=533953&r2=533954
==============================================================================
--- incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTagTest.java (original)
+++ incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTagTest.java Tue May  1 00:07:41 2007
@@ -16,7 +16,15 @@
  */
 package org.apache.wicket.markup;
 
+import java.util.Locale;
+
+import org.apache.wicket.Request;
+import org.apache.wicket.Response;
+import org.apache.wicket.Session;
 import org.apache.wicket.WicketTestCase;
+import org.apache.wicket.protocol.http.WebApplication;
+import org.apache.wicket.util.tester.WicketTester;
+import org.apache.wicket.util.tester.WicketTester.DummyWebApplication;
 
 
 /**
@@ -89,6 +97,21 @@
 	 */
 	public void testRenderHomePage_6() throws Exception
 	{
+		WebApplication myApplication = new DummyWebApplication()
+		{
+			/**
+			 * @see org.apache.wicket.protocol.http.WebApplication#newSession(org.apache.wicket.Request, org.apache.wicket.Response)
+			 */
+			public Session newSession(Request request, Response response)
+			{
+				Session session = super.newSession(request, response);
+				session.setLocale(Locale.ENGLISH);
+				return session;
+			}
+		};
+		
+		tester = new WicketTester(myApplication);
+
 		tester.getApplication().getMarkupSettings().setStripWicketTags(true);
 	    executeTest(ComponentCreateTag_6.class, "ComponentCreateTagExpectedResult_6.html");
 	}

Modified: incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTag_6.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTag_6.java?view=diff&rev=533954&r1=533953&r2=533954
==============================================================================
--- incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTag_6.java (original)
+++ incubator/wicket/trunk/jdk-1.4/wicket/src/test/java/org/apache/wicket/markup/ComponentCreateTag_6.java Tue May  1 00:07:41 2007
@@ -16,9 +16,6 @@
  */
 package org.apache.wicket.markup;
 
-import java.util.Locale;
-
-import org.apache.wicket.Session;
 import org.apache.wicket.markup.html.WebPage;
 
 
@@ -36,7 +33,5 @@
 	 */
 	public ComponentCreateTag_6() 
 	{
-		// bit of a hack, but before the instance is created we don't have access to this request's session
-		Session.get().setLocale(Locale.ENGLISH);
     }
 }