You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2020/09/27 18:56:39 UTC
[GitHub] [submarine] kobe860219 opened a new pull request #414: SUBMARINE-635. [WEB] Add sync code to experiment UI
kobe860219 opened a new pull request #414:
URL: https://github.com/apache/submarine/pull/414
### What is this PR for?
Before pod starting, need to clone git-repo to /code/current.
### What type of PR is it?
[Feature]
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-635
### How should this be tested?
https://travis-ci.org/github/kobe860219/submarine/builds/730755150
### Screenshots (if appropriate)
<img width="1440" alt="截圖 2020-09-28 上午2 19 57" src="https://user-images.githubusercontent.com/48027290/94373161-283ed400-0136-11eb-985a-acf4e13623f2.png">
<img width="1440" alt="截圖 2020-09-28 上午2 21 47" src="https://user-images.githubusercontent.com/48027290/94373164-2a089780-0136-11eb-85da-df9076fbc1dd.png">
<img width="1440" alt="截圖 2020-09-28 上午2 22 41" src="https://user-images.githubusercontent.com/48027290/94373165-2aa12e00-0136-11eb-9a7d-252fbc05dd1e.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 commented on pull request #414: SUBMARINE-635. [WEB] Add sync code to experiment UI
Posted by GitBox <gi...@apache.org>.
kobe860219 commented on pull request #414:
URL: https://github.com/apache/submarine/pull/414#issuecomment-699673893
@pingsutw @xunliu Please help me review this pr. Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #414: SUBMARINE-635. [WEB] Add sync code to experiment UI
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #414:
URL: https://github.com/apache/submarine/pull/414
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on pull request #414: SUBMARINE-635. [WEB] Add sync code to experiment UI
Posted by GitBox <gi...@apache.org>.
pingsutw commented on pull request #414:
URL: https://github.com/apache/submarine/pull/414#issuecomment-699772139
Thanks @kobe860219 for the contribution
- Could you take a look at test failure
- And I think it's better to put `environment` input and button under `git repository`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] pingsutw commented on a change in pull request #414: SUBMARINE-635. [WEB] Add sync code to experiment UI
Posted by GitBox <gi...@apache.org>.
pingsutw commented on a change in pull request #414:
URL: https://github.com/apache/submarine/pull/414#discussion_r495678354
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-customized-form/experiment-customized-form.component.html
##########
@@ -262,6 +277,7 @@
{{ item.value.resources }}
</nz-descriptions-item>
</div>
+ <nz-descriptions-item nzTitle="Git repo">{{ finialExperimentSpec.code.url }}</nz-descriptions-item>
Review comment:
```suggestion
<nz-descriptions-item nzTitle="Git repository">{{ finialExperimentSpec.code.url }}</nz-descriptions-item>
```
##########
File path: submarine-workbench/workbench-web-ng/src/app/pages/workbench/experiment/experiment-customized-form/experiment-customized-form.component.html
##########
@@ -130,6 +130,21 @@
<button nz-button id="env-btn" style="display: block; margin: auto;" nzType="primary" (click)="onCreateEnv()">
Add new environment variable
</button>
+ <br />
+ </div>
+ <div class="single-field-group">
Review comment:
```suggestion
<div *ngIf="ADVANCED" class="single-field-group">
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org