You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/19 21:20:03 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3589: ARTEMIS-3294 Fix testTextMessageAttributeLimits
brusdev opened a new pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3589: ARTEMIS-3294 Fix testTextMessageAttributeLimits
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gtully commented on a change in pull request #3589: ARTEMIS-3294 Fix testTextMessageAttributeLimits
Posted by GitBox <gi...@apache.org>.
gtully commented on a change in pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589#discussion_r635878475
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
##########
@@ -579,7 +579,8 @@ public void testTextMessageAttributeLimits() throws Exception {
final String twentyBytes = new String(new char[20]).replace("\0", "#");
- ClientMessage clientMessage = createTextMessage(session, twentyBytes, true);
Review comment:
is there any value in the existing test?
I guess it is possible to put anything into a core message, it is up to the reader to know that it will be possibly nullable, no? Or was the assumption just wrong. It is an error to encode a plain string?
if it is not an error, then maybe we need to include both test variants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a change in pull request #3589: ARTEMIS-3294 Fix testTextMessageAttributeLimits
Posted by GitBox <gi...@apache.org>.
brusdev commented on a change in pull request #3589:
URL: https://github.com/apache/activemq-artemis/pull/3589#discussion_r636069573
##########
File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java
##########
@@ -579,7 +579,8 @@ public void testTextMessageAttributeLimits() throws Exception {
final String twentyBytes = new String(new char[20]).replace("\0", "#");
- ClientMessage clientMessage = createTextMessage(session, twentyBytes, true);
Review comment:
I would use a nullable string to write the body of TEXT_TYPE core messages to stay consistent with the JMS client. Maybe could be worth adding some checks to enforce the body format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org