You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Sergey Grebnov (Akvelon)" <v-...@microsoft.com> on 2016/02/01 12:45:43 UTC
RE: [DISCUSS] inAppBrowser plugin release
Does anyone have any reason to delay InAppBrowser 1.2.1. patch release?
If not, I will start the release tomorrow.
To be released:
General:
CB-10428 Fix syntax error when browserifying inAppBrowser plugin
Android:
CB-10407 InAppBrowser not firing loadstart event on android
CB-6702 InAppBrowser hangs when opening more than one instance
CB-10456 InAppBrowser is not closed if I close it programmatically on Android
Windows:
CB-10454 InAppBrowser: 'loaderror' event does not have code and message on Windows
CB-10452 InAppBrowser: 'exit' event is not triggered on Windows
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10450 InAppBrowser: Unable to get property 'canGoBack' of undefined on Windows
-Sergey
-----Original Message-----
From: Sergey Grebnov (Akvelon)
Sent: Thursday, January 28, 2016 7:21 PM
To: 'dev@cordova.apache.org' <de...@cordova.apache.org>
Subject: RE: [DISCUSS] inAppBrowser plugin release
JFYI - I've addressed new issues found, could someone review PRs please.
CB-10456 InAppBrowser is not closed if I close it programmatically on Android
https://github.com/apache/cordova-plugin-inappbrowser/pull/143/files?w=1
CB-6702 InAppBrowser hangs when opening more than one instance on Android
https://github.com/apache/cordova-plugin-inappbrowser/pull/144/files?w=1
InAppBrowser bugfixing on Windows: CB-10451, CB-10452, CB-10454
https://github.com/apache/cordova-plugin-inappbrowser/pull/145/files?w=1
-Sergey
-----Original Message-----
From: Sergey Grebnov (Akvelon)
Sent: Wednesday, January 27, 2016 5:28 PM
To: 'dev@cordova.apache.org' <de...@cordova.apache.org>
Subject: RE: [DISCUSS] inAppBrowser plugin release
I've implemented unit tests for plugin core functionality and events (see PR [1]) and reported new bugs below. There is only one bad issue on Android which leads to InAppBrowser window hang (CB-10456, CB-6702), a few issues on Windows; iOS is doing well. I'm going to address them tomorrow so propose to wait one more day and do another plugin release.
CB-10456 InAppBrowser hangs if I close it programmatically on Android
CB-6702 InAppBrowser hangs when opening more than one instance
CB-10454 InAppBrowser: 'loaderror' event does not have code and message on Windows
CB-10452 InAppBrowser: 'exit' event is not triggered on Windows
CB-10451 InAppBrowser: loadstart event is not triggered on Windows
CB-10450 InAppBrowser: Unable to get property 'canGoBack' of undefined on Windows
[1] https://github.com/apache/cordova-plugin-inappbrowser/pull/142
-Sergey
-----Original Message-----
From: Sergey Grebnov (Akvelon)
Sent: Tuesday, January 26, 2016 4:19 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] inAppBrowser plugin release
Looks like we don't have auto tests for InAppBrowser plugin at all. We should write sanity test to ensure plugin is successfully initialized at least (there is cordova.InAppBrowser.open method available). I also think that it is doable to write auto tests for main events (load start/stop, etc) as well.
PS. CB-10428 has been resolved by the following PR: https://github.com/apache/cordova-plugin-inappbrowser/pull/141/files?w=1
-Sergey
-----Original Message-----
From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
Sent: Tuesday, January 26, 2016 12:43 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] inAppBrowser plugin release
Looks like there is another regression w.r.t. browserify workflow CB-10428 for Cordova-inappbrowser.
And this one for cordova-plugin-file: https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10419&data=01%7c01%7cv-segreb%40microsoft.com%7c87655d4803a54891496f08d325d090c1%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=VT5z308fXUhduPr40kC6zA0IsPT4apTeA%2fnStCYkFG8%3d
We might to rev those and re-release.
-Nikhil
-----Original Message-----
From: Nikhil Khandelwal [mailto:nikhilkh@microsoft.com]
Sent: Monday, January 25, 2016 10:23 AM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] inAppBrowser plugin release
I'm curious what caused the regression? Why do we not have tests for this important scenario?
-Nikhil
-----Original Message-----
From: Steven Gill [mailto:stevengill97@gmail.com]
Sent: Monday, January 25, 2016 1:19 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] inAppBrowser plugin release
+1 Lets do it!
On Mon, Jan 25, 2016 at 1:00 AM, julio cesar sanchez <jcesarmobile@gmail.com
> wrote:
> On latest release of inAppBrowser plugin the loadstart event stopped
> working on android.
> It has been fixed on the 1.2.1-dev.
> Should we release it?
>
> I think loadstart is very important and a lot of apps rely on it for
> closing the window.
>
B KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB [ X ܚX KK[XZ[ ] ][ X ܚX P ܙݘK \X K ܙ B ܈Y][ۘ[ [X[ K[XZ[ ] Z[ ܙݘK \X K ܙ B B KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB [ X ܚX KK[XZ[ ] ][ X ܚX P ܙݘK \X K ܙ B ܈Y][ۘ[ [X[ K[XZ[ ] Z[ ܙݘK \X K ܙ B
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org