You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/08 15:59:41 UTC

[GitHub] [airflow] ashb commented on a change in pull request #6284: [AIRFLOW-5102] Worker jobs should terminate themselves if they can't heartbeat

ashb commented on a change in pull request #6284: [AIRFLOW-5102] Worker jobs should terminate themselves if they can't heartbeat
URL: https://github.com/apache/airflow/pull/6284#discussion_r332597609
 
 

 ##########
 File path: tests/jobs/test_local_task_job.py
 ##########
 @@ -111,8 +111,7 @@ def test_localtaskjob_heartbeat(self, mock_pid):
         session.merge(ti)
         session.commit()
 
-        ret = job1.heartbeat_callback()
-        self.assertEqual(ret, None)
+        job1.heartbeat_callback()
 
 Review comment:
   This change was cos pylint started complaining about it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services