You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-dev@hadoop.apache.org by Sean Busbey <sb...@apple.com.INVALID> on 2021/05/19 21:11:31 UTC
[DISCUSS] Change project style guidelines to allow line length 100
Hello!
What do folks think about changing our line length guidelines to allow for 100 character width?
Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
Does anyone feel strongly about keeping the line length limit at 80 characters?
Does anyone feel strongly about contributions coming in that clear up line length violations?
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
Based on the positive feedback, filed
https://issues.apache.org/jira/browse/HADOOP-17813 to update the
checkstyle rule.
I don't think it requires a vote thread.
Thanks and regards,
Akira
On Sun, Jun 13, 2021 at 1:14 AM Steve Loughran
<st...@cloudera.com.invalid> wrote:
>
> +1
>
> if you look closely the hadoop-azure module went to 100 lines a while back
> and all is good
>
> On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow for
> > 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some exception
> > unrelated to line length. That guide says width of 80 is the standard and
> > our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> > ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I suspect
> > these longer lines leaking past the checkstyle precommit warning might be a
> > reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up line
> > length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
Based on the positive feedback, filed
https://issues.apache.org/jira/browse/HADOOP-17813 to update the
checkstyle rule.
I don't think it requires a vote thread.
Thanks and regards,
Akira
On Sun, Jun 13, 2021 at 1:14 AM Steve Loughran
<st...@cloudera.com.invalid> wrote:
>
> +1
>
> if you look closely the hadoop-azure module went to 100 lines a while back
> and all is good
>
> On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow for
> > 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some exception
> > unrelated to line length. That guide says width of 80 is the standard and
> > our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> > ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I suspect
> > these longer lines leaking past the checkstyle precommit warning might be a
> > reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up line
> > length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
Based on the positive feedback, filed
https://issues.apache.org/jira/browse/HADOOP-17813 to update the
checkstyle rule.
I don't think it requires a vote thread.
Thanks and regards,
Akira
On Sun, Jun 13, 2021 at 1:14 AM Steve Loughran
<st...@cloudera.com.invalid> wrote:
>
> +1
>
> if you look closely the hadoop-azure module went to 100 lines a while back
> and all is good
>
> On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow for
> > 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some exception
> > unrelated to line length. That guide says width of 80 is the standard and
> > our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> > ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I suspect
> > these longer lines leaking past the checkstyle precommit warning might be a
> > reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up line
> > length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
Based on the positive feedback, filed
https://issues.apache.org/jira/browse/HADOOP-17813 to update the
checkstyle rule.
I don't think it requires a vote thread.
Thanks and regards,
Akira
On Sun, Jun 13, 2021 at 1:14 AM Steve Loughran
<st...@cloudera.com.invalid> wrote:
>
> +1
>
> if you look closely the hadoop-azure module went to 100 lines a while back
> and all is good
>
> On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow for
> > 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some exception
> > unrelated to line length. That guide says width of 80 is the standard and
> > our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> > ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I suspect
> > these longer lines leaking past the checkstyle precommit warning might be a
> > reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up line
> > length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Steve Loughran <st...@cloudera.com.INVALID>.
+1
if you look closely the hadoop-azure module went to 100 lines a while back
and all is good
On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
> Hello!
>
> What do folks think about changing our line length guidelines to allow for
> 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception
> unrelated to line length. That guide says width of 80 is the standard and
> our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80
> characters?
>
> Does anyone feel strongly about contributions coming in that clear up line
> length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
>
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Szilard Nemeth <sn...@cloudera.com.INVALID>.
Thanks for this initiative, Sean.
+1 for increasing the length to 100 characters.
I can't see a VOTE thread regarding this subject. Am I missing something?
Best,
Szilard
On Mon, May 24, 2021 at 11:49 PM Jonathan Eagles <je...@gmail.com> wrote:
> In apache tez, formal line length is 120 characters. So, I recommend 120+
>
> On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <kihwal@verizonmedia.com
> .invalid>
> wrote:
>
> > +1 for the 100 char limit.
> > But I would have liked 132 columns more. :)
> >
> > Kihwal
> >
> > On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi folks!
> > >
> > > The consensus seems pretty strongly in favor of increasing the line
> > length
> > > limit. Do folks still want to see a formal VOTE thread?
> > >
> > >
> > > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > > wrote:
> > > >
> > > > Hello!
> > > >
> > > > What do folks think about changing our line length guidelines to
> allow
> > > for 100 character width?
> > > >
> > > > Currently, we tell folks to follow the sun style guide with some
> > > exception unrelated to line length. That guide says width of 80 is the
> > > standard and our current check style rules act as enforcement.
> > > >
> > > > Looking at the current trunk codebase our nightly build shows a total
> > of
> > > ~15k line length violations; it’s about 18% of identified checkstyle
> > issues.
> > > >
> > > > The vast majority of those line length violations are <= 100
> characters
> > > long. 100 characters happens to be the length for the Google Java Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning might
> > be a
> > > reflection of committers working across multiple java codebases.
> > > >
> > > > I don’t feel strongly about lines being longer, but I would like to
> > move
> > > towards more consistent style enforcement as a project. Updating our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> test
> > > cycle to get the formatting correct.
> > > >
> > > > Does anyone feel strongly about keeping the line length limit at 80
> > > characters?
> > > >
> > > > Does anyone feel strongly about contributions coming in that clear up
> > > line length violations?
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> > >
> > >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Jonathan Eagles <je...@gmail.com>.
In apache tez, formal line length is 120 characters. So, I recommend 120+
On Mon, May 24, 2021 at 4:46 PM Kihwal Lee <ki...@verizonmedia.com.invalid>
wrote:
> +1 for the 100 char limit.
> But I would have liked 132 columns more. :)
>
> Kihwal
>
> On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi folks!
> >
> > The consensus seems pretty strongly in favor of increasing the line
> length
> > limit. Do folks still want to see a formal VOTE thread?
> >
> >
> > > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> > >
> > > Hello!
> > >
> > > What do folks think about changing our line length guidelines to allow
> > for 100 character width?
> > >
> > > Currently, we tell folks to follow the sun style guide with some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >
> > > Looking at the current trunk codebase our nightly build shows a total
> of
> > ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> > >
> > > The vast majority of those line length violations are <= 100 characters
> > long. 100 characters happens to be the length for the Google Java Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning might
> be a
> > reflection of committers working across multiple java codebases.
> > >
> > > I don’t feel strongly about lines being longer, but I would like to
> move
> > towards more consistent style enforcement as a project. Updating our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit test
> > cycle to get the formatting correct.
> > >
> > > Does anyone feel strongly about keeping the line length limit at 80
> > characters?
> > >
> > > Does anyone feel strongly about contributions coming in that clear up
> > line length violations?
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
> >
> >
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Kihwal Lee <ki...@verizonmedia.com.INVALID>.
+1 for the 100 char limit.
But I would have liked 132 columns more. :)
Kihwal
On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi folks!
>
> The consensus seems pretty strongly in favor of increasing the line length
> limit. Do folks still want to see a formal VOTE thread?
>
>
> > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Kihwal Lee <ki...@verizonmedia.com.INVALID>.
+1 for the 100 char limit.
But I would have liked 132 columns more. :)
Kihwal
On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi folks!
>
> The consensus seems pretty strongly in favor of increasing the line length
> limit. Do folks still want to see a formal VOTE thread?
>
>
> > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Kihwal Lee <ki...@verizonmedia.com.INVALID>.
+1 for the 100 char limit.
But I would have liked 132 columns more. :)
Kihwal
On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi folks!
>
> The consensus seems pretty strongly in favor of increasing the line length
> limit. Do folks still want to see a formal VOTE thread?
>
>
> > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [E] Re: [DISCUSS] Change project style guidelines to allow line
length 100
Posted by Kihwal Lee <ki...@verizonmedia.com.INVALID>.
+1 for the 100 char limit.
But I would have liked 132 columns more. :)
Kihwal
On Mon, May 24, 2021 at 1:46 PM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi folks!
>
> The consensus seems pretty strongly in favor of increasing the line length
> limit. Do folks still want to see a formal VOTE thread?
>
>
> > On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi folks!
The consensus seems pretty strongly in favor of increasing the line length limit. Do folks still want to see a formal VOTE thread?
> On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by John Zhuge <jz...@apache.org>.
+1
On Thu, May 20, 2021 at 6:23 PM Takanobu Asanuma <ta...@apache.org>
wrote:
> +1 for 100 characters. Thanks.
>
> 2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
>
> > +1. I think this will be very helpful.
> >
> > On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> >
> > > +1 (binding). It's long overdue IMHO.
> > >
> > > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > > <sh...@cloudera.com.invalid> wrote:
> > >
> > > > I really like this initiative, thank you!
> > > > +1 for line length increase to 100 characters.
> > > >
> > > > Regards,
> > > > Gergely Pollak
> > > >
> > > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> > vivekratnavel@apache.org
> > > >
> > > > wrote:
> > > >
> > > > > +1 (non-binding) to increase line length to 100 characters. This
> will
> > > > > definitely help clear most of the checkstyle violations.
> > > > >
> > > > > Thank you Sean for starting this thread!
> > > > >
> > > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> > <sbusbey@apple.com.invalid
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Bhavik!
> > > > > >
> > > > > > What concerns do you have about back porting patches to earlier
> > > release
> > > > > > branches?
> > > > > >
> > > > > > If we change our style guidelines then presumably we can do that
> > for
> > > > all
> > > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail
> a
> > > > style
> > > > > > check on the destination branch unless something changed in the
> > > > > backporting.
> > > > > >
> > > > > > If you are referring to patches for clearing up line length
> > > violations,
> > > > > my
> > > > > > usual preference is to aim for my changes to be on all active
> > release
> > > > > > lines. So at least in the case of the patches coming from me or
> > being
> > > > > > committed by me, there’d be effort to make sure all branches end
> up
> > > as
> > > > > easy
> > > > > > to backport to as they were prior to the clean up.
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > > bhavikpatel552@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > I am just worried about the backporting of the Jira to child
> > > branch!!
> > > > > How
> > > > > > > we are planning to handle this?
> > > > > > >
> > > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com
> <mailto:
> > > > > > 821684824@qq.com>> wrote:
> > > > > > >
> > > > > > >> +1 100 is reasonable.
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> ---Original---
> > > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > > hexiaoqiao@apache.org
> > > > > > >>
> > > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > > aajisaka@apache.org
> > > > > >>;"Hadoop
> > > > > > Common"<
> > > > > > >> common-dev@hadoop.apache.org <mailto:
> > common-dev@hadoop.apache.org
> > > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > > hdfs-dev@hadoop.apache.org>
> > > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > > mapreduce-dev@hadoop.apache.org
> > > > > > >>;
> > > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to
> allow
> > > line
> > > > > > >> length 100
> > > > > > >>
> > > > > > >>
> > > > > > >> +1 for <= 100 chars long per line length.
> > > > > > >>
> > > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > > >>
> > > > > > >> > I'm +1 too.
> > > > > > >> > I feel 80 characters limit tends to degrade readability
> by
> > > > > > introducing
> > > > > > >> > useless line breaks.
> > > > > > >> >
> > > > > > >> > >
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>
> > > > > > >> ;
> > > > > > >> > I have no inconvenience on 100 characters for using Emacs
> > and
> > > > > > >> side-by-side
> > > > > > >> > diff even on 13-inch MBP.
> > > > > > >> >
> > > > > > >> > Masatake Iwasaki
> > > > > > >> >
> > > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > > >> > >
> > > > > > >> > > FYI: There were some discussions long before:
> > > > > > >> > > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> >
> > > > > > >> > > Thanks,
> > > > > > >> > > Akira
> > > > > > >> > >
> > > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> > >>
> > > > > > >> > wrote:
> > > > > > >> > >>
> > > > > > >> > >> Hello!
> > > > > > >> > >>
> > > > > > >> > >> What do folks think about changing our line
> length
> > > > > > >> guidelines to allow
> > > > > > >> > for 100 character width?
> > > > > > >> > >>
> > > > > > >> > >> Currently, we tell folks to follow the sun style
> > > guide
> > > > > > with
> > > > > > >> some
> > > > > > >> > exception unrelated to line length. That guide says width
> > of
> > > 80
> > > > > is
> > > > > > the
> > > > > > >> > standard and our current check style rules act as
> > > enforcement.
> > > > > > >> > >>
> > > > > > >> > >> Looking at the current trunk codebase our
> nightly
> > > > build
> > > > > > >> shows a total
> > > > > > >> > of ~15k line length violations; it’s about 18% of
> > identified
> > > > > > >> checkstyle
> > > > > > >> > issues.
> > > > > > >> > >>
> > > > > > >> > >> The vast majority of those line length
> violations
> > > are
> > > > <=
> > > > > > 100
> > > > > > >> characters
> > > > > > >> > long. 100 characters happens to be the length for the
> > Google
> > > > Java
> > > > > > >> Style
> > > > > > >> > Guide, another commonly adopted style guide for java
> > > projects,
> > > > > so I
> > > > > > >> suspect
> > > > > > >> > these longer lines leaking past the checkstyle precommit
> > > > warning
> > > > > > >> might be a
> > > > > > >> > reflection of committers working across multiple java
> > > > codebases.
> > > > > > >> > >>
> > > > > > >> > >> I don’t feel strongly about lines being longer,
> > but
> > > I
> > > > > > would
> > > > > > >> like to
> > > > > > >> > move towards more consistent style enforcement as a
> > project.
> > > > > > Updating
> > > > > > >> our
> > > > > > >> > project guidance to allow for 100 character lines would
> > > reduce
> > > > > the
> > > > > > >> > likelihood that folks bringing in new contributions need
> a
> > > > > > precommit
> > > > > > >> test
> > > > > > >> > cycle to get the formatting correct.
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about keeping the line
> > > > length
> > > > > > >> limit at 80
> > > > > > >> > characters?
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about contributions
> > coming
> > > > in
> > > > > > that
> > > > > > >> clear up
> > > > > > >> > line length violations?
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > >> To unsubscribe, e-mail:
> > > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > >> For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >>
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > > To unsubscribe, e-mail:
> > > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > > For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > >> > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> > For additional commands, e-mail:
> > > > > common-dev-help@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
John Zhuge
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by John Zhuge <jz...@apache.org>.
+1
On Thu, May 20, 2021 at 6:23 PM Takanobu Asanuma <ta...@apache.org>
wrote:
> +1 for 100 characters. Thanks.
>
> 2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
>
> > +1. I think this will be very helpful.
> >
> > On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> >
> > > +1 (binding). It's long overdue IMHO.
> > >
> > > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > > <sh...@cloudera.com.invalid> wrote:
> > >
> > > > I really like this initiative, thank you!
> > > > +1 for line length increase to 100 characters.
> > > >
> > > > Regards,
> > > > Gergely Pollak
> > > >
> > > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> > vivekratnavel@apache.org
> > > >
> > > > wrote:
> > > >
> > > > > +1 (non-binding) to increase line length to 100 characters. This
> will
> > > > > definitely help clear most of the checkstyle violations.
> > > > >
> > > > > Thank you Sean for starting this thread!
> > > > >
> > > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> > <sbusbey@apple.com.invalid
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Bhavik!
> > > > > >
> > > > > > What concerns do you have about back porting patches to earlier
> > > release
> > > > > > branches?
> > > > > >
> > > > > > If we change our style guidelines then presumably we can do that
> > for
> > > > all
> > > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail
> a
> > > > style
> > > > > > check on the destination branch unless something changed in the
> > > > > backporting.
> > > > > >
> > > > > > If you are referring to patches for clearing up line length
> > > violations,
> > > > > my
> > > > > > usual preference is to aim for my changes to be on all active
> > release
> > > > > > lines. So at least in the case of the patches coming from me or
> > being
> > > > > > committed by me, there’d be effort to make sure all branches end
> up
> > > as
> > > > > easy
> > > > > > to backport to as they were prior to the clean up.
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > > bhavikpatel552@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > I am just worried about the backporting of the Jira to child
> > > branch!!
> > > > > How
> > > > > > > we are planning to handle this?
> > > > > > >
> > > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com
> <mailto:
> > > > > > 821684824@qq.com>> wrote:
> > > > > > >
> > > > > > >> +1 100 is reasonable.
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> ---Original---
> > > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > > hexiaoqiao@apache.org
> > > > > > >>
> > > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > > aajisaka@apache.org
> > > > > >>;"Hadoop
> > > > > > Common"<
> > > > > > >> common-dev@hadoop.apache.org <mailto:
> > common-dev@hadoop.apache.org
> > > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > > hdfs-dev@hadoop.apache.org>
> > > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > > mapreduce-dev@hadoop.apache.org
> > > > > > >>;
> > > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to
> allow
> > > line
> > > > > > >> length 100
> > > > > > >>
> > > > > > >>
> > > > > > >> +1 for <= 100 chars long per line length.
> > > > > > >>
> > > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > > >>
> > > > > > >> > I'm +1 too.
> > > > > > >> > I feel 80 characters limit tends to degrade readability
> by
> > > > > > introducing
> > > > > > >> > useless line breaks.
> > > > > > >> >
> > > > > > >> > >
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>
> > > > > > >> ;
> > > > > > >> > I have no inconvenience on 100 characters for using Emacs
> > and
> > > > > > >> side-by-side
> > > > > > >> > diff even on 13-inch MBP.
> > > > > > >> >
> > > > > > >> > Masatake Iwasaki
> > > > > > >> >
> > > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > > >> > >
> > > > > > >> > > FYI: There were some discussions long before:
> > > > > > >> > > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> >
> > > > > > >> > > Thanks,
> > > > > > >> > > Akira
> > > > > > >> > >
> > > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> > >>
> > > > > > >> > wrote:
> > > > > > >> > >>
> > > > > > >> > >> Hello!
> > > > > > >> > >>
> > > > > > >> > >> What do folks think about changing our line
> length
> > > > > > >> guidelines to allow
> > > > > > >> > for 100 character width?
> > > > > > >> > >>
> > > > > > >> > >> Currently, we tell folks to follow the sun style
> > > guide
> > > > > > with
> > > > > > >> some
> > > > > > >> > exception unrelated to line length. That guide says width
> > of
> > > 80
> > > > > is
> > > > > > the
> > > > > > >> > standard and our current check style rules act as
> > > enforcement.
> > > > > > >> > >>
> > > > > > >> > >> Looking at the current trunk codebase our
> nightly
> > > > build
> > > > > > >> shows a total
> > > > > > >> > of ~15k line length violations; it’s about 18% of
> > identified
> > > > > > >> checkstyle
> > > > > > >> > issues.
> > > > > > >> > >>
> > > > > > >> > >> The vast majority of those line length
> violations
> > > are
> > > > <=
> > > > > > 100
> > > > > > >> characters
> > > > > > >> > long. 100 characters happens to be the length for the
> > Google
> > > > Java
> > > > > > >> Style
> > > > > > >> > Guide, another commonly adopted style guide for java
> > > projects,
> > > > > so I
> > > > > > >> suspect
> > > > > > >> > these longer lines leaking past the checkstyle precommit
> > > > warning
> > > > > > >> might be a
> > > > > > >> > reflection of committers working across multiple java
> > > > codebases.
> > > > > > >> > >>
> > > > > > >> > >> I don’t feel strongly about lines being longer,
> > but
> > > I
> > > > > > would
> > > > > > >> like to
> > > > > > >> > move towards more consistent style enforcement as a
> > project.
> > > > > > Updating
> > > > > > >> our
> > > > > > >> > project guidance to allow for 100 character lines would
> > > reduce
> > > > > the
> > > > > > >> > likelihood that folks bringing in new contributions need
> a
> > > > > > precommit
> > > > > > >> test
> > > > > > >> > cycle to get the formatting correct.
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about keeping the line
> > > > length
> > > > > > >> limit at 80
> > > > > > >> > characters?
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about contributions
> > coming
> > > > in
> > > > > > that
> > > > > > >> clear up
> > > > > > >> > line length violations?
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > >> To unsubscribe, e-mail:
> > > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > >> For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >>
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > > To unsubscribe, e-mail:
> > > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > > For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > >> > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> > For additional commands, e-mail:
> > > > > common-dev-help@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
John Zhuge
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by John Zhuge <jz...@apache.org>.
+1
On Thu, May 20, 2021 at 6:23 PM Takanobu Asanuma <ta...@apache.org>
wrote:
> +1 for 100 characters. Thanks.
>
> 2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
>
> > +1. I think this will be very helpful.
> >
> > On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> >
> > > +1 (binding). It's long overdue IMHO.
> > >
> > > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > > <sh...@cloudera.com.invalid> wrote:
> > >
> > > > I really like this initiative, thank you!
> > > > +1 for line length increase to 100 characters.
> > > >
> > > > Regards,
> > > > Gergely Pollak
> > > >
> > > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> > vivekratnavel@apache.org
> > > >
> > > > wrote:
> > > >
> > > > > +1 (non-binding) to increase line length to 100 characters. This
> will
> > > > > definitely help clear most of the checkstyle violations.
> > > > >
> > > > > Thank you Sean for starting this thread!
> > > > >
> > > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> > <sbusbey@apple.com.invalid
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Bhavik!
> > > > > >
> > > > > > What concerns do you have about back porting patches to earlier
> > > release
> > > > > > branches?
> > > > > >
> > > > > > If we change our style guidelines then presumably we can do that
> > for
> > > > all
> > > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail
> a
> > > > style
> > > > > > check on the destination branch unless something changed in the
> > > > > backporting.
> > > > > >
> > > > > > If you are referring to patches for clearing up line length
> > > violations,
> > > > > my
> > > > > > usual preference is to aim for my changes to be on all active
> > release
> > > > > > lines. So at least in the case of the patches coming from me or
> > being
> > > > > > committed by me, there’d be effort to make sure all branches end
> up
> > > as
> > > > > easy
> > > > > > to backport to as they were prior to the clean up.
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > > bhavikpatel552@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > I am just worried about the backporting of the Jira to child
> > > branch!!
> > > > > How
> > > > > > > we are planning to handle this?
> > > > > > >
> > > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com
> <mailto:
> > > > > > 821684824@qq.com>> wrote:
> > > > > > >
> > > > > > >> +1 100 is reasonable.
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> ---Original---
> > > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > > hexiaoqiao@apache.org
> > > > > > >>
> > > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > > aajisaka@apache.org
> > > > > >>;"Hadoop
> > > > > > Common"<
> > > > > > >> common-dev@hadoop.apache.org <mailto:
> > common-dev@hadoop.apache.org
> > > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > > hdfs-dev@hadoop.apache.org>
> > > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > > mapreduce-dev@hadoop.apache.org
> > > > > > >>;
> > > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to
> allow
> > > line
> > > > > > >> length 100
> > > > > > >>
> > > > > > >>
> > > > > > >> +1 for <= 100 chars long per line length.
> > > > > > >>
> > > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > > >>
> > > > > > >> > I'm +1 too.
> > > > > > >> > I feel 80 characters limit tends to degrade readability
> by
> > > > > > introducing
> > > > > > >> > useless line breaks.
> > > > > > >> >
> > > > > > >> > >
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>
> > > > > > >> ;
> > > > > > >> > I have no inconvenience on 100 characters for using Emacs
> > and
> > > > > > >> side-by-side
> > > > > > >> > diff even on 13-inch MBP.
> > > > > > >> >
> > > > > > >> > Masatake Iwasaki
> > > > > > >> >
> > > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > > >> > >
> > > > > > >> > > FYI: There were some discussions long before:
> > > > > > >> > > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> >
> > > > > > >> > > Thanks,
> > > > > > >> > > Akira
> > > > > > >> > >
> > > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> > >>
> > > > > > >> > wrote:
> > > > > > >> > >>
> > > > > > >> > >> Hello!
> > > > > > >> > >>
> > > > > > >> > >> What do folks think about changing our line
> length
> > > > > > >> guidelines to allow
> > > > > > >> > for 100 character width?
> > > > > > >> > >>
> > > > > > >> > >> Currently, we tell folks to follow the sun style
> > > guide
> > > > > > with
> > > > > > >> some
> > > > > > >> > exception unrelated to line length. That guide says width
> > of
> > > 80
> > > > > is
> > > > > > the
> > > > > > >> > standard and our current check style rules act as
> > > enforcement.
> > > > > > >> > >>
> > > > > > >> > >> Looking at the current trunk codebase our
> nightly
> > > > build
> > > > > > >> shows a total
> > > > > > >> > of ~15k line length violations; it’s about 18% of
> > identified
> > > > > > >> checkstyle
> > > > > > >> > issues.
> > > > > > >> > >>
> > > > > > >> > >> The vast majority of those line length
> violations
> > > are
> > > > <=
> > > > > > 100
> > > > > > >> characters
> > > > > > >> > long. 100 characters happens to be the length for the
> > Google
> > > > Java
> > > > > > >> Style
> > > > > > >> > Guide, another commonly adopted style guide for java
> > > projects,
> > > > > so I
> > > > > > >> suspect
> > > > > > >> > these longer lines leaking past the checkstyle precommit
> > > > warning
> > > > > > >> might be a
> > > > > > >> > reflection of committers working across multiple java
> > > > codebases.
> > > > > > >> > >>
> > > > > > >> > >> I don’t feel strongly about lines being longer,
> > but
> > > I
> > > > > > would
> > > > > > >> like to
> > > > > > >> > move towards more consistent style enforcement as a
> > project.
> > > > > > Updating
> > > > > > >> our
> > > > > > >> > project guidance to allow for 100 character lines would
> > > reduce
> > > > > the
> > > > > > >> > likelihood that folks bringing in new contributions need
> a
> > > > > > precommit
> > > > > > >> test
> > > > > > >> > cycle to get the formatting correct.
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about keeping the line
> > > > length
> > > > > > >> limit at 80
> > > > > > >> > characters?
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about contributions
> > coming
> > > > in
> > > > > > that
> > > > > > >> clear up
> > > > > > >> > line length violations?
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > >> To unsubscribe, e-mail:
> > > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > >> For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >>
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > > To unsubscribe, e-mail:
> > > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > > For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > >> > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> > For additional commands, e-mail:
> > > > > common-dev-help@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
John Zhuge
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by John Zhuge <jz...@apache.org>.
+1
On Thu, May 20, 2021 at 6:23 PM Takanobu Asanuma <ta...@apache.org>
wrote:
> +1 for 100 characters. Thanks.
>
> 2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
>
> > +1. I think this will be very helpful.
> >
> > On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> >
> > > +1 (binding). It's long overdue IMHO.
> > >
> > > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > > <sh...@cloudera.com.invalid> wrote:
> > >
> > > > I really like this initiative, thank you!
> > > > +1 for line length increase to 100 characters.
> > > >
> > > > Regards,
> > > > Gergely Pollak
> > > >
> > > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> > vivekratnavel@apache.org
> > > >
> > > > wrote:
> > > >
> > > > > +1 (non-binding) to increase line length to 100 characters. This
> will
> > > > > definitely help clear most of the checkstyle violations.
> > > > >
> > > > > Thank you Sean for starting this thread!
> > > > >
> > > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> > <sbusbey@apple.com.invalid
> > > >
> > > > > wrote:
> > > > >
> > > > > > Hi Bhavik!
> > > > > >
> > > > > > What concerns do you have about back porting patches to earlier
> > > release
> > > > > > branches?
> > > > > >
> > > > > > If we change our style guidelines then presumably we can do that
> > for
> > > > all
> > > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail
> a
> > > > style
> > > > > > check on the destination branch unless something changed in the
> > > > > backporting.
> > > > > >
> > > > > > If you are referring to patches for clearing up line length
> > > violations,
> > > > > my
> > > > > > usual preference is to aim for my changes to be on all active
> > release
> > > > > > lines. So at least in the case of the patches coming from me or
> > being
> > > > > > committed by me, there’d be effort to make sure all branches end
> up
> > > as
> > > > > easy
> > > > > > to backport to as they were prior to the clean up.
> > > > > >
> > > > > >
> > > > > >
> > > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > > bhavikpatel552@gmail.com>
> > > > > > wrote:
> > > > > > >
> > > > > > > I am just worried about the backporting of the Jira to child
> > > branch!!
> > > > > How
> > > > > > > we are planning to handle this?
> > > > > > >
> > > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com
> <mailto:
> > > > > > 821684824@qq.com>> wrote:
> > > > > > >
> > > > > > >> +1 100 is reasonable.
> > > > > > >>
> > > > > > >>
> > > > > > >>
> > > > > > >> ---Original---
> > > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > > hexiaoqiao@apache.org
> > > > > > >>
> > > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > > aajisaka@apache.org
> > > > > >>;"Hadoop
> > > > > > Common"<
> > > > > > >> common-dev@hadoop.apache.org <mailto:
> > common-dev@hadoop.apache.org
> > > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > > hdfs-dev@hadoop.apache.org>
> > > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > > mapreduce-dev@hadoop.apache.org
> > > > > > >>;
> > > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to
> allow
> > > line
> > > > > > >> length 100
> > > > > > >>
> > > > > > >>
> > > > > > >> +1 for <= 100 chars long per line length.
> > > > > > >>
> > > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > > >>
> > > > > > >> > I'm +1 too.
> > > > > > >> > I feel 80 characters limit tends to degrade readability
> by
> > > > > > introducing
> > > > > > >> > useless line breaks.
> > > > > > >> >
> > > > > > >> > >
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>
> > > > > > >> ;
> > > > > > >> > I have no inconvenience on 100 characters for using Emacs
> > and
> > > > > > >> side-by-side
> > > > > > >> > diff even on 13-inch MBP.
> > > > > > >> >
> > > > > > >> > Masatake Iwasaki
> > > > > > >> >
> > > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > > >> > >
> > > > > > >> > > FYI: There were some discussions long before:
> > > > > > >> > > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> > -
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > > >
> > > > > > >> >
> > > > > > >> <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > > >>;
> > > > > > >> >
> > > > > > >> > > Thanks,
> > > > > > >> > > Akira
> > > > > > >> > >
> > > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> > >>
> > > > > > >> > wrote:
> > > > > > >> > >>
> > > > > > >> > >> Hello!
> > > > > > >> > >>
> > > > > > >> > >> What do folks think about changing our line
> length
> > > > > > >> guidelines to allow
> > > > > > >> > for 100 character width?
> > > > > > >> > >>
> > > > > > >> > >> Currently, we tell folks to follow the sun style
> > > guide
> > > > > > with
> > > > > > >> some
> > > > > > >> > exception unrelated to line length. That guide says width
> > of
> > > 80
> > > > > is
> > > > > > the
> > > > > > >> > standard and our current check style rules act as
> > > enforcement.
> > > > > > >> > >>
> > > > > > >> > >> Looking at the current trunk codebase our
> nightly
> > > > build
> > > > > > >> shows a total
> > > > > > >> > of ~15k line length violations; it’s about 18% of
> > identified
> > > > > > >> checkstyle
> > > > > > >> > issues.
> > > > > > >> > >>
> > > > > > >> > >> The vast majority of those line length
> violations
> > > are
> > > > <=
> > > > > > 100
> > > > > > >> characters
> > > > > > >> > long. 100 characters happens to be the length for the
> > Google
> > > > Java
> > > > > > >> Style
> > > > > > >> > Guide, another commonly adopted style guide for java
> > > projects,
> > > > > so I
> > > > > > >> suspect
> > > > > > >> > these longer lines leaking past the checkstyle precommit
> > > > warning
> > > > > > >> might be a
> > > > > > >> > reflection of committers working across multiple java
> > > > codebases.
> > > > > > >> > >>
> > > > > > >> > >> I don’t feel strongly about lines being longer,
> > but
> > > I
> > > > > > would
> > > > > > >> like to
> > > > > > >> > move towards more consistent style enforcement as a
> > project.
> > > > > > Updating
> > > > > > >> our
> > > > > > >> > project guidance to allow for 100 character lines would
> > > reduce
> > > > > the
> > > > > > >> > likelihood that folks bringing in new contributions need
> a
> > > > > > precommit
> > > > > > >> test
> > > > > > >> > cycle to get the formatting correct.
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about keeping the line
> > > > length
> > > > > > >> limit at 80
> > > > > > >> > characters?
> > > > > > >> > >>
> > > > > > >> > >> Does anyone feel strongly about contributions
> > coming
> > > > in
> > > > > > that
> > > > > > >> clear up
> > > > > > >> > line length violations?
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > >> To unsubscribe, e-mail:
> > > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > >> For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >>
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >>
> > > > ---------------------------------------------------------------------
> > > > > > >> > > To unsubscribe, e-mail:
> > > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > > >> > > For additional commands, e-mail:
> > > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > > common-dev-help@hadoop.apache.org>
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > >> > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> > For additional commands, e-mail:
> > > > > common-dev-help@hadoop.apache.org
> > > > > > <ma...@hadoop.apache.org>
> > > > > > >> >
> > > > > > >> >
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
John Zhuge
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Takanobu Asanuma <ta...@apache.org>.
+1 for 100 characters. Thanks.
2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
> +1. I think this will be very helpful.
>
> On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
>
> > +1 (binding). It's long overdue IMHO.
> >
> > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > <sh...@cloudera.com.invalid> wrote:
> >
> > > I really like this initiative, thank you!
> > > +1 for line length increase to 100 characters.
> > >
> > > Regards,
> > > Gergely Pollak
> > >
> > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> vivekratnavel@apache.org
> > >
> > > wrote:
> > >
> > > > +1 (non-binding) to increase line length to 100 characters. This will
> > > > definitely help clear most of the checkstyle violations.
> > > >
> > > > Thank you Sean for starting this thread!
> > > >
> > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> <sbusbey@apple.com.invalid
> > >
> > > > wrote:
> > > >
> > > > > Hi Bhavik!
> > > > >
> > > > > What concerns do you have about back porting patches to earlier
> > release
> > > > > branches?
> > > > >
> > > > > If we change our style guidelines then presumably we can do that
> for
> > > all
> > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > > style
> > > > > check on the destination branch unless something changed in the
> > > > backporting.
> > > > >
> > > > > If you are referring to patches for clearing up line length
> > violations,
> > > > my
> > > > > usual preference is to aim for my changes to be on all active
> release
> > > > > lines. So at least in the case of the patches coming from me or
> being
> > > > > committed by me, there’d be effort to make sure all branches end up
> > as
> > > > easy
> > > > > to backport to as they were prior to the clean up.
> > > > >
> > > > >
> > > > >
> > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > bhavikpatel552@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > I am just worried about the backporting of the Jira to child
> > branch!!
> > > > How
> > > > > > we are planning to handle this?
> > > > > >
> > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > > 821684824@qq.com>> wrote:
> > > > > >
> > > > > >> +1 100 is reasonable.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> ---Original---
> > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > hexiaoqiao@apache.org
> > > > > >>
> > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > aajisaka@apache.org
> > > > >>;"Hadoop
> > > > > Common"<
> > > > > >> common-dev@hadoop.apache.org <mailto:
> common-dev@hadoop.apache.org
> > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > hdfs-dev@hadoop.apache.org>
> > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > mapreduce-dev@hadoop.apache.org
> > > > > >>;
> > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> > line
> > > > > >> length 100
> > > > > >>
> > > > > >>
> > > > > >> +1 for <= 100 chars long per line length.
> > > > > >>
> > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > >>
> > > > > >> > I'm +1 too.
> > > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > > introducing
> > > > > >> > useless line breaks.
> > > > > >> >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>
> > > > > >> ;
> > > > > >> > I have no inconvenience on 100 characters for using Emacs
> and
> > > > > >> side-by-side
> > > > > >> > diff even on 13-inch MBP.
> > > > > >> >
> > > > > >> > Masatake Iwasaki
> > > > > >> >
> > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > >> > >
> > > > > >> > > FYI: There were some discussions long before:
> > > > > >> > > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> >
> > > > > >> > > Thanks,
> > > > > >> > > Akira
> > > > > >> > >
> > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> >>
> > > > > >> > wrote:
> > > > > >> > >>
> > > > > >> > >> Hello!
> > > > > >> > >>
> > > > > >> > >> What do folks think about changing our line length
> > > > > >> guidelines to allow
> > > > > >> > for 100 character width?
> > > > > >> > >>
> > > > > >> > >> Currently, we tell folks to follow the sun style
> > guide
> > > > > with
> > > > > >> some
> > > > > >> > exception unrelated to line length. That guide says width
> of
> > 80
> > > > is
> > > > > the
> > > > > >> > standard and our current check style rules act as
> > enforcement.
> > > > > >> > >>
> > > > > >> > >> Looking at the current trunk codebase our nightly
> > > build
> > > > > >> shows a total
> > > > > >> > of ~15k line length violations; it’s about 18% of
> identified
> > > > > >> checkstyle
> > > > > >> > issues.
> > > > > >> > >>
> > > > > >> > >> The vast majority of those line length violations
> > are
> > > <=
> > > > > 100
> > > > > >> characters
> > > > > >> > long. 100 characters happens to be the length for the
> Google
> > > Java
> > > > > >> Style
> > > > > >> > Guide, another commonly adopted style guide for java
> > projects,
> > > > so I
> > > > > >> suspect
> > > > > >> > these longer lines leaking past the checkstyle precommit
> > > warning
> > > > > >> might be a
> > > > > >> > reflection of committers working across multiple java
> > > codebases.
> > > > > >> > >>
> > > > > >> > >> I don’t feel strongly about lines being longer,
> but
> > I
> > > > > would
> > > > > >> like to
> > > > > >> > move towards more consistent style enforcement as a
> project.
> > > > > Updating
> > > > > >> our
> > > > > >> > project guidance to allow for 100 character lines would
> > reduce
> > > > the
> > > > > >> > likelihood that folks bringing in new contributions need a
> > > > > precommit
> > > > > >> test
> > > > > >> > cycle to get the formatting correct.
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about keeping the line
> > > length
> > > > > >> limit at 80
> > > > > >> > characters?
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about contributions
> coming
> > > in
> > > > > that
> > > > > >> clear up
> > > > > >> > line length violations?
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > >> To unsubscribe, e-mail:
> > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > >> For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >>
> > > > > >> > >
> > > > > >> > >
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > > To unsubscribe, e-mail:
> > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > > For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >
> > > > > >> >
> > > > > >> >
> > > > >
> ---------------------------------------------------------------------
> > > > > >> > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> > For additional commands, e-mail:
> > > > common-dev-help@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> >
> > > > > >> >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Takanobu Asanuma <ta...@apache.org>.
+1 for 100 characters. Thanks.
2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
> +1. I think this will be very helpful.
>
> On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
>
> > +1 (binding). It's long overdue IMHO.
> >
> > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > <sh...@cloudera.com.invalid> wrote:
> >
> > > I really like this initiative, thank you!
> > > +1 for line length increase to 100 characters.
> > >
> > > Regards,
> > > Gergely Pollak
> > >
> > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> vivekratnavel@apache.org
> > >
> > > wrote:
> > >
> > > > +1 (non-binding) to increase line length to 100 characters. This will
> > > > definitely help clear most of the checkstyle violations.
> > > >
> > > > Thank you Sean for starting this thread!
> > > >
> > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> <sbusbey@apple.com.invalid
> > >
> > > > wrote:
> > > >
> > > > > Hi Bhavik!
> > > > >
> > > > > What concerns do you have about back porting patches to earlier
> > release
> > > > > branches?
> > > > >
> > > > > If we change our style guidelines then presumably we can do that
> for
> > > all
> > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > > style
> > > > > check on the destination branch unless something changed in the
> > > > backporting.
> > > > >
> > > > > If you are referring to patches for clearing up line length
> > violations,
> > > > my
> > > > > usual preference is to aim for my changes to be on all active
> release
> > > > > lines. So at least in the case of the patches coming from me or
> being
> > > > > committed by me, there’d be effort to make sure all branches end up
> > as
> > > > easy
> > > > > to backport to as they were prior to the clean up.
> > > > >
> > > > >
> > > > >
> > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > bhavikpatel552@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > I am just worried about the backporting of the Jira to child
> > branch!!
> > > > How
> > > > > > we are planning to handle this?
> > > > > >
> > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > > 821684824@qq.com>> wrote:
> > > > > >
> > > > > >> +1 100 is reasonable.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> ---Original---
> > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > hexiaoqiao@apache.org
> > > > > >>
> > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > aajisaka@apache.org
> > > > >>;"Hadoop
> > > > > Common"<
> > > > > >> common-dev@hadoop.apache.org <mailto:
> common-dev@hadoop.apache.org
> > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > hdfs-dev@hadoop.apache.org>
> > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > mapreduce-dev@hadoop.apache.org
> > > > > >>;
> > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> > line
> > > > > >> length 100
> > > > > >>
> > > > > >>
> > > > > >> +1 for <= 100 chars long per line length.
> > > > > >>
> > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > >>
> > > > > >> > I'm +1 too.
> > > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > > introducing
> > > > > >> > useless line breaks.
> > > > > >> >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>
> > > > > >> ;
> > > > > >> > I have no inconvenience on 100 characters for using Emacs
> and
> > > > > >> side-by-side
> > > > > >> > diff even on 13-inch MBP.
> > > > > >> >
> > > > > >> > Masatake Iwasaki
> > > > > >> >
> > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > >> > >
> > > > > >> > > FYI: There were some discussions long before:
> > > > > >> > > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> >
> > > > > >> > > Thanks,
> > > > > >> > > Akira
> > > > > >> > >
> > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> >>
> > > > > >> > wrote:
> > > > > >> > >>
> > > > > >> > >> Hello!
> > > > > >> > >>
> > > > > >> > >> What do folks think about changing our line length
> > > > > >> guidelines to allow
> > > > > >> > for 100 character width?
> > > > > >> > >>
> > > > > >> > >> Currently, we tell folks to follow the sun style
> > guide
> > > > > with
> > > > > >> some
> > > > > >> > exception unrelated to line length. That guide says width
> of
> > 80
> > > > is
> > > > > the
> > > > > >> > standard and our current check style rules act as
> > enforcement.
> > > > > >> > >>
> > > > > >> > >> Looking at the current trunk codebase our nightly
> > > build
> > > > > >> shows a total
> > > > > >> > of ~15k line length violations; it’s about 18% of
> identified
> > > > > >> checkstyle
> > > > > >> > issues.
> > > > > >> > >>
> > > > > >> > >> The vast majority of those line length violations
> > are
> > > <=
> > > > > 100
> > > > > >> characters
> > > > > >> > long. 100 characters happens to be the length for the
> Google
> > > Java
> > > > > >> Style
> > > > > >> > Guide, another commonly adopted style guide for java
> > projects,
> > > > so I
> > > > > >> suspect
> > > > > >> > these longer lines leaking past the checkstyle precommit
> > > warning
> > > > > >> might be a
> > > > > >> > reflection of committers working across multiple java
> > > codebases.
> > > > > >> > >>
> > > > > >> > >> I don’t feel strongly about lines being longer,
> but
> > I
> > > > > would
> > > > > >> like to
> > > > > >> > move towards more consistent style enforcement as a
> project.
> > > > > Updating
> > > > > >> our
> > > > > >> > project guidance to allow for 100 character lines would
> > reduce
> > > > the
> > > > > >> > likelihood that folks bringing in new contributions need a
> > > > > precommit
> > > > > >> test
> > > > > >> > cycle to get the formatting correct.
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about keeping the line
> > > length
> > > > > >> limit at 80
> > > > > >> > characters?
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about contributions
> coming
> > > in
> > > > > that
> > > > > >> clear up
> > > > > >> > line length violations?
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > >> To unsubscribe, e-mail:
> > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > >> For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >>
> > > > > >> > >
> > > > > >> > >
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > > To unsubscribe, e-mail:
> > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > > For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >
> > > > > >> >
> > > > > >> >
> > > > >
> ---------------------------------------------------------------------
> > > > > >> > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> > For additional commands, e-mail:
> > > > common-dev-help@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> >
> > > > > >> >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Takanobu Asanuma <ta...@apache.org>.
+1 for 100 characters. Thanks.
2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
> +1. I think this will be very helpful.
>
> On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
>
> > +1 (binding). It's long overdue IMHO.
> >
> > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > <sh...@cloudera.com.invalid> wrote:
> >
> > > I really like this initiative, thank you!
> > > +1 for line length increase to 100 characters.
> > >
> > > Regards,
> > > Gergely Pollak
> > >
> > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> vivekratnavel@apache.org
> > >
> > > wrote:
> > >
> > > > +1 (non-binding) to increase line length to 100 characters. This will
> > > > definitely help clear most of the checkstyle violations.
> > > >
> > > > Thank you Sean for starting this thread!
> > > >
> > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> <sbusbey@apple.com.invalid
> > >
> > > > wrote:
> > > >
> > > > > Hi Bhavik!
> > > > >
> > > > > What concerns do you have about back porting patches to earlier
> > release
> > > > > branches?
> > > > >
> > > > > If we change our style guidelines then presumably we can do that
> for
> > > all
> > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > > style
> > > > > check on the destination branch unless something changed in the
> > > > backporting.
> > > > >
> > > > > If you are referring to patches for clearing up line length
> > violations,
> > > > my
> > > > > usual preference is to aim for my changes to be on all active
> release
> > > > > lines. So at least in the case of the patches coming from me or
> being
> > > > > committed by me, there’d be effort to make sure all branches end up
> > as
> > > > easy
> > > > > to backport to as they were prior to the clean up.
> > > > >
> > > > >
> > > > >
> > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > bhavikpatel552@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > I am just worried about the backporting of the Jira to child
> > branch!!
> > > > How
> > > > > > we are planning to handle this?
> > > > > >
> > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > > 821684824@qq.com>> wrote:
> > > > > >
> > > > > >> +1 100 is reasonable.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> ---Original---
> > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > hexiaoqiao@apache.org
> > > > > >>
> > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > aajisaka@apache.org
> > > > >>;"Hadoop
> > > > > Common"<
> > > > > >> common-dev@hadoop.apache.org <mailto:
> common-dev@hadoop.apache.org
> > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > hdfs-dev@hadoop.apache.org>
> > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > mapreduce-dev@hadoop.apache.org
> > > > > >>;
> > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> > line
> > > > > >> length 100
> > > > > >>
> > > > > >>
> > > > > >> +1 for <= 100 chars long per line length.
> > > > > >>
> > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > >>
> > > > > >> > I'm +1 too.
> > > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > > introducing
> > > > > >> > useless line breaks.
> > > > > >> >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>
> > > > > >> ;
> > > > > >> > I have no inconvenience on 100 characters for using Emacs
> and
> > > > > >> side-by-side
> > > > > >> > diff even on 13-inch MBP.
> > > > > >> >
> > > > > >> > Masatake Iwasaki
> > > > > >> >
> > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > >> > >
> > > > > >> > > FYI: There were some discussions long before:
> > > > > >> > > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> >
> > > > > >> > > Thanks,
> > > > > >> > > Akira
> > > > > >> > >
> > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> >>
> > > > > >> > wrote:
> > > > > >> > >>
> > > > > >> > >> Hello!
> > > > > >> > >>
> > > > > >> > >> What do folks think about changing our line length
> > > > > >> guidelines to allow
> > > > > >> > for 100 character width?
> > > > > >> > >>
> > > > > >> > >> Currently, we tell folks to follow the sun style
> > guide
> > > > > with
> > > > > >> some
> > > > > >> > exception unrelated to line length. That guide says width
> of
> > 80
> > > > is
> > > > > the
> > > > > >> > standard and our current check style rules act as
> > enforcement.
> > > > > >> > >>
> > > > > >> > >> Looking at the current trunk codebase our nightly
> > > build
> > > > > >> shows a total
> > > > > >> > of ~15k line length violations; it’s about 18% of
> identified
> > > > > >> checkstyle
> > > > > >> > issues.
> > > > > >> > >>
> > > > > >> > >> The vast majority of those line length violations
> > are
> > > <=
> > > > > 100
> > > > > >> characters
> > > > > >> > long. 100 characters happens to be the length for the
> Google
> > > Java
> > > > > >> Style
> > > > > >> > Guide, another commonly adopted style guide for java
> > projects,
> > > > so I
> > > > > >> suspect
> > > > > >> > these longer lines leaking past the checkstyle precommit
> > > warning
> > > > > >> might be a
> > > > > >> > reflection of committers working across multiple java
> > > codebases.
> > > > > >> > >>
> > > > > >> > >> I don’t feel strongly about lines being longer,
> but
> > I
> > > > > would
> > > > > >> like to
> > > > > >> > move towards more consistent style enforcement as a
> project.
> > > > > Updating
> > > > > >> our
> > > > > >> > project guidance to allow for 100 character lines would
> > reduce
> > > > the
> > > > > >> > likelihood that folks bringing in new contributions need a
> > > > > precommit
> > > > > >> test
> > > > > >> > cycle to get the formatting correct.
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about keeping the line
> > > length
> > > > > >> limit at 80
> > > > > >> > characters?
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about contributions
> coming
> > > in
> > > > > that
> > > > > >> clear up
> > > > > >> > line length violations?
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > >> To unsubscribe, e-mail:
> > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > >> For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >>
> > > > > >> > >
> > > > > >> > >
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > > To unsubscribe, e-mail:
> > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > > For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >
> > > > > >> >
> > > > > >> >
> > > > >
> ---------------------------------------------------------------------
> > > > > >> > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> > For additional commands, e-mail:
> > > > common-dev-help@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> >
> > > > > >> >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Takanobu Asanuma <ta...@apache.org>.
+1 for 100 characters. Thanks.
2021年5月21日(金) 8:38 Chao Sun <su...@apache.org>:
> +1. I think this will be very helpful.
>
> On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
>
> > +1 (binding). It's long overdue IMHO.
> >
> > On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> > <sh...@cloudera.com.invalid> wrote:
> >
> > > I really like this initiative, thank you!
> > > +1 for line length increase to 100 characters.
> > >
> > > Regards,
> > > Gergely Pollak
> > >
> > > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <
> vivekratnavel@apache.org
> > >
> > > wrote:
> > >
> > > > +1 (non-binding) to increase line length to 100 characters. This will
> > > > definitely help clear most of the checkstyle violations.
> > > >
> > > > Thank you Sean for starting this thread!
> > > >
> > > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey
> <sbusbey@apple.com.invalid
> > >
> > > > wrote:
> > > >
> > > > > Hi Bhavik!
> > > > >
> > > > > What concerns do you have about back porting patches to earlier
> > release
> > > > > branches?
> > > > >
> > > > > If we change our style guidelines then presumably we can do that
> for
> > > all
> > > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > > style
> > > > > check on the destination branch unless something changed in the
> > > > backporting.
> > > > >
> > > > > If you are referring to patches for clearing up line length
> > violations,
> > > > my
> > > > > usual preference is to aim for my changes to be on all active
> release
> > > > > lines. So at least in the case of the patches coming from me or
> being
> > > > > committed by me, there’d be effort to make sure all branches end up
> > as
> > > > easy
> > > > > to backport to as they were prior to the clean up.
> > > > >
> > > > >
> > > > >
> > > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> > bhavikpatel552@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > I am just worried about the backporting of the Jira to child
> > branch!!
> > > > How
> > > > > > we are planning to handle this?
> > > > > >
> > > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > > 821684824@qq.com>> wrote:
> > > > > >
> > > > > >> +1 100 is reasonable.
> > > > > >>
> > > > > >>
> > > > > >>
> > > > > >> ---Original---
> > > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > > hexiaoqiao@apache.org
> > > > > >>
> > > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > > iwasakims@oss.nttdata.co.jp>>;
> > > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> > aajisaka@apache.org
> > > > >>;"Hadoop
> > > > > Common"<
> > > > > >> common-dev@hadoop.apache.org <mailto:
> common-dev@hadoop.apache.org
> > > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > > hdfs-dev@hadoop.apache.org>
> > > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > > mapreduce-dev@hadoop.apache.org
> > > > > >>;
> > > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> > line
> > > > > >> length 100
> > > > > >>
> > > > > >>
> > > > > >> +1 for <= 100 chars long per line length.
> > > > > >>
> > > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > > >>
> > > > > >> > I'm +1 too.
> > > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > > introducing
> > > > > >> > useless line breaks.
> > > > > >> >
> > > > > >> > >
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>
> > > > > >> ;
> > > > > >> > I have no inconvenience on 100 characters for using Emacs
> and
> > > > > >> side-by-side
> > > > > >> > diff even on 13-inch MBP.
> > > > > >> >
> > > > > >> > Masatake Iwasaki
> > > > > >> >
> > > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > >> > > I'm +1 to allow <= 100 chars.
> > > > > >> > >
> > > > > >> > > FYI: There were some discussions long before:
> > > > > >> > > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> > -
> > > > > >> >
> > > > > >>
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > > >
> > > > > >> >
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > <
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > > >>;
> > > > > >> >
> > > > > >> > > Thanks,
> > > > > >> > > Akira
> > > > > >> > >
> > > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > > >> <sbusbey@apple.com.invalid <mailto:sbusbey@apple.com.invalid
> >>
> > > > > >> > wrote:
> > > > > >> > >>
> > > > > >> > >> Hello!
> > > > > >> > >>
> > > > > >> > >> What do folks think about changing our line length
> > > > > >> guidelines to allow
> > > > > >> > for 100 character width?
> > > > > >> > >>
> > > > > >> > >> Currently, we tell folks to follow the sun style
> > guide
> > > > > with
> > > > > >> some
> > > > > >> > exception unrelated to line length. That guide says width
> of
> > 80
> > > > is
> > > > > the
> > > > > >> > standard and our current check style rules act as
> > enforcement.
> > > > > >> > >>
> > > > > >> > >> Looking at the current trunk codebase our nightly
> > > build
> > > > > >> shows a total
> > > > > >> > of ~15k line length violations; it’s about 18% of
> identified
> > > > > >> checkstyle
> > > > > >> > issues.
> > > > > >> > >>
> > > > > >> > >> The vast majority of those line length violations
> > are
> > > <=
> > > > > 100
> > > > > >> characters
> > > > > >> > long. 100 characters happens to be the length for the
> Google
> > > Java
> > > > > >> Style
> > > > > >> > Guide, another commonly adopted style guide for java
> > projects,
> > > > so I
> > > > > >> suspect
> > > > > >> > these longer lines leaking past the checkstyle precommit
> > > warning
> > > > > >> might be a
> > > > > >> > reflection of committers working across multiple java
> > > codebases.
> > > > > >> > >>
> > > > > >> > >> I don’t feel strongly about lines being longer,
> but
> > I
> > > > > would
> > > > > >> like to
> > > > > >> > move towards more consistent style enforcement as a
> project.
> > > > > Updating
> > > > > >> our
> > > > > >> > project guidance to allow for 100 character lines would
> > reduce
> > > > the
> > > > > >> > likelihood that folks bringing in new contributions need a
> > > > > precommit
> > > > > >> test
> > > > > >> > cycle to get the formatting correct.
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about keeping the line
> > > length
> > > > > >> limit at 80
> > > > > >> > characters?
> > > > > >> > >>
> > > > > >> > >> Does anyone feel strongly about contributions
> coming
> > > in
> > > > > that
> > > > > >> clear up
> > > > > >> > line length violations?
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >>
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > >> To unsubscribe, e-mail:
> > > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > >> For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >>
> > > > > >> > >
> > > > > >> > >
> > > > > >>
> > > ---------------------------------------------------------------------
> > > > > >> > > To unsubscribe, e-mail:
> > > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > > >> > > For additional commands, e-mail:
> > > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > > common-dev-help@hadoop.apache.org>
> > > > > >> > >
> > > > > >> >
> > > > > >> >
> > > > >
> ---------------------------------------------------------------------
> > > > > >> > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> > For additional commands, e-mail:
> > > > common-dev-help@hadoop.apache.org
> > > > > <ma...@hadoop.apache.org>
> > > > > >> >
> > > > > >> >
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Chao Sun <su...@apache.org>.
+1. I think this will be very helpful.
On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> +1 (binding). It's long overdue IMHO.
>
> On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> <sh...@cloudera.com.invalid> wrote:
>
> > I really like this initiative, thank you!
> > +1 for line length increase to 100 characters.
> >
> > Regards,
> > Gergely Pollak
> >
> > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vivekratnavel@apache.org
> >
> > wrote:
> >
> > > +1 (non-binding) to increase line length to 100 characters. This will
> > > definitely help clear most of the checkstyle violations.
> > >
> > > Thank you Sean for starting this thread!
> > >
> > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sbusbey@apple.com.invalid
> >
> > > wrote:
> > >
> > > > Hi Bhavik!
> > > >
> > > > What concerns do you have about back porting patches to earlier
> release
> > > > branches?
> > > >
> > > > If we change our style guidelines then presumably we can do that for
> > all
> > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > style
> > > > check on the destination branch unless something changed in the
> > > backporting.
> > > >
> > > > If you are referring to patches for clearing up line length
> violations,
> > > my
> > > > usual preference is to aim for my changes to be on all active release
> > > > lines. So at least in the case of the patches coming from me or being
> > > > committed by me, there’d be effort to make sure all branches end up
> as
> > > easy
> > > > to backport to as they were prior to the clean up.
> > > >
> > > >
> > > >
> > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> bhavikpatel552@gmail.com>
> > > > wrote:
> > > > >
> > > > > I am just worried about the backporting of the Jira to child
> branch!!
> > > How
> > > > > we are planning to handle this?
> > > > >
> > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > 821684824@qq.com>> wrote:
> > > > >
> > > > >> +1 100 is reasonable.
> > > > >>
> > > > >>
> > > > >>
> > > > >> ---Original---
> > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > hexiaoqiao@apache.org
> > > > >>
> > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > iwasakims@oss.nttdata.co.jp>>;
> > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> aajisaka@apache.org
> > > >>;"Hadoop
> > > > Common"<
> > > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > hdfs-dev@hadoop.apache.org>
> > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > mapreduce-dev@hadoop.apache.org
> > > > >>;
> > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> line
> > > > >> length 100
> > > > >>
> > > > >>
> > > > >> +1 for <= 100 chars long per line length.
> > > > >>
> > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > >>
> > > > >> > I'm +1 too.
> > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > introducing
> > > > >> > useless line breaks.
> > > > >> >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>
> > > > >> ;
> > > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > > >> side-by-side
> > > > >> > diff even on 13-inch MBP.
> > > > >> >
> > > > >> > Masatake Iwasaki
> > > > >> >
> > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > >> > > I'm +1 to allow <= 100 chars.
> > > > >> > >
> > > > >> > > FYI: There were some discussions long before:
> > > > >> > > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> >
> > > > >> > > Thanks,
> > > > >> > > Akira
> > > > >> > >
> > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > > >> > wrote:
> > > > >> > >>
> > > > >> > >> Hello!
> > > > >> > >>
> > > > >> > >> What do folks think about changing our line length
> > > > >> guidelines to allow
> > > > >> > for 100 character width?
> > > > >> > >>
> > > > >> > >> Currently, we tell folks to follow the sun style
> guide
> > > > with
> > > > >> some
> > > > >> > exception unrelated to line length. That guide says width of
> 80
> > > is
> > > > the
> > > > >> > standard and our current check style rules act as
> enforcement.
> > > > >> > >>
> > > > >> > >> Looking at the current trunk codebase our nightly
> > build
> > > > >> shows a total
> > > > >> > of ~15k line length violations; it’s about 18% of identified
> > > > >> checkstyle
> > > > >> > issues.
> > > > >> > >>
> > > > >> > >> The vast majority of those line length violations
> are
> > <=
> > > > 100
> > > > >> characters
> > > > >> > long. 100 characters happens to be the length for the Google
> > Java
> > > > >> Style
> > > > >> > Guide, another commonly adopted style guide for java
> projects,
> > > so I
> > > > >> suspect
> > > > >> > these longer lines leaking past the checkstyle precommit
> > warning
> > > > >> might be a
> > > > >> > reflection of committers working across multiple java
> > codebases.
> > > > >> > >>
> > > > >> > >> I don’t feel strongly about lines being longer, but
> I
> > > > would
> > > > >> like to
> > > > >> > move towards more consistent style enforcement as a project.
> > > > Updating
> > > > >> our
> > > > >> > project guidance to allow for 100 character lines would
> reduce
> > > the
> > > > >> > likelihood that folks bringing in new contributions need a
> > > > precommit
> > > > >> test
> > > > >> > cycle to get the formatting correct.
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about keeping the line
> > length
> > > > >> limit at 80
> > > > >> > characters?
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about contributions coming
> > in
> > > > that
> > > > >> clear up
> > > > >> > line length violations?
> > > > >> > >>
> > > > >> > >>
> > > > >> > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > >> To unsubscribe, e-mail:
> > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > >> For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >>
> > > > >> > >
> > > > >> > >
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > > For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >
> > > > >> >
> > > > >> >
> > > > ---------------------------------------------------------------------
> > > > >> > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> >
> > > > >> >
> > > >
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Chao Sun <su...@apache.org>.
+1. I think this will be very helpful.
On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> +1 (binding). It's long overdue IMHO.
>
> On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> <sh...@cloudera.com.invalid> wrote:
>
> > I really like this initiative, thank you!
> > +1 for line length increase to 100 characters.
> >
> > Regards,
> > Gergely Pollak
> >
> > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vivekratnavel@apache.org
> >
> > wrote:
> >
> > > +1 (non-binding) to increase line length to 100 characters. This will
> > > definitely help clear most of the checkstyle violations.
> > >
> > > Thank you Sean for starting this thread!
> > >
> > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sbusbey@apple.com.invalid
> >
> > > wrote:
> > >
> > > > Hi Bhavik!
> > > >
> > > > What concerns do you have about back porting patches to earlier
> release
> > > > branches?
> > > >
> > > > If we change our style guidelines then presumably we can do that for
> > all
> > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > style
> > > > check on the destination branch unless something changed in the
> > > backporting.
> > > >
> > > > If you are referring to patches for clearing up line length
> violations,
> > > my
> > > > usual preference is to aim for my changes to be on all active release
> > > > lines. So at least in the case of the patches coming from me or being
> > > > committed by me, there’d be effort to make sure all branches end up
> as
> > > easy
> > > > to backport to as they were prior to the clean up.
> > > >
> > > >
> > > >
> > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> bhavikpatel552@gmail.com>
> > > > wrote:
> > > > >
> > > > > I am just worried about the backporting of the Jira to child
> branch!!
> > > How
> > > > > we are planning to handle this?
> > > > >
> > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > 821684824@qq.com>> wrote:
> > > > >
> > > > >> +1 100 is reasonable.
> > > > >>
> > > > >>
> > > > >>
> > > > >> ---Original---
> > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > hexiaoqiao@apache.org
> > > > >>
> > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > iwasakims@oss.nttdata.co.jp>>;
> > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> aajisaka@apache.org
> > > >>;"Hadoop
> > > > Common"<
> > > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > hdfs-dev@hadoop.apache.org>
> > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > mapreduce-dev@hadoop.apache.org
> > > > >>;
> > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> line
> > > > >> length 100
> > > > >>
> > > > >>
> > > > >> +1 for <= 100 chars long per line length.
> > > > >>
> > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > >>
> > > > >> > I'm +1 too.
> > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > introducing
> > > > >> > useless line breaks.
> > > > >> >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>
> > > > >> ;
> > > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > > >> side-by-side
> > > > >> > diff even on 13-inch MBP.
> > > > >> >
> > > > >> > Masatake Iwasaki
> > > > >> >
> > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > >> > > I'm +1 to allow <= 100 chars.
> > > > >> > >
> > > > >> > > FYI: There were some discussions long before:
> > > > >> > > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> >
> > > > >> > > Thanks,
> > > > >> > > Akira
> > > > >> > >
> > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > > >> > wrote:
> > > > >> > >>
> > > > >> > >> Hello!
> > > > >> > >>
> > > > >> > >> What do folks think about changing our line length
> > > > >> guidelines to allow
> > > > >> > for 100 character width?
> > > > >> > >>
> > > > >> > >> Currently, we tell folks to follow the sun style
> guide
> > > > with
> > > > >> some
> > > > >> > exception unrelated to line length. That guide says width of
> 80
> > > is
> > > > the
> > > > >> > standard and our current check style rules act as
> enforcement.
> > > > >> > >>
> > > > >> > >> Looking at the current trunk codebase our nightly
> > build
> > > > >> shows a total
> > > > >> > of ~15k line length violations; it’s about 18% of identified
> > > > >> checkstyle
> > > > >> > issues.
> > > > >> > >>
> > > > >> > >> The vast majority of those line length violations
> are
> > <=
> > > > 100
> > > > >> characters
> > > > >> > long. 100 characters happens to be the length for the Google
> > Java
> > > > >> Style
> > > > >> > Guide, another commonly adopted style guide for java
> projects,
> > > so I
> > > > >> suspect
> > > > >> > these longer lines leaking past the checkstyle precommit
> > warning
> > > > >> might be a
> > > > >> > reflection of committers working across multiple java
> > codebases.
> > > > >> > >>
> > > > >> > >> I don’t feel strongly about lines being longer, but
> I
> > > > would
> > > > >> like to
> > > > >> > move towards more consistent style enforcement as a project.
> > > > Updating
> > > > >> our
> > > > >> > project guidance to allow for 100 character lines would
> reduce
> > > the
> > > > >> > likelihood that folks bringing in new contributions need a
> > > > precommit
> > > > >> test
> > > > >> > cycle to get the formatting correct.
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about keeping the line
> > length
> > > > >> limit at 80
> > > > >> > characters?
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about contributions coming
> > in
> > > > that
> > > > >> clear up
> > > > >> > line length violations?
> > > > >> > >>
> > > > >> > >>
> > > > >> > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > >> To unsubscribe, e-mail:
> > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > >> For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >>
> > > > >> > >
> > > > >> > >
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > > For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >
> > > > >> >
> > > > >> >
> > > > ---------------------------------------------------------------------
> > > > >> > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> >
> > > > >> >
> > > >
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Chao Sun <su...@apache.org>.
+1. I think this will be very helpful.
On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> +1 (binding). It's long overdue IMHO.
>
> On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> <sh...@cloudera.com.invalid> wrote:
>
> > I really like this initiative, thank you!
> > +1 for line length increase to 100 characters.
> >
> > Regards,
> > Gergely Pollak
> >
> > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vivekratnavel@apache.org
> >
> > wrote:
> >
> > > +1 (non-binding) to increase line length to 100 characters. This will
> > > definitely help clear most of the checkstyle violations.
> > >
> > > Thank you Sean for starting this thread!
> > >
> > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sbusbey@apple.com.invalid
> >
> > > wrote:
> > >
> > > > Hi Bhavik!
> > > >
> > > > What concerns do you have about back porting patches to earlier
> release
> > > > branches?
> > > >
> > > > If we change our style guidelines then presumably we can do that for
> > all
> > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > style
> > > > check on the destination branch unless something changed in the
> > > backporting.
> > > >
> > > > If you are referring to patches for clearing up line length
> violations,
> > > my
> > > > usual preference is to aim for my changes to be on all active release
> > > > lines. So at least in the case of the patches coming from me or being
> > > > committed by me, there’d be effort to make sure all branches end up
> as
> > > easy
> > > > to backport to as they were prior to the clean up.
> > > >
> > > >
> > > >
> > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> bhavikpatel552@gmail.com>
> > > > wrote:
> > > > >
> > > > > I am just worried about the backporting of the Jira to child
> branch!!
> > > How
> > > > > we are planning to handle this?
> > > > >
> > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > 821684824@qq.com>> wrote:
> > > > >
> > > > >> +1 100 is reasonable.
> > > > >>
> > > > >>
> > > > >>
> > > > >> ---Original---
> > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > hexiaoqiao@apache.org
> > > > >>
> > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > iwasakims@oss.nttdata.co.jp>>;
> > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> aajisaka@apache.org
> > > >>;"Hadoop
> > > > Common"<
> > > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > hdfs-dev@hadoop.apache.org>
> > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > mapreduce-dev@hadoop.apache.org
> > > > >>;
> > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> line
> > > > >> length 100
> > > > >>
> > > > >>
> > > > >> +1 for <= 100 chars long per line length.
> > > > >>
> > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > >>
> > > > >> > I'm +1 too.
> > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > introducing
> > > > >> > useless line breaks.
> > > > >> >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>
> > > > >> ;
> > > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > > >> side-by-side
> > > > >> > diff even on 13-inch MBP.
> > > > >> >
> > > > >> > Masatake Iwasaki
> > > > >> >
> > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > >> > > I'm +1 to allow <= 100 chars.
> > > > >> > >
> > > > >> > > FYI: There were some discussions long before:
> > > > >> > > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> >
> > > > >> > > Thanks,
> > > > >> > > Akira
> > > > >> > >
> > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > > >> > wrote:
> > > > >> > >>
> > > > >> > >> Hello!
> > > > >> > >>
> > > > >> > >> What do folks think about changing our line length
> > > > >> guidelines to allow
> > > > >> > for 100 character width?
> > > > >> > >>
> > > > >> > >> Currently, we tell folks to follow the sun style
> guide
> > > > with
> > > > >> some
> > > > >> > exception unrelated to line length. That guide says width of
> 80
> > > is
> > > > the
> > > > >> > standard and our current check style rules act as
> enforcement.
> > > > >> > >>
> > > > >> > >> Looking at the current trunk codebase our nightly
> > build
> > > > >> shows a total
> > > > >> > of ~15k line length violations; it’s about 18% of identified
> > > > >> checkstyle
> > > > >> > issues.
> > > > >> > >>
> > > > >> > >> The vast majority of those line length violations
> are
> > <=
> > > > 100
> > > > >> characters
> > > > >> > long. 100 characters happens to be the length for the Google
> > Java
> > > > >> Style
> > > > >> > Guide, another commonly adopted style guide for java
> projects,
> > > so I
> > > > >> suspect
> > > > >> > these longer lines leaking past the checkstyle precommit
> > warning
> > > > >> might be a
> > > > >> > reflection of committers working across multiple java
> > codebases.
> > > > >> > >>
> > > > >> > >> I don’t feel strongly about lines being longer, but
> I
> > > > would
> > > > >> like to
> > > > >> > move towards more consistent style enforcement as a project.
> > > > Updating
> > > > >> our
> > > > >> > project guidance to allow for 100 character lines would
> reduce
> > > the
> > > > >> > likelihood that folks bringing in new contributions need a
> > > > precommit
> > > > >> test
> > > > >> > cycle to get the formatting correct.
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about keeping the line
> > length
> > > > >> limit at 80
> > > > >> > characters?
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about contributions coming
> > in
> > > > that
> > > > >> clear up
> > > > >> > line length violations?
> > > > >> > >>
> > > > >> > >>
> > > > >> > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > >> To unsubscribe, e-mail:
> > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > >> For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >>
> > > > >> > >
> > > > >> > >
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > > For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >
> > > > >> >
> > > > >> >
> > > > ---------------------------------------------------------------------
> > > > >> > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> >
> > > > >> >
> > > >
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Chao Sun <su...@apache.org>.
+1. I think this will be very helpful.
On Thu, May 20, 2021 at 3:10 PM Sangjin Lee <sj...@apache.org> wrote:
> +1 (binding). It's long overdue IMHO.
>
> On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
> <sh...@cloudera.com.invalid> wrote:
>
> > I really like this initiative, thank you!
> > +1 for line length increase to 100 characters.
> >
> > Regards,
> > Gergely Pollak
> >
> > On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vivekratnavel@apache.org
> >
> > wrote:
> >
> > > +1 (non-binding) to increase line length to 100 characters. This will
> > > definitely help clear most of the checkstyle violations.
> > >
> > > Thank you Sean for starting this thread!
> > >
> > > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sbusbey@apple.com.invalid
> >
> > > wrote:
> > >
> > > > Hi Bhavik!
> > > >
> > > > What concerns do you have about back porting patches to earlier
> release
> > > > branches?
> > > >
> > > > If we change our style guidelines then presumably we can do that for
> > all
> > > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> > style
> > > > check on the destination branch unless something changed in the
> > > backporting.
> > > >
> > > > If you are referring to patches for clearing up line length
> violations,
> > > my
> > > > usual preference is to aim for my changes to be on all active release
> > > > lines. So at least in the case of the patches coming from me or being
> > > > committed by me, there’d be effort to make sure all branches end up
> as
> > > easy
> > > > to backport to as they were prior to the clean up.
> > > >
> > > >
> > > >
> > > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <
> bhavikpatel552@gmail.com>
> > > > wrote:
> > > > >
> > > > > I am just worried about the backporting of the Jira to child
> branch!!
> > > How
> > > > > we are planning to handle this?
> > > > >
> > > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > > 821684824@qq.com>> wrote:
> > > > >
> > > > >> +1 100 is reasonable.
> > > > >>
> > > > >>
> > > > >>
> > > > >> ---Original---
> > > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > > hexiaoqiao@apache.org
> > > > >>
> > > > >> Date: Thu, May 20, 2021 13:35 PM
> > > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > > iwasakims@oss.nttdata.co.jp>>;
> > > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:
> aajisaka@apache.org
> > > >>;"Hadoop
> > > > Common"<
> > > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > > hdfs-dev@hadoop.apache.org>
> > > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > > mapreduce-dev@hadoop.apache.org
> > > > >>;
> > > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow
> line
> > > > >> length 100
> > > > >>
> > > > >>
> > > > >> +1 for <= 100 chars long per line length.
> > > > >>
> > > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > > >>
> > > > >> > I'm +1 too.
> > > > >> > I feel 80 characters limit tends to degrade readability by
> > > > introducing
> > > > >> > useless line breaks.
> > > > >> >
> > > > >> > >
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>
> > > > >> ;
> > > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > > >> side-by-side
> > > > >> > diff even on 13-inch MBP.
> > > > >> >
> > > > >> > Masatake Iwasaki
> > > > >> >
> > > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > >> > > I'm +1 to allow <= 100 chars.
> > > > >> > >
> > > > >> > > FYI: There were some discussions long before:
> > > > >> > > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> > -
> > > > >> >
> > > > >>
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > > >
> > > > >> >
> > > > >> <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > <
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > > >>;
> > > > >> >
> > > > >> > > Thanks,
> > > > >> > > Akira
> > > > >> > >
> > > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > > >> > wrote:
> > > > >> > >>
> > > > >> > >> Hello!
> > > > >> > >>
> > > > >> > >> What do folks think about changing our line length
> > > > >> guidelines to allow
> > > > >> > for 100 character width?
> > > > >> > >>
> > > > >> > >> Currently, we tell folks to follow the sun style
> guide
> > > > with
> > > > >> some
> > > > >> > exception unrelated to line length. That guide says width of
> 80
> > > is
> > > > the
> > > > >> > standard and our current check style rules act as
> enforcement.
> > > > >> > >>
> > > > >> > >> Looking at the current trunk codebase our nightly
> > build
> > > > >> shows a total
> > > > >> > of ~15k line length violations; it’s about 18% of identified
> > > > >> checkstyle
> > > > >> > issues.
> > > > >> > >>
> > > > >> > >> The vast majority of those line length violations
> are
> > <=
> > > > 100
> > > > >> characters
> > > > >> > long. 100 characters happens to be the length for the Google
> > Java
> > > > >> Style
> > > > >> > Guide, another commonly adopted style guide for java
> projects,
> > > so I
> > > > >> suspect
> > > > >> > these longer lines leaking past the checkstyle precommit
> > warning
> > > > >> might be a
> > > > >> > reflection of committers working across multiple java
> > codebases.
> > > > >> > >>
> > > > >> > >> I don’t feel strongly about lines being longer, but
> I
> > > > would
> > > > >> like to
> > > > >> > move towards more consistent style enforcement as a project.
> > > > Updating
> > > > >> our
> > > > >> > project guidance to allow for 100 character lines would
> reduce
> > > the
> > > > >> > likelihood that folks bringing in new contributions need a
> > > > precommit
> > > > >> test
> > > > >> > cycle to get the formatting correct.
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about keeping the line
> > length
> > > > >> limit at 80
> > > > >> > characters?
> > > > >> > >>
> > > > >> > >> Does anyone feel strongly about contributions coming
> > in
> > > > that
> > > > >> clear up
> > > > >> > line length violations?
> > > > >> > >>
> > > > >> > >>
> > > > >> > >>
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > >> To unsubscribe, e-mail:
> > > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > >> For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >>
> > > > >> > >
> > > > >> > >
> > > > >>
> > ---------------------------------------------------------------------
> > > > >> > > To unsubscribe, e-mail:
> > > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > > common-dev-unsubscribe@hadoop.apache.org>
> > > > >> > > For additional commands, e-mail:
> > > > >> common-dev-help@hadoop.apache.org <mailto:
> > > > common-dev-help@hadoop.apache.org>
> > > > >> > >
> > > > >> >
> > > > >> >
> > > > ---------------------------------------------------------------------
> > > > >> > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > <ma...@hadoop.apache.org>
> > > > >> >
> > > > >> >
> > > >
> > > >
> > > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sangjin Lee <sj...@apache.org>.
+1 (binding). It's long overdue IMHO.
On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
<sh...@cloudera.com.invalid> wrote:
> I really like this initiative, thank you!
> +1 for line length increase to 100 characters.
>
> Regards,
> Gergely Pollak
>
> On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vi...@apache.org>
> wrote:
>
> > +1 (non-binding) to increase line length to 100 characters. This will
> > definitely help clear most of the checkstyle violations.
> >
> > Thank you Sean for starting this thread!
> >
> > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi Bhavik!
> > >
> > > What concerns do you have about back porting patches to earlier release
> > > branches?
> > >
> > > If we change our style guidelines then presumably we can do that for
> all
> > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> style
> > > check on the destination branch unless something changed in the
> > backporting.
> > >
> > > If you are referring to patches for clearing up line length violations,
> > my
> > > usual preference is to aim for my changes to be on all active release
> > > lines. So at least in the case of the patches coming from me or being
> > > committed by me, there’d be effort to make sure all branches end up as
> > easy
> > > to backport to as they were prior to the clean up.
> > >
> > >
> > >
> > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> > > wrote:
> > > >
> > > > I am just worried about the backporting of the Jira to child branch!!
> > How
> > > > we are planning to handle this?
> > > >
> > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > 821684824@qq.com>> wrote:
> > > >
> > > >> +1 100 is reasonable.
> > > >>
> > > >>
> > > >>
> > > >> ---Original---
> > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > hexiaoqiao@apache.org
> > > >>
> > > >> Date: Thu, May 20, 2021 13:35 PM
> > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > iwasakims@oss.nttdata.co.jp>>;
> > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org
> > >>;"Hadoop
> > > Common"<
> > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > hdfs-dev@hadoop.apache.org>
> > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > mapreduce-dev@hadoop.apache.org
> > > >>;
> > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > >> length 100
> > > >>
> > > >>
> > > >> +1 for <= 100 chars long per line length.
> > > >>
> > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > >>
> > > >> > I'm +1 too.
> > > >> > I feel 80 characters limit tends to degrade readability by
> > > introducing
> > > >> > useless line breaks.
> > > >> >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>
> > > >> ;
> > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > >> side-by-side
> > > >> > diff even on 13-inch MBP.
> > > >> >
> > > >> > Masatake Iwasaki
> > > >> >
> > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > >> > > I'm +1 to allow <= 100 chars.
> > > >> > >
> > > >> > > FYI: There were some discussions long before:
> > > >> > > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> >
> > > >> > > Thanks,
> > > >> > > Akira
> > > >> > >
> > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > >> > wrote:
> > > >> > >>
> > > >> > >> Hello!
> > > >> > >>
> > > >> > >> What do folks think about changing our line length
> > > >> guidelines to allow
> > > >> > for 100 character width?
> > > >> > >>
> > > >> > >> Currently, we tell folks to follow the sun style guide
> > > with
> > > >> some
> > > >> > exception unrelated to line length. That guide says width of 80
> > is
> > > the
> > > >> > standard and our current check style rules act as enforcement.
> > > >> > >>
> > > >> > >> Looking at the current trunk codebase our nightly
> build
> > > >> shows a total
> > > >> > of ~15k line length violations; it’s about 18% of identified
> > > >> checkstyle
> > > >> > issues.
> > > >> > >>
> > > >> > >> The vast majority of those line length violations are
> <=
> > > 100
> > > >> characters
> > > >> > long. 100 characters happens to be the length for the Google
> Java
> > > >> Style
> > > >> > Guide, another commonly adopted style guide for java projects,
> > so I
> > > >> suspect
> > > >> > these longer lines leaking past the checkstyle precommit
> warning
> > > >> might be a
> > > >> > reflection of committers working across multiple java
> codebases.
> > > >> > >>
> > > >> > >> I don’t feel strongly about lines being longer, but I
> > > would
> > > >> like to
> > > >> > move towards more consistent style enforcement as a project.
> > > Updating
> > > >> our
> > > >> > project guidance to allow for 100 character lines would reduce
> > the
> > > >> > likelihood that folks bringing in new contributions need a
> > > precommit
> > > >> test
> > > >> > cycle to get the formatting correct.
> > > >> > >>
> > > >> > >> Does anyone feel strongly about keeping the line
> length
> > > >> limit at 80
> > > >> > characters?
> > > >> > >>
> > > >> > >> Does anyone feel strongly about contributions coming
> in
> > > that
> > > >> clear up
> > > >> > line length violations?
> > > >> > >>
> > > >> > >>
> > > >> > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> > >> To unsubscribe, e-mail:
> > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > >> For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >>
> > > >> > >
> > > >> > >
> > > >>
> ---------------------------------------------------------------------
> > > >> > > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > > For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >
> > > >> >
> > > >> >
> > > ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> > For additional commands, e-mail:
> > common-dev-help@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> >
> > > >> >
> > >
> > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sangjin Lee <sj...@apache.org>.
+1 (binding). It's long overdue IMHO.
On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
<sh...@cloudera.com.invalid> wrote:
> I really like this initiative, thank you!
> +1 for line length increase to 100 characters.
>
> Regards,
> Gergely Pollak
>
> On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vi...@apache.org>
> wrote:
>
> > +1 (non-binding) to increase line length to 100 characters. This will
> > definitely help clear most of the checkstyle violations.
> >
> > Thank you Sean for starting this thread!
> >
> > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi Bhavik!
> > >
> > > What concerns do you have about back porting patches to earlier release
> > > branches?
> > >
> > > If we change our style guidelines then presumably we can do that for
> all
> > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> style
> > > check on the destination branch unless something changed in the
> > backporting.
> > >
> > > If you are referring to patches for clearing up line length violations,
> > my
> > > usual preference is to aim for my changes to be on all active release
> > > lines. So at least in the case of the patches coming from me or being
> > > committed by me, there’d be effort to make sure all branches end up as
> > easy
> > > to backport to as they were prior to the clean up.
> > >
> > >
> > >
> > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> > > wrote:
> > > >
> > > > I am just worried about the backporting of the Jira to child branch!!
> > How
> > > > we are planning to handle this?
> > > >
> > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > 821684824@qq.com>> wrote:
> > > >
> > > >> +1 100 is reasonable.
> > > >>
> > > >>
> > > >>
> > > >> ---Original---
> > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > hexiaoqiao@apache.org
> > > >>
> > > >> Date: Thu, May 20, 2021 13:35 PM
> > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > iwasakims@oss.nttdata.co.jp>>;
> > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org
> > >>;"Hadoop
> > > Common"<
> > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > hdfs-dev@hadoop.apache.org>
> > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > mapreduce-dev@hadoop.apache.org
> > > >>;
> > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > >> length 100
> > > >>
> > > >>
> > > >> +1 for <= 100 chars long per line length.
> > > >>
> > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > >>
> > > >> > I'm +1 too.
> > > >> > I feel 80 characters limit tends to degrade readability by
> > > introducing
> > > >> > useless line breaks.
> > > >> >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>
> > > >> ;
> > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > >> side-by-side
> > > >> > diff even on 13-inch MBP.
> > > >> >
> > > >> > Masatake Iwasaki
> > > >> >
> > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > >> > > I'm +1 to allow <= 100 chars.
> > > >> > >
> > > >> > > FYI: There were some discussions long before:
> > > >> > > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> >
> > > >> > > Thanks,
> > > >> > > Akira
> > > >> > >
> > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > >> > wrote:
> > > >> > >>
> > > >> > >> Hello!
> > > >> > >>
> > > >> > >> What do folks think about changing our line length
> > > >> guidelines to allow
> > > >> > for 100 character width?
> > > >> > >>
> > > >> > >> Currently, we tell folks to follow the sun style guide
> > > with
> > > >> some
> > > >> > exception unrelated to line length. That guide says width of 80
> > is
> > > the
> > > >> > standard and our current check style rules act as enforcement.
> > > >> > >>
> > > >> > >> Looking at the current trunk codebase our nightly
> build
> > > >> shows a total
> > > >> > of ~15k line length violations; it’s about 18% of identified
> > > >> checkstyle
> > > >> > issues.
> > > >> > >>
> > > >> > >> The vast majority of those line length violations are
> <=
> > > 100
> > > >> characters
> > > >> > long. 100 characters happens to be the length for the Google
> Java
> > > >> Style
> > > >> > Guide, another commonly adopted style guide for java projects,
> > so I
> > > >> suspect
> > > >> > these longer lines leaking past the checkstyle precommit
> warning
> > > >> might be a
> > > >> > reflection of committers working across multiple java
> codebases.
> > > >> > >>
> > > >> > >> I don’t feel strongly about lines being longer, but I
> > > would
> > > >> like to
> > > >> > move towards more consistent style enforcement as a project.
> > > Updating
> > > >> our
> > > >> > project guidance to allow for 100 character lines would reduce
> > the
> > > >> > likelihood that folks bringing in new contributions need a
> > > precommit
> > > >> test
> > > >> > cycle to get the formatting correct.
> > > >> > >>
> > > >> > >> Does anyone feel strongly about keeping the line
> length
> > > >> limit at 80
> > > >> > characters?
> > > >> > >>
> > > >> > >> Does anyone feel strongly about contributions coming
> in
> > > that
> > > >> clear up
> > > >> > line length violations?
> > > >> > >>
> > > >> > >>
> > > >> > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> > >> To unsubscribe, e-mail:
> > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > >> For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >>
> > > >> > >
> > > >> > >
> > > >>
> ---------------------------------------------------------------------
> > > >> > > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > > For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >
> > > >> >
> > > >> >
> > > ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> > For additional commands, e-mail:
> > common-dev-help@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> >
> > > >> >
> > >
> > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sangjin Lee <sj...@apache.org>.
+1 (binding). It's long overdue IMHO.
On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
<sh...@cloudera.com.invalid> wrote:
> I really like this initiative, thank you!
> +1 for line length increase to 100 characters.
>
> Regards,
> Gergely Pollak
>
> On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vi...@apache.org>
> wrote:
>
> > +1 (non-binding) to increase line length to 100 characters. This will
> > definitely help clear most of the checkstyle violations.
> >
> > Thank you Sean for starting this thread!
> >
> > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi Bhavik!
> > >
> > > What concerns do you have about back porting patches to earlier release
> > > branches?
> > >
> > > If we change our style guidelines then presumably we can do that for
> all
> > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> style
> > > check on the destination branch unless something changed in the
> > backporting.
> > >
> > > If you are referring to patches for clearing up line length violations,
> > my
> > > usual preference is to aim for my changes to be on all active release
> > > lines. So at least in the case of the patches coming from me or being
> > > committed by me, there’d be effort to make sure all branches end up as
> > easy
> > > to backport to as they were prior to the clean up.
> > >
> > >
> > >
> > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> > > wrote:
> > > >
> > > > I am just worried about the backporting of the Jira to child branch!!
> > How
> > > > we are planning to handle this?
> > > >
> > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > 821684824@qq.com>> wrote:
> > > >
> > > >> +1 100 is reasonable.
> > > >>
> > > >>
> > > >>
> > > >> ---Original---
> > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > hexiaoqiao@apache.org
> > > >>
> > > >> Date: Thu, May 20, 2021 13:35 PM
> > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > iwasakims@oss.nttdata.co.jp>>;
> > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org
> > >>;"Hadoop
> > > Common"<
> > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > hdfs-dev@hadoop.apache.org>
> > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > mapreduce-dev@hadoop.apache.org
> > > >>;
> > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > >> length 100
> > > >>
> > > >>
> > > >> +1 for <= 100 chars long per line length.
> > > >>
> > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > >>
> > > >> > I'm +1 too.
> > > >> > I feel 80 characters limit tends to degrade readability by
> > > introducing
> > > >> > useless line breaks.
> > > >> >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>
> > > >> ;
> > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > >> side-by-side
> > > >> > diff even on 13-inch MBP.
> > > >> >
> > > >> > Masatake Iwasaki
> > > >> >
> > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > >> > > I'm +1 to allow <= 100 chars.
> > > >> > >
> > > >> > > FYI: There were some discussions long before:
> > > >> > > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> >
> > > >> > > Thanks,
> > > >> > > Akira
> > > >> > >
> > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > >> > wrote:
> > > >> > >>
> > > >> > >> Hello!
> > > >> > >>
> > > >> > >> What do folks think about changing our line length
> > > >> guidelines to allow
> > > >> > for 100 character width?
> > > >> > >>
> > > >> > >> Currently, we tell folks to follow the sun style guide
> > > with
> > > >> some
> > > >> > exception unrelated to line length. That guide says width of 80
> > is
> > > the
> > > >> > standard and our current check style rules act as enforcement.
> > > >> > >>
> > > >> > >> Looking at the current trunk codebase our nightly
> build
> > > >> shows a total
> > > >> > of ~15k line length violations; it’s about 18% of identified
> > > >> checkstyle
> > > >> > issues.
> > > >> > >>
> > > >> > >> The vast majority of those line length violations are
> <=
> > > 100
> > > >> characters
> > > >> > long. 100 characters happens to be the length for the Google
> Java
> > > >> Style
> > > >> > Guide, another commonly adopted style guide for java projects,
> > so I
> > > >> suspect
> > > >> > these longer lines leaking past the checkstyle precommit
> warning
> > > >> might be a
> > > >> > reflection of committers working across multiple java
> codebases.
> > > >> > >>
> > > >> > >> I don’t feel strongly about lines being longer, but I
> > > would
> > > >> like to
> > > >> > move towards more consistent style enforcement as a project.
> > > Updating
> > > >> our
> > > >> > project guidance to allow for 100 character lines would reduce
> > the
> > > >> > likelihood that folks bringing in new contributions need a
> > > precommit
> > > >> test
> > > >> > cycle to get the formatting correct.
> > > >> > >>
> > > >> > >> Does anyone feel strongly about keeping the line
> length
> > > >> limit at 80
> > > >> > characters?
> > > >> > >>
> > > >> > >> Does anyone feel strongly about contributions coming
> in
> > > that
> > > >> clear up
> > > >> > line length violations?
> > > >> > >>
> > > >> > >>
> > > >> > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> > >> To unsubscribe, e-mail:
> > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > >> For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >>
> > > >> > >
> > > >> > >
> > > >>
> ---------------------------------------------------------------------
> > > >> > > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > > For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >
> > > >> >
> > > >> >
> > > ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> > For additional commands, e-mail:
> > common-dev-help@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> >
> > > >> >
> > >
> > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sangjin Lee <sj...@apache.org>.
+1 (binding). It's long overdue IMHO.
On Thu, May 20, 2021 at 2:11 PM Gergely Pollak
<sh...@cloudera.com.invalid> wrote:
> I really like this initiative, thank you!
> +1 for line length increase to 100 characters.
>
> Regards,
> Gergely Pollak
>
> On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vi...@apache.org>
> wrote:
>
> > +1 (non-binding) to increase line length to 100 characters. This will
> > definitely help clear most of the checkstyle violations.
> >
> > Thank you Sean for starting this thread!
> >
> > On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
> > wrote:
> >
> > > Hi Bhavik!
> > >
> > > What concerns do you have about back porting patches to earlier release
> > > branches?
> > >
> > > If we change our style guidelines then presumably we can do that for
> all
> > > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a
> style
> > > check on the destination branch unless something changed in the
> > backporting.
> > >
> > > If you are referring to patches for clearing up line length violations,
> > my
> > > usual preference is to aim for my changes to be on all active release
> > > lines. So at least in the case of the patches coming from me or being
> > > committed by me, there’d be effort to make sure all branches end up as
> > easy
> > > to backport to as they were prior to the clean up.
> > >
> > >
> > >
> > > > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> > > wrote:
> > > >
> > > > I am just worried about the backporting of the Jira to child branch!!
> > How
> > > > we are planning to handle this?
> > > >
> > > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > > 821684824@qq.com>> wrote:
> > > >
> > > >> +1 100 is reasonable.
> > > >>
> > > >>
> > > >>
> > > >> ---Original---
> > > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> > hexiaoqiao@apache.org
> > > >>
> > > >> Date: Thu, May 20, 2021 13:35 PM
> > > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > > iwasakims@oss.nttdata.co.jp>>;
> > > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org
> > >>;"Hadoop
> > > Common"<
> > > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > > hdfs-dev@hadoop.apache.org>
> > > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > > >> mapreduce-dev@hadoop.apache.org <mailto:
> > mapreduce-dev@hadoop.apache.org
> > > >>;
> > > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > >> length 100
> > > >>
> > > >>
> > > >> +1 for <= 100 chars long per line length.
> > > >>
> > > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > >> iwasakims@oss.nttdata.co.jp> wrote:
> > > >>
> > > >> > I'm +1 too.
> > > >> > I feel 80 characters limit tends to degrade readability by
> > > introducing
> > > >> > useless line breaks.
> > > >> >
> > > >> > >
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>
> > > >> ;
> > > >> > I have no inconvenience on 100 characters for using Emacs and
> > > >> side-by-side
> > > >> > diff even on 13-inch MBP.
> > > >> >
> > > >> > Masatake Iwasaki
> > > >> >
> > > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > >> > > I'm +1 to allow <= 100 chars.
> > > >> > >
> > > >> > > FYI: There were some discussions long before:
> > > >> > > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> > -
> > > >> >
> > > >>
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > >> >
> > > >> <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > <
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > > >>;
> > > >> >
> > > >> > > Thanks,
> > > >> > > Akira
> > > >> > >
> > > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > > >> > wrote:
> > > >> > >>
> > > >> > >> Hello!
> > > >> > >>
> > > >> > >> What do folks think about changing our line length
> > > >> guidelines to allow
> > > >> > for 100 character width?
> > > >> > >>
> > > >> > >> Currently, we tell folks to follow the sun style guide
> > > with
> > > >> some
> > > >> > exception unrelated to line length. That guide says width of 80
> > is
> > > the
> > > >> > standard and our current check style rules act as enforcement.
> > > >> > >>
> > > >> > >> Looking at the current trunk codebase our nightly
> build
> > > >> shows a total
> > > >> > of ~15k line length violations; it’s about 18% of identified
> > > >> checkstyle
> > > >> > issues.
> > > >> > >>
> > > >> > >> The vast majority of those line length violations are
> <=
> > > 100
> > > >> characters
> > > >> > long. 100 characters happens to be the length for the Google
> Java
> > > >> Style
> > > >> > Guide, another commonly adopted style guide for java projects,
> > so I
> > > >> suspect
> > > >> > these longer lines leaking past the checkstyle precommit
> warning
> > > >> might be a
> > > >> > reflection of committers working across multiple java
> codebases.
> > > >> > >>
> > > >> > >> I don’t feel strongly about lines being longer, but I
> > > would
> > > >> like to
> > > >> > move towards more consistent style enforcement as a project.
> > > Updating
> > > >> our
> > > >> > project guidance to allow for 100 character lines would reduce
> > the
> > > >> > likelihood that folks bringing in new contributions need a
> > > precommit
> > > >> test
> > > >> > cycle to get the formatting correct.
> > > >> > >>
> > > >> > >> Does anyone feel strongly about keeping the line
> length
> > > >> limit at 80
> > > >> > characters?
> > > >> > >>
> > > >> > >> Does anyone feel strongly about contributions coming
> in
> > > that
> > > >> clear up
> > > >> > line length violations?
> > > >> > >>
> > > >> > >>
> > > >> > >>
> > > >>
> ---------------------------------------------------------------------
> > > >> > >> To unsubscribe, e-mail:
> > > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > >> For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >>
> > > >> > >
> > > >> > >
> > > >>
> ---------------------------------------------------------------------
> > > >> > > To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > > common-dev-unsubscribe@hadoop.apache.org>
> > > >> > > For additional commands, e-mail:
> > > >> common-dev-help@hadoop.apache.org <mailto:
> > > common-dev-help@hadoop.apache.org>
> > > >> > >
> > > >> >
> > > >> >
> > > ---------------------------------------------------------------------
> > > >> > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> > For additional commands, e-mail:
> > common-dev-help@hadoop.apache.org
> > > <ma...@hadoop.apache.org>
> > > >> >
> > > >> >
> > >
> > >
> > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Gergely Pollak <sh...@cloudera.com.INVALID>.
I really like this initiative, thank you!
+1 for line length increase to 100 characters.
Regards,
Gergely Pollak
On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vi...@apache.org>
wrote:
> +1 (non-binding) to increase line length to 100 characters. This will
> definitely help clear most of the checkstyle violations.
>
> Thank you Sean for starting this thread!
>
> On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi Bhavik!
> >
> > What concerns do you have about back porting patches to earlier release
> > branches?
> >
> > If we change our style guidelines then presumably we can do that for all
> > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> > check on the destination branch unless something changed in the
> backporting.
> >
> > If you are referring to patches for clearing up line length violations,
> my
> > usual preference is to aim for my changes to be on all active release
> > lines. So at least in the case of the patches coming from me or being
> > committed by me, there’d be effort to make sure all branches end up as
> easy
> > to backport to as they were prior to the clean up.
> >
> >
> >
> > > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> > wrote:
> > >
> > > I am just worried about the backporting of the Jira to child branch!!
> How
> > > we are planning to handle this?
> > >
> > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > 821684824@qq.com>> wrote:
> > >
> > >> +1 100 is reasonable.
> > >>
> > >>
> > >>
> > >> ---Original---
> > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> hexiaoqiao@apache.org
> > >>
> > >> Date: Thu, May 20, 2021 13:35 PM
> > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > iwasakims@oss.nttdata.co.jp>>;
> > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org
> >>;"Hadoop
> > Common"<
> > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > hdfs-dev@hadoop.apache.org>
> > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > >> mapreduce-dev@hadoop.apache.org <mailto:
> mapreduce-dev@hadoop.apache.org
> > >>;
> > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > >> length 100
> > >>
> > >>
> > >> +1 for <= 100 chars long per line length.
> > >>
> > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > >> iwasakims@oss.nttdata.co.jp> wrote:
> > >>
> > >> > I'm +1 too.
> > >> > I feel 80 characters limit tends to degrade readability by
> > introducing
> > >> > useless line breaks.
> > >> >
> > >> > >
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > >> >
> > >> <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >>
> > >> ;
> > >> > I have no inconvenience on 100 characters for using Emacs and
> > >> side-by-side
> > >> > diff even on 13-inch MBP.
> > >> >
> > >> > Masatake Iwasaki
> > >> >
> > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > >> > > I'm +1 to allow <= 100 chars.
> > >> > >
> > >> > > FYI: There were some discussions long before:
> > >> > > -
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > >> >
> > >> <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >>;
> > >> > -
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > >> >
> > >> <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >>;
> > >> >
> > >> > > Thanks,
> > >> > > Akira
> > >> > >
> > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > >> > wrote:
> > >> > >>
> > >> > >> Hello!
> > >> > >>
> > >> > >> What do folks think about changing our line length
> > >> guidelines to allow
> > >> > for 100 character width?
> > >> > >>
> > >> > >> Currently, we tell folks to follow the sun style guide
> > with
> > >> some
> > >> > exception unrelated to line length. That guide says width of 80
> is
> > the
> > >> > standard and our current check style rules act as enforcement.
> > >> > >>
> > >> > >> Looking at the current trunk codebase our nightly build
> > >> shows a total
> > >> > of ~15k line length violations; it’s about 18% of identified
> > >> checkstyle
> > >> > issues.
> > >> > >>
> > >> > >> The vast majority of those line length violations are <=
> > 100
> > >> characters
> > >> > long. 100 characters happens to be the length for the Google Java
> > >> Style
> > >> > Guide, another commonly adopted style guide for java projects,
> so I
> > >> suspect
> > >> > these longer lines leaking past the checkstyle precommit warning
> > >> might be a
> > >> > reflection of committers working across multiple java codebases.
> > >> > >>
> > >> > >> I don’t feel strongly about lines being longer, but I
> > would
> > >> like to
> > >> > move towards more consistent style enforcement as a project.
> > Updating
> > >> our
> > >> > project guidance to allow for 100 character lines would reduce
> the
> > >> > likelihood that folks bringing in new contributions need a
> > precommit
> > >> test
> > >> > cycle to get the formatting correct.
> > >> > >>
> > >> > >> Does anyone feel strongly about keeping the line length
> > >> limit at 80
> > >> > characters?
> > >> > >>
> > >> > >> Does anyone feel strongly about contributions coming in
> > that
> > >> clear up
> > >> > line length violations?
> > >> > >>
> > >> > >>
> > >> > >>
> > >> ---------------------------------------------------------------------
> > >> > >> To unsubscribe, e-mail:
> > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > common-dev-unsubscribe@hadoop.apache.org>
> > >> > >> For additional commands, e-mail:
> > >> common-dev-help@hadoop.apache.org <mailto:
> > common-dev-help@hadoop.apache.org>
> > >> > >>
> > >> > >
> > >> > >
> > >> ---------------------------------------------------------------------
> > >> > > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > common-dev-unsubscribe@hadoop.apache.org>
> > >> > > For additional commands, e-mail:
> > >> common-dev-help@hadoop.apache.org <mailto:
> > common-dev-help@hadoop.apache.org>
> > >> > >
> > >> >
> > >> >
> > ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > <ma...@hadoop.apache.org>
> > >> > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > <ma...@hadoop.apache.org>
> > >> >
> > >> >
> >
> >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Gergely Pollak <sh...@cloudera.com.INVALID>.
I really like this initiative, thank you!
+1 for line length increase to 100 characters.
Regards,
Gergely Pollak
On Thu, May 20, 2021 at 8:30 PM Vivek Ratnavel <vi...@apache.org>
wrote:
> +1 (non-binding) to increase line length to 100 characters. This will
> definitely help clear most of the checkstyle violations.
>
> Thank you Sean for starting this thread!
>
> On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
>
> > Hi Bhavik!
> >
> > What concerns do you have about back porting patches to earlier release
> > branches?
> >
> > If we change our style guidelines then presumably we can do that for all
> > branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> > check on the destination branch unless something changed in the
> backporting.
> >
> > If you are referring to patches for clearing up line length violations,
> my
> > usual preference is to aim for my changes to be on all active release
> > lines. So at least in the case of the patches coming from me or being
> > committed by me, there’d be effort to make sure all branches end up as
> easy
> > to backport to as they were prior to the clean up.
> >
> >
> >
> > > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> > wrote:
> > >
> > > I am just worried about the backporting of the Jira to child branch!!
> How
> > > we are planning to handle this?
> > >
> > > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> > 821684824@qq.com>> wrote:
> > >
> > >> +1 100 is reasonable.
> > >>
> > >>
> > >>
> > >> ---Original---
> > >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:
> hexiaoqiao@apache.org
> > >>
> > >> Date: Thu, May 20, 2021 13:35 PM
> > >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> > iwasakims@oss.nttdata.co.jp>>;
> > >> Cc: "Akira Ajisaka"<aajisaka@apache.org <mailto:aajisaka@apache.org
> >>;"Hadoop
> > Common"<
> > >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> > >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> > hdfs-dev@hadoop.apache.org>
> > >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> > yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> > >> mapreduce-dev@hadoop.apache.org <mailto:
> mapreduce-dev@hadoop.apache.org
> > >>;
> > >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > >> length 100
> > >>
> > >>
> > >> +1 for <= 100 chars long per line length.
> > >>
> > >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > >> iwasakims@oss.nttdata.co.jp> wrote:
> > >>
> > >> > I'm +1 too.
> > >> > I feel 80 characters limit tends to degrade readability by
> > introducing
> > >> > useless line breaks.
> > >> >
> > >> > >
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > >> >
> > >> <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >>
> > >> ;
> > >> > I have no inconvenience on 100 characters for using Emacs and
> > >> side-by-side
> > >> > diff even on 13-inch MBP.
> > >> >
> > >> > Masatake Iwasaki
> > >> >
> > >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > >> > > I'm +1 to allow <= 100 chars.
> > >> > >
> > >> > > FYI: There were some discussions long before:
> > >> > > -
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > >> >
> > >> <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >>;
> > >> > -
> > >> >
> > >>
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > >> >
> > >> <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >>;
> > >> >
> > >> > > Thanks,
> > >> > > Akira
> > >> > >
> > >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> > >> > wrote:
> > >> > >>
> > >> > >> Hello!
> > >> > >>
> > >> > >> What do folks think about changing our line length
> > >> guidelines to allow
> > >> > for 100 character width?
> > >> > >>
> > >> > >> Currently, we tell folks to follow the sun style guide
> > with
> > >> some
> > >> > exception unrelated to line length. That guide says width of 80
> is
> > the
> > >> > standard and our current check style rules act as enforcement.
> > >> > >>
> > >> > >> Looking at the current trunk codebase our nightly build
> > >> shows a total
> > >> > of ~15k line length violations; it’s about 18% of identified
> > >> checkstyle
> > >> > issues.
> > >> > >>
> > >> > >> The vast majority of those line length violations are <=
> > 100
> > >> characters
> > >> > long. 100 characters happens to be the length for the Google Java
> > >> Style
> > >> > Guide, another commonly adopted style guide for java projects,
> so I
> > >> suspect
> > >> > these longer lines leaking past the checkstyle precommit warning
> > >> might be a
> > >> > reflection of committers working across multiple java codebases.
> > >> > >>
> > >> > >> I don’t feel strongly about lines being longer, but I
> > would
> > >> like to
> > >> > move towards more consistent style enforcement as a project.
> > Updating
> > >> our
> > >> > project guidance to allow for 100 character lines would reduce
> the
> > >> > likelihood that folks bringing in new contributions need a
> > precommit
> > >> test
> > >> > cycle to get the formatting correct.
> > >> > >>
> > >> > >> Does anyone feel strongly about keeping the line length
> > >> limit at 80
> > >> > characters?
> > >> > >>
> > >> > >> Does anyone feel strongly about contributions coming in
> > that
> > >> clear up
> > >> > line length violations?
> > >> > >>
> > >> > >>
> > >> > >>
> > >> ---------------------------------------------------------------------
> > >> > >> To unsubscribe, e-mail:
> > >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> > common-dev-unsubscribe@hadoop.apache.org>
> > >> > >> For additional commands, e-mail:
> > >> common-dev-help@hadoop.apache.org <mailto:
> > common-dev-help@hadoop.apache.org>
> > >> > >>
> > >> > >
> > >> > >
> > >> ---------------------------------------------------------------------
> > >> > > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org <mailto:
> > common-dev-unsubscribe@hadoop.apache.org>
> > >> > > For additional commands, e-mail:
> > >> common-dev-help@hadoop.apache.org <mailto:
> > common-dev-help@hadoop.apache.org>
> > >> > >
> > >> >
> > >> >
> > ---------------------------------------------------------------------
> > >> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > <ma...@hadoop.apache.org>
> > >> > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > <ma...@hadoop.apache.org>
> > >> >
> > >> >
> >
> >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Vivek Ratnavel <vi...@apache.org>.
+1 (non-binding) to increase line length to 100 characters. This will
definitely help clear most of the checkstyle violations.
Thank you Sean for starting this thread!
On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi Bhavik!
>
> What concerns do you have about back porting patches to earlier release
> branches?
>
> If we change our style guidelines then presumably we can do that for all
> branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> check on the destination branch unless something changed in the backporting.
>
> If you are referring to patches for clearing up line length violations, my
> usual preference is to aim for my changes to be on all active release
> lines. So at least in the case of the patches coming from me or being
> committed by me, there’d be effort to make sure all branches end up as easy
> to backport to as they were prior to the clean up.
>
>
>
> > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> wrote:
> >
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> 821684824@qq.com>> wrote:
> >
> >> +1 100 is reasonable.
> >>
> >>
> >>
> >> ---Original---
> >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:hexiaoqiao@apache.org
> >>
> >> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> iwasakims@oss.nttdata.co.jp>>;
> >> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop
> Common"<
> >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> hdfs-dev@hadoop.apache.org>
> >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> >> mapreduce-dev@hadoop.apache.org <mailto:mapreduce-dev@hadoop.apache.org
> >>;
> >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> >> length 100
> >>
> >>
> >> +1 for <= 100 chars long per line length.
> >>
> >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> >> iwasakims@oss.nttdata.co.jp> wrote:
> >>
> >> > I'm +1 too.
> >> > I feel 80 characters limit tends to degrade readability by
> introducing
> >> > useless line breaks.
> >> >
> >> > >
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>
> >> ;
> >> > I have no inconvenience on 100 characters for using Emacs and
> >> side-by-side
> >> > diff even on 13-inch MBP.
> >> >
> >> > Masatake Iwasaki
> >> >
> >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> >> > > I'm +1 to allow <= 100 chars.
> >> > >
> >> > > FYI: There were some discussions long before:
> >> > > -
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> > -
> >> >
> >>
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> >
> >> > > Thanks,
> >> > > Akira
> >> > >
> >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> >> > wrote:
> >> > >>
> >> > >> Hello!
> >> > >>
> >> > >> What do folks think about changing our line length
> >> guidelines to allow
> >> > for 100 character width?
> >> > >>
> >> > >> Currently, we tell folks to follow the sun style guide
> with
> >> some
> >> > exception unrelated to line length. That guide says width of 80 is
> the
> >> > standard and our current check style rules act as enforcement.
> >> > >>
> >> > >> Looking at the current trunk codebase our nightly build
> >> shows a total
> >> > of ~15k line length violations; it’s about 18% of identified
> >> checkstyle
> >> > issues.
> >> > >>
> >> > >> The vast majority of those line length violations are <=
> 100
> >> characters
> >> > long. 100 characters happens to be the length for the Google Java
> >> Style
> >> > Guide, another commonly adopted style guide for java projects, so I
> >> suspect
> >> > these longer lines leaking past the checkstyle precommit warning
> >> might be a
> >> > reflection of committers working across multiple java codebases.
> >> > >>
> >> > >> I don’t feel strongly about lines being longer, but I
> would
> >> like to
> >> > move towards more consistent style enforcement as a project.
> Updating
> >> our
> >> > project guidance to allow for 100 character lines would reduce the
> >> > likelihood that folks bringing in new contributions need a
> precommit
> >> test
> >> > cycle to get the formatting correct.
> >> > >>
> >> > >> Does anyone feel strongly about keeping the line length
> >> limit at 80
> >> > characters?
> >> > >>
> >> > >> Does anyone feel strongly about contributions coming in
> that
> >> clear up
> >> > line length violations?
> >> > >>
> >> > >>
> >> > >>
> >> ---------------------------------------------------------------------
> >> > >> To unsubscribe, e-mail:
> >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > >> For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >>
> >> > >
> >> > >
> >> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > > For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >
> >> >
> >> >
> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> >
> >> >
>
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Vivek Ratnavel <vi...@apache.org>.
+1 (non-binding) to increase line length to 100 characters. This will
definitely help clear most of the checkstyle violations.
Thank you Sean for starting this thread!
On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi Bhavik!
>
> What concerns do you have about back porting patches to earlier release
> branches?
>
> If we change our style guidelines then presumably we can do that for all
> branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> check on the destination branch unless something changed in the backporting.
>
> If you are referring to patches for clearing up line length violations, my
> usual preference is to aim for my changes to be on all active release
> lines. So at least in the case of the patches coming from me or being
> committed by me, there’d be effort to make sure all branches end up as easy
> to backport to as they were prior to the clean up.
>
>
>
> > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> wrote:
> >
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> 821684824@qq.com>> wrote:
> >
> >> +1 100 is reasonable.
> >>
> >>
> >>
> >> ---Original---
> >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:hexiaoqiao@apache.org
> >>
> >> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> iwasakims@oss.nttdata.co.jp>>;
> >> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop
> Common"<
> >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> hdfs-dev@hadoop.apache.org>
> >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> >> mapreduce-dev@hadoop.apache.org <mailto:mapreduce-dev@hadoop.apache.org
> >>;
> >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> >> length 100
> >>
> >>
> >> +1 for <= 100 chars long per line length.
> >>
> >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> >> iwasakims@oss.nttdata.co.jp> wrote:
> >>
> >> > I'm +1 too.
> >> > I feel 80 characters limit tends to degrade readability by
> introducing
> >> > useless line breaks.
> >> >
> >> > >
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>
> >> ;
> >> > I have no inconvenience on 100 characters for using Emacs and
> >> side-by-side
> >> > diff even on 13-inch MBP.
> >> >
> >> > Masatake Iwasaki
> >> >
> >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> >> > > I'm +1 to allow <= 100 chars.
> >> > >
> >> > > FYI: There were some discussions long before:
> >> > > -
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> > -
> >> >
> >>
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> >
> >> > > Thanks,
> >> > > Akira
> >> > >
> >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> >> > wrote:
> >> > >>
> >> > >> Hello!
> >> > >>
> >> > >> What do folks think about changing our line length
> >> guidelines to allow
> >> > for 100 character width?
> >> > >>
> >> > >> Currently, we tell folks to follow the sun style guide
> with
> >> some
> >> > exception unrelated to line length. That guide says width of 80 is
> the
> >> > standard and our current check style rules act as enforcement.
> >> > >>
> >> > >> Looking at the current trunk codebase our nightly build
> >> shows a total
> >> > of ~15k line length violations; it’s about 18% of identified
> >> checkstyle
> >> > issues.
> >> > >>
> >> > >> The vast majority of those line length violations are <=
> 100
> >> characters
> >> > long. 100 characters happens to be the length for the Google Java
> >> Style
> >> > Guide, another commonly adopted style guide for java projects, so I
> >> suspect
> >> > these longer lines leaking past the checkstyle precommit warning
> >> might be a
> >> > reflection of committers working across multiple java codebases.
> >> > >>
> >> > >> I don’t feel strongly about lines being longer, but I
> would
> >> like to
> >> > move towards more consistent style enforcement as a project.
> Updating
> >> our
> >> > project guidance to allow for 100 character lines would reduce the
> >> > likelihood that folks bringing in new contributions need a
> precommit
> >> test
> >> > cycle to get the formatting correct.
> >> > >>
> >> > >> Does anyone feel strongly about keeping the line length
> >> limit at 80
> >> > characters?
> >> > >>
> >> > >> Does anyone feel strongly about contributions coming in
> that
> >> clear up
> >> > line length violations?
> >> > >>
> >> > >>
> >> > >>
> >> ---------------------------------------------------------------------
> >> > >> To unsubscribe, e-mail:
> >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > >> For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >>
> >> > >
> >> > >
> >> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > > For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >
> >> >
> >> >
> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> >
> >> >
>
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Vivek Ratnavel <vi...@apache.org>.
+1 (non-binding) to increase line length to 100 characters. This will
definitely help clear most of the checkstyle violations.
Thank you Sean for starting this thread!
On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi Bhavik!
>
> What concerns do you have about back porting patches to earlier release
> branches?
>
> If we change our style guidelines then presumably we can do that for all
> branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> check on the destination branch unless something changed in the backporting.
>
> If you are referring to patches for clearing up line length violations, my
> usual preference is to aim for my changes to be on all active release
> lines. So at least in the case of the patches coming from me or being
> committed by me, there’d be effort to make sure all branches end up as easy
> to backport to as they were prior to the clean up.
>
>
>
> > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> wrote:
> >
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> 821684824@qq.com>> wrote:
> >
> >> +1 100 is reasonable.
> >>
> >>
> >>
> >> ---Original---
> >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:hexiaoqiao@apache.org
> >>
> >> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> iwasakims@oss.nttdata.co.jp>>;
> >> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop
> Common"<
> >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> hdfs-dev@hadoop.apache.org>
> >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> >> mapreduce-dev@hadoop.apache.org <mailto:mapreduce-dev@hadoop.apache.org
> >>;
> >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> >> length 100
> >>
> >>
> >> +1 for <= 100 chars long per line length.
> >>
> >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> >> iwasakims@oss.nttdata.co.jp> wrote:
> >>
> >> > I'm +1 too.
> >> > I feel 80 characters limit tends to degrade readability by
> introducing
> >> > useless line breaks.
> >> >
> >> > >
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>
> >> ;
> >> > I have no inconvenience on 100 characters for using Emacs and
> >> side-by-side
> >> > diff even on 13-inch MBP.
> >> >
> >> > Masatake Iwasaki
> >> >
> >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> >> > > I'm +1 to allow <= 100 chars.
> >> > >
> >> > > FYI: There were some discussions long before:
> >> > > -
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> > -
> >> >
> >>
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> >
> >> > > Thanks,
> >> > > Akira
> >> > >
> >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> >> > wrote:
> >> > >>
> >> > >> Hello!
> >> > >>
> >> > >> What do folks think about changing our line length
> >> guidelines to allow
> >> > for 100 character width?
> >> > >>
> >> > >> Currently, we tell folks to follow the sun style guide
> with
> >> some
> >> > exception unrelated to line length. That guide says width of 80 is
> the
> >> > standard and our current check style rules act as enforcement.
> >> > >>
> >> > >> Looking at the current trunk codebase our nightly build
> >> shows a total
> >> > of ~15k line length violations; it’s about 18% of identified
> >> checkstyle
> >> > issues.
> >> > >>
> >> > >> The vast majority of those line length violations are <=
> 100
> >> characters
> >> > long. 100 characters happens to be the length for the Google Java
> >> Style
> >> > Guide, another commonly adopted style guide for java projects, so I
> >> suspect
> >> > these longer lines leaking past the checkstyle precommit warning
> >> might be a
> >> > reflection of committers working across multiple java codebases.
> >> > >>
> >> > >> I don’t feel strongly about lines being longer, but I
> would
> >> like to
> >> > move towards more consistent style enforcement as a project.
> Updating
> >> our
> >> > project guidance to allow for 100 character lines would reduce the
> >> > likelihood that folks bringing in new contributions need a
> precommit
> >> test
> >> > cycle to get the formatting correct.
> >> > >>
> >> > >> Does anyone feel strongly about keeping the line length
> >> limit at 80
> >> > characters?
> >> > >>
> >> > >> Does anyone feel strongly about contributions coming in
> that
> >> clear up
> >> > line length violations?
> >> > >>
> >> > >>
> >> > >>
> >> ---------------------------------------------------------------------
> >> > >> To unsubscribe, e-mail:
> >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > >> For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >>
> >> > >
> >> > >
> >> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > > For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >
> >> >
> >> >
> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> >
> >> >
>
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Vivek Ratnavel <vi...@apache.org>.
+1 (non-binding) to increase line length to 100 characters. This will
definitely help clear most of the checkstyle violations.
Thank you Sean for starting this thread!
On Thu, May 20, 2021 at 7:17 AM Sean Busbey <sb...@apple.com.invalid>
wrote:
> Hi Bhavik!
>
> What concerns do you have about back porting patches to earlier release
> branches?
>
> If we change our style guidelines then presumably we can do that for all
> branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style
> check on the destination branch unless something changed in the backporting.
>
> If you are referring to patches for clearing up line length violations, my
> usual preference is to aim for my changes to be on all active release
> lines. So at least in the case of the patches coming from me or being
> committed by me, there’d be effort to make sure all branches end up as easy
> to backport to as they were prior to the clean up.
>
>
>
> > On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com>
> wrote:
> >
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <mailto:
> 821684824@qq.com>> wrote:
> >
> >> +1 100 is reasonable.
> >>
> >>
> >>
> >> ---Original---
> >> From: "Xiaoqiao He"<hexiaoqiao@apache.org <mailto:hexiaoqiao@apache.org
> >>
> >> Date: Thu, May 20, 2021 13:35 PM
> >> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <mailto:
> iwasakims@oss.nttdata.co.jp>>;
> >> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop
> Common"<
> >> common-dev@hadoop.apache.org <mailto:common-dev@hadoop.apache.org
> >>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <mailto:
> hdfs-dev@hadoop.apache.org>
> >> >;"yarn-dev"<yarn-dev@hadoop.apache.org <mailto:
> yarn-dev@hadoop.apache.org>>;"mapreduce-dev"<
> >> mapreduce-dev@hadoop.apache.org <mailto:mapreduce-dev@hadoop.apache.org
> >>;
> >> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> >> length 100
> >>
> >>
> >> +1 for <= 100 chars long per line length.
> >>
> >> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> >> iwasakims@oss.nttdata.co.jp> wrote:
> >>
> >> > I'm +1 too.
> >> > I feel 80 characters limit tends to degrade readability by
> introducing
> >> > useless line breaks.
> >> >
> >> > >
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>
> >> ;
> >> > I have no inconvenience on 100 characters for using Emacs and
> >> side-by-side
> >> > diff even on 13-inch MBP.
> >> >
> >> > Masatake Iwasaki
> >> >
> >> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> >> > > I'm +1 to allow <= 100 chars.
> >> > >
> >> > > FYI: There were some discussions long before:
> >> > > -
> >> >
> >>
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> > -
> >> >
> >>
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> >> >
> >> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> >>;
> >> >
> >> > > Thanks,
> >> > > Akira
> >> > >
> >> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> >> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
> >> > wrote:
> >> > >>
> >> > >> Hello!
> >> > >>
> >> > >> What do folks think about changing our line length
> >> guidelines to allow
> >> > for 100 character width?
> >> > >>
> >> > >> Currently, we tell folks to follow the sun style guide
> with
> >> some
> >> > exception unrelated to line length. That guide says width of 80 is
> the
> >> > standard and our current check style rules act as enforcement.
> >> > >>
> >> > >> Looking at the current trunk codebase our nightly build
> >> shows a total
> >> > of ~15k line length violations; it’s about 18% of identified
> >> checkstyle
> >> > issues.
> >> > >>
> >> > >> The vast majority of those line length violations are <=
> 100
> >> characters
> >> > long. 100 characters happens to be the length for the Google Java
> >> Style
> >> > Guide, another commonly adopted style guide for java projects, so I
> >> suspect
> >> > these longer lines leaking past the checkstyle precommit warning
> >> might be a
> >> > reflection of committers working across multiple java codebases.
> >> > >>
> >> > >> I don’t feel strongly about lines being longer, but I
> would
> >> like to
> >> > move towards more consistent style enforcement as a project.
> Updating
> >> our
> >> > project guidance to allow for 100 character lines would reduce the
> >> > likelihood that folks bringing in new contributions need a
> precommit
> >> test
> >> > cycle to get the formatting correct.
> >> > >>
> >> > >> Does anyone feel strongly about keeping the line length
> >> limit at 80
> >> > characters?
> >> > >>
> >> > >> Does anyone feel strongly about contributions coming in
> that
> >> clear up
> >> > line length violations?
> >> > >>
> >> > >>
> >> > >>
> >> ---------------------------------------------------------------------
> >> > >> To unsubscribe, e-mail:
> >> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > >> For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >>
> >> > >
> >> > >
> >> ---------------------------------------------------------------------
> >> > > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org <mailto:
> common-dev-unsubscribe@hadoop.apache.org>
> >> > > For additional commands, e-mail:
> >> common-dev-help@hadoop.apache.org <mailto:
> common-dev-help@hadoop.apache.org>
> >> > >
> >> >
> >> >
> ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> <ma...@hadoop.apache.org>
> >> >
> >> >
>
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi Bhavik!
What concerns do you have about back porting patches to earlier release branches?
If we change our style guidelines then presumably we can do that for all branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style check on the destination branch unless something changed in the backporting.
If you are referring to patches for clearing up line length violations, my usual preference is to aim for my changes to be on all active release lines. So at least in the case of the patches coming from me or being committed by me, there’d be effort to make sure all branches end up as easy to backport to as they were prior to the clean up.
> On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com> wrote:
>
> I am just worried about the backporting of the Jira to child branch!! How
> we are planning to handle this?
>
> On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <ma...@qq.com>> wrote:
>
>> +1 100 is reasonable.
>>
>>
>>
>> ---Original---
>> From: "Xiaoqiao He"<hexiaoqiao@apache.org <ma...@apache.org>>
>> Date: Thu, May 20, 2021 13:35 PM
>> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <ma...@oss.nttdata.co.jp>>;
>> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop Common"<
>> common-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <ma...@hadoop.apache.org>
>> >;"yarn-dev"<yarn-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"mapreduce-dev"<
>> mapreduce-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;
>> Subject: Re: [DISCUSS] Change project style guidelines to allow line
>> length 100
>>
>>
>> +1 for <= 100 chars long per line length.
>>
>> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
>> iwasakims@oss.nttdata.co.jp> wrote:
>>
>> > I'm +1 too.
>> > I feel 80 characters limit tends to degrade readability by introducing
>> > useless line breaks.
>> >
>> > >
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>
>> ;
>> > I have no inconvenience on 100 characters for using Emacs and
>> side-by-side
>> > diff even on 13-inch MBP.
>> >
>> > Masatake Iwasaki
>> >
>> > On 2021/05/20 11:00, Akira Ajisaka wrote:
>> > > I'm +1 to allow <= 100 chars.
>> > >
>> > > FYI: There were some discussions long before:
>> > > -
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> > -
>> >
>> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> >
>> > > Thanks,
>> > > Akira
>> > >
>> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
>> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
>> > wrote:
>> > >>
>> > >> Hello!
>> > >>
>> > >> What do folks think about changing our line length
>> guidelines to allow
>> > for 100 character width?
>> > >>
>> > >> Currently, we tell folks to follow the sun style guide with
>> some
>> > exception unrelated to line length. That guide says width of 80 is the
>> > standard and our current check style rules act as enforcement.
>> > >>
>> > >> Looking at the current trunk codebase our nightly build
>> shows a total
>> > of ~15k line length violations; it’s about 18% of identified
>> checkstyle
>> > issues.
>> > >>
>> > >> The vast majority of those line length violations are <= 100
>> characters
>> > long. 100 characters happens to be the length for the Google Java
>> Style
>> > Guide, another commonly adopted style guide for java projects, so I
>> suspect
>> > these longer lines leaking past the checkstyle precommit warning
>> might be a
>> > reflection of committers working across multiple java codebases.
>> > >>
>> > >> I don’t feel strongly about lines being longer, but I would
>> like to
>> > move towards more consistent style enforcement as a project. Updating
>> our
>> > project guidance to allow for 100 character lines would reduce the
>> > likelihood that folks bringing in new contributions need a precommit
>> test
>> > cycle to get the formatting correct.
>> > >>
>> > >> Does anyone feel strongly about keeping the line length
>> limit at 80
>> > characters?
>> > >>
>> > >> Does anyone feel strongly about contributions coming in that
>> clear up
>> > line length violations?
>> > >>
>> > >>
>> > >>
>> ---------------------------------------------------------------------
>> > >> To unsubscribe, e-mail:
>> common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >> For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >>
>> > >
>> > >
>> ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > > For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > For additional commands, e-mail: common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> >
>> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi Bhavik!
What concerns do you have about back porting patches to earlier release branches?
If we change our style guidelines then presumably we can do that for all branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style check on the destination branch unless something changed in the backporting.
If you are referring to patches for clearing up line length violations, my usual preference is to aim for my changes to be on all active release lines. So at least in the case of the patches coming from me or being committed by me, there’d be effort to make sure all branches end up as easy to backport to as they were prior to the clean up.
> On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com> wrote:
>
> I am just worried about the backporting of the Jira to child branch!! How
> we are planning to handle this?
>
> On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <ma...@qq.com>> wrote:
>
>> +1 100 is reasonable.
>>
>>
>>
>> ---Original---
>> From: "Xiaoqiao He"<hexiaoqiao@apache.org <ma...@apache.org>>
>> Date: Thu, May 20, 2021 13:35 PM
>> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <ma...@oss.nttdata.co.jp>>;
>> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop Common"<
>> common-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <ma...@hadoop.apache.org>
>> >;"yarn-dev"<yarn-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"mapreduce-dev"<
>> mapreduce-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;
>> Subject: Re: [DISCUSS] Change project style guidelines to allow line
>> length 100
>>
>>
>> +1 for <= 100 chars long per line length.
>>
>> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
>> iwasakims@oss.nttdata.co.jp> wrote:
>>
>> > I'm +1 too.
>> > I feel 80 characters limit tends to degrade readability by introducing
>> > useless line breaks.
>> >
>> > >
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>
>> ;
>> > I have no inconvenience on 100 characters for using Emacs and
>> side-by-side
>> > diff even on 13-inch MBP.
>> >
>> > Masatake Iwasaki
>> >
>> > On 2021/05/20 11:00, Akira Ajisaka wrote:
>> > > I'm +1 to allow <= 100 chars.
>> > >
>> > > FYI: There were some discussions long before:
>> > > -
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> > -
>> >
>> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> >
>> > > Thanks,
>> > > Akira
>> > >
>> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
>> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
>> > wrote:
>> > >>
>> > >> Hello!
>> > >>
>> > >> What do folks think about changing our line length
>> guidelines to allow
>> > for 100 character width?
>> > >>
>> > >> Currently, we tell folks to follow the sun style guide with
>> some
>> > exception unrelated to line length. That guide says width of 80 is the
>> > standard and our current check style rules act as enforcement.
>> > >>
>> > >> Looking at the current trunk codebase our nightly build
>> shows a total
>> > of ~15k line length violations; it’s about 18% of identified
>> checkstyle
>> > issues.
>> > >>
>> > >> The vast majority of those line length violations are <= 100
>> characters
>> > long. 100 characters happens to be the length for the Google Java
>> Style
>> > Guide, another commonly adopted style guide for java projects, so I
>> suspect
>> > these longer lines leaking past the checkstyle precommit warning
>> might be a
>> > reflection of committers working across multiple java codebases.
>> > >>
>> > >> I don’t feel strongly about lines being longer, but I would
>> like to
>> > move towards more consistent style enforcement as a project. Updating
>> our
>> > project guidance to allow for 100 character lines would reduce the
>> > likelihood that folks bringing in new contributions need a precommit
>> test
>> > cycle to get the formatting correct.
>> > >>
>> > >> Does anyone feel strongly about keeping the line length
>> limit at 80
>> > characters?
>> > >>
>> > >> Does anyone feel strongly about contributions coming in that
>> clear up
>> > line length violations?
>> > >>
>> > >>
>> > >>
>> ---------------------------------------------------------------------
>> > >> To unsubscribe, e-mail:
>> common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >> For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >>
>> > >
>> > >
>> ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > > For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > For additional commands, e-mail: common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> >
>> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Viraj Jasani <vj...@apache.org>.
+1 (non-binding) to increasing line length to 100 instead of 80 and
applying this to all active branches (for the ease of backport as Stephen
mentioned).
On Thu, 20 May 2021 at 3:30 PM, Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> I am +1 on increasing the line length to 100.
>
> As for changes to address existing style issues - I think that is more pain
> than it's worth. It will make backports much harder, and we have quite a
> few active branches, not to mention those who maintain custom builds.
>
> To ease the backport problems the style fixes would need to be pushed down
> all the branches, otherwise if we start making them on trunk only, future
> changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
> etc.
>
>
> On Thu, May 20, 2021 at 8:28 AM Bhavik Patel <bh...@gmail.com>
> wrote:
>
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> >
> > > +1 100 is reasonable.
> > >
> > >
> > >
> > > ---Original---
> > > From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> > > Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> > > common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> > > >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> > > mapreduce-dev@hadoop.apache.org>;
> > > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > length 100
> > >
> > >
> > > +1 for <= 100 chars long per line length.
> > >
> > > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > iwasakims@oss.nttdata.co.jp> wrote:
> > >
> > > > I'm +1 too.
> > > > I feel 80 characters limit tends to degrade readability by
> > introducing
> > > > useless line breaks.
> > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >
> > > ;
> > > > I have no inconvenience on 100 characters for using Emacs and
> > > side-by-side
> > > > diff even on 13-inch MBP.
> > > >
> > > > Masatake Iwasaki
> > > >
> > > > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > I'm +1 to allow <= 100 chars.
> > > > >
> > > > > FYI: There were some discussions long before:
> > > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > >
> > > > > Thanks,
> > > > > Akira
> > > > >
> > > > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > <sbusbey@apple.com.invalid>
> > > > wrote:
> > > > >>
> > > > >> Hello!
> > > > >>
> > > > >> What do folks think about changing our line length
> > > guidelines to allow
> > > > for 100 character width?
> > > > >>
> > > > >> Currently, we tell folks to follow the sun style guide
> with
> > > some
> > > > exception unrelated to line length. That guide says width of 80 is
> > the
> > > > standard and our current check style rules act as enforcement.
> > > > >>
> > > > >> Looking at the current trunk codebase our nightly build
> > > shows a total
> > > > of ~15k line length violations; it’s about 18% of identified
> > > checkstyle
> > > > issues.
> > > > >>
> > > > >> The vast majority of those line length violations are <=
> > 100
> > > characters
> > > > long. 100 characters happens to be the length for the Google Java
> > > Style
> > > > Guide, another commonly adopted style guide for java projects, so
> I
> > > suspect
> > > > these longer lines leaking past the checkstyle precommit warning
> > > might be a
> > > > reflection of committers working across multiple java codebases.
> > > > >>
> > > > >> I don’t feel strongly about lines being longer, but I
> would
> > > like to
> > > > move towards more consistent style enforcement as a project.
> > Updating
> > > our
> > > > project guidance to allow for 100 character lines would reduce the
> > > > likelihood that folks bringing in new contributions need a
> precommit
> > > test
> > > > cycle to get the formatting correct.
> > > > >>
> > > > >> Does anyone feel strongly about keeping the line length
> > > limit at 80
> > > > characters?
> > > > >>
> > > > >> Does anyone feel strongly about contributions coming in
> > that
> > > clear up
> > > > line length violations?
> > > > >>
> > > > >>
> > > > >>
> > > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > >> For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >>
> > > > >
> > > > >
> > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > > >
> > > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Viraj Jasani <vj...@apache.org>.
+1 (non-binding) to increasing line length to 100 instead of 80 and
applying this to all active branches (for the ease of backport as Stephen
mentioned).
On Thu, 20 May 2021 at 3:30 PM, Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> I am +1 on increasing the line length to 100.
>
> As for changes to address existing style issues - I think that is more pain
> than it's worth. It will make backports much harder, and we have quite a
> few active branches, not to mention those who maintain custom builds.
>
> To ease the backport problems the style fixes would need to be pushed down
> all the branches, otherwise if we start making them on trunk only, future
> changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
> etc.
>
>
> On Thu, May 20, 2021 at 8:28 AM Bhavik Patel <bh...@gmail.com>
> wrote:
>
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> >
> > > +1 100 is reasonable.
> > >
> > >
> > >
> > > ---Original---
> > > From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> > > Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> > > common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> > > >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> > > mapreduce-dev@hadoop.apache.org>;
> > > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > length 100
> > >
> > >
> > > +1 for <= 100 chars long per line length.
> > >
> > > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > iwasakims@oss.nttdata.co.jp> wrote:
> > >
> > > > I'm +1 too.
> > > > I feel 80 characters limit tends to degrade readability by
> > introducing
> > > > useless line breaks.
> > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >
> > > ;
> > > > I have no inconvenience on 100 characters for using Emacs and
> > > side-by-side
> > > > diff even on 13-inch MBP.
> > > >
> > > > Masatake Iwasaki
> > > >
> > > > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > I'm +1 to allow <= 100 chars.
> > > > >
> > > > > FYI: There were some discussions long before:
> > > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > >
> > > > > Thanks,
> > > > > Akira
> > > > >
> > > > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > <sbusbey@apple.com.invalid>
> > > > wrote:
> > > > >>
> > > > >> Hello!
> > > > >>
> > > > >> What do folks think about changing our line length
> > > guidelines to allow
> > > > for 100 character width?
> > > > >>
> > > > >> Currently, we tell folks to follow the sun style guide
> with
> > > some
> > > > exception unrelated to line length. That guide says width of 80 is
> > the
> > > > standard and our current check style rules act as enforcement.
> > > > >>
> > > > >> Looking at the current trunk codebase our nightly build
> > > shows a total
> > > > of ~15k line length violations; it’s about 18% of identified
> > > checkstyle
> > > > issues.
> > > > >>
> > > > >> The vast majority of those line length violations are <=
> > 100
> > > characters
> > > > long. 100 characters happens to be the length for the Google Java
> > > Style
> > > > Guide, another commonly adopted style guide for java projects, so
> I
> > > suspect
> > > > these longer lines leaking past the checkstyle precommit warning
> > > might be a
> > > > reflection of committers working across multiple java codebases.
> > > > >>
> > > > >> I don’t feel strongly about lines being longer, but I
> would
> > > like to
> > > > move towards more consistent style enforcement as a project.
> > Updating
> > > our
> > > > project guidance to allow for 100 character lines would reduce the
> > > > likelihood that folks bringing in new contributions need a
> precommit
> > > test
> > > > cycle to get the formatting correct.
> > > > >>
> > > > >> Does anyone feel strongly about keeping the line length
> > > limit at 80
> > > > characters?
> > > > >>
> > > > >> Does anyone feel strongly about contributions coming in
> > that
> > > clear up
> > > > line length violations?
> > > > >>
> > > > >>
> > > > >>
> > > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > >> For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >>
> > > > >
> > > > >
> > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > > >
> > > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Viraj Jasani <vj...@apache.org>.
+1 (non-binding) to increasing line length to 100 instead of 80 and
applying this to all active branches (for the ease of backport as Stephen
mentioned).
On Thu, 20 May 2021 at 3:30 PM, Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> I am +1 on increasing the line length to 100.
>
> As for changes to address existing style issues - I think that is more pain
> than it's worth. It will make backports much harder, and we have quite a
> few active branches, not to mention those who maintain custom builds.
>
> To ease the backport problems the style fixes would need to be pushed down
> all the branches, otherwise if we start making them on trunk only, future
> changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
> etc.
>
>
> On Thu, May 20, 2021 at 8:28 AM Bhavik Patel <bh...@gmail.com>
> wrote:
>
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> >
> > > +1 100 is reasonable.
> > >
> > >
> > >
> > > ---Original---
> > > From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> > > Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> > > common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> > > >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> > > mapreduce-dev@hadoop.apache.org>;
> > > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > length 100
> > >
> > >
> > > +1 for <= 100 chars long per line length.
> > >
> > > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > iwasakims@oss.nttdata.co.jp> wrote:
> > >
> > > > I'm +1 too.
> > > > I feel 80 characters limit tends to degrade readability by
> > introducing
> > > > useless line breaks.
> > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >
> > > ;
> > > > I have no inconvenience on 100 characters for using Emacs and
> > > side-by-side
> > > > diff even on 13-inch MBP.
> > > >
> > > > Masatake Iwasaki
> > > >
> > > > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > I'm +1 to allow <= 100 chars.
> > > > >
> > > > > FYI: There were some discussions long before:
> > > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > >
> > > > > Thanks,
> > > > > Akira
> > > > >
> > > > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > <sbusbey@apple.com.invalid>
> > > > wrote:
> > > > >>
> > > > >> Hello!
> > > > >>
> > > > >> What do folks think about changing our line length
> > > guidelines to allow
> > > > for 100 character width?
> > > > >>
> > > > >> Currently, we tell folks to follow the sun style guide
> with
> > > some
> > > > exception unrelated to line length. That guide says width of 80 is
> > the
> > > > standard and our current check style rules act as enforcement.
> > > > >>
> > > > >> Looking at the current trunk codebase our nightly build
> > > shows a total
> > > > of ~15k line length violations; it’s about 18% of identified
> > > checkstyle
> > > > issues.
> > > > >>
> > > > >> The vast majority of those line length violations are <=
> > 100
> > > characters
> > > > long. 100 characters happens to be the length for the Google Java
> > > Style
> > > > Guide, another commonly adopted style guide for java projects, so
> I
> > > suspect
> > > > these longer lines leaking past the checkstyle precommit warning
> > > might be a
> > > > reflection of committers working across multiple java codebases.
> > > > >>
> > > > >> I don’t feel strongly about lines being longer, but I
> would
> > > like to
> > > > move towards more consistent style enforcement as a project.
> > Updating
> > > our
> > > > project guidance to allow for 100 character lines would reduce the
> > > > likelihood that folks bringing in new contributions need a
> precommit
> > > test
> > > > cycle to get the formatting correct.
> > > > >>
> > > > >> Does anyone feel strongly about keeping the line length
> > > limit at 80
> > > > characters?
> > > > >>
> > > > >> Does anyone feel strongly about contributions coming in
> > that
> > > clear up
> > > > line length violations?
> > > > >>
> > > > >>
> > > > >>
> > > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > >> For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >>
> > > > >
> > > > >
> > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > > >
> > > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Viraj Jasani <vj...@apache.org>.
+1 (non-binding) to increasing line length to 100 instead of 80 and
applying this to all active branches (for the ease of backport as Stephen
mentioned).
On Thu, 20 May 2021 at 3:30 PM, Stephen O'Donnell
<so...@cloudera.com.invalid> wrote:
> I am +1 on increasing the line length to 100.
>
> As for changes to address existing style issues - I think that is more pain
> than it's worth. It will make backports much harder, and we have quite a
> few active branches, not to mention those who maintain custom builds.
>
> To ease the backport problems the style fixes would need to be pushed down
> all the branches, otherwise if we start making them on trunk only, future
> changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
> etc.
>
>
> On Thu, May 20, 2021 at 8:28 AM Bhavik Patel <bh...@gmail.com>
> wrote:
>
> > I am just worried about the backporting of the Jira to child branch!! How
> > we are planning to handle this?
> >
> > On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> >
> > > +1 100 is reasonable.
> > >
> > >
> > >
> > > ---Original---
> > > From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> > > Date: Thu, May 20, 2021 13:35 PM
> > > To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> > > Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> > > common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> > > >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> > > mapreduce-dev@hadoop.apache.org>;
> > > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > > length 100
> > >
> > >
> > > +1 for <= 100 chars long per line length.
> > >
> > > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > > iwasakims@oss.nttdata.co.jp> wrote:
> > >
> > > > I'm +1 too.
> > > > I feel 80 characters limit tends to degrade readability by
> > introducing
> > > > useless line breaks.
> > > >
> > > > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >
> > > ;
> > > > I have no inconvenience on 100 characters for using Emacs and
> > > side-by-side
> > > > diff even on 13-inch MBP.
> > > >
> > > > Masatake Iwasaki
> > > >
> > > > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > > I'm +1 to allow <= 100 chars.
> > > > >
> > > > > FYI: There were some discussions long before:
> > > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > > -
> > > >
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > > >
> > > <
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> > >;
> > > >
> > > > > Thanks,
> > > > > Akira
> > > > >
> > > > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > > <sbusbey@apple.com.invalid>
> > > > wrote:
> > > > >>
> > > > >> Hello!
> > > > >>
> > > > >> What do folks think about changing our line length
> > > guidelines to allow
> > > > for 100 character width?
> > > > >>
> > > > >> Currently, we tell folks to follow the sun style guide
> with
> > > some
> > > > exception unrelated to line length. That guide says width of 80 is
> > the
> > > > standard and our current check style rules act as enforcement.
> > > > >>
> > > > >> Looking at the current trunk codebase our nightly build
> > > shows a total
> > > > of ~15k line length violations; it’s about 18% of identified
> > > checkstyle
> > > > issues.
> > > > >>
> > > > >> The vast majority of those line length violations are <=
> > 100
> > > characters
> > > > long. 100 characters happens to be the length for the Google Java
> > > Style
> > > > Guide, another commonly adopted style guide for java projects, so
> I
> > > suspect
> > > > these longer lines leaking past the checkstyle precommit warning
> > > might be a
> > > > reflection of committers working across multiple java codebases.
> > > > >>
> > > > >> I don’t feel strongly about lines being longer, but I
> would
> > > like to
> > > > move towards more consistent style enforcement as a project.
> > Updating
> > > our
> > > > project guidance to allow for 100 character lines would reduce the
> > > > likelihood that folks bringing in new contributions need a
> precommit
> > > test
> > > > cycle to get the formatting correct.
> > > > >>
> > > > >> Does anyone feel strongly about keeping the line length
> > > limit at 80
> > > > characters?
> > > > >>
> > > > >> Does anyone feel strongly about contributions coming in
> > that
> > > clear up
> > > > line length violations?
> > > > >>
> > > > >>
> > > > >>
> > > ---------------------------------------------------------------------
> > > > >> To unsubscribe, e-mail:
> > > common-dev-unsubscribe@hadoop.apache.org
> > > > >> For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >>
> > > > >
> > > > >
> > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > > > For additional commands, e-mail:
> > > common-dev-help@hadoop.apache.org
> > > > >
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > > >
> > > >
> >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Stephen O'Donnell <so...@cloudera.com.INVALID>.
I am +1 on increasing the line length to 100.
As for changes to address existing style issues - I think that is more pain
than it's worth. It will make backports much harder, and we have quite a
few active branches, not to mention those who maintain custom builds.
To ease the backport problems the style fixes would need to be pushed down
all the branches, otherwise if we start making them on trunk only, future
changes on trunk will not be able to be cherry-picked cleanly to branch-3.3
etc.
On Thu, May 20, 2021 at 8:28 AM Bhavik Patel <bh...@gmail.com>
wrote:
> I am just worried about the backporting of the Jira to child branch!! How
> we are planning to handle this?
>
> On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
>
> > +1 100 is reasonable.
> >
> >
> >
> > ---Original---
> > From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> > Date: Thu, May 20, 2021 13:35 PM
> > To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> > Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> > common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> > >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> > mapreduce-dev@hadoop.apache.org>;
> > Subject: Re: [DISCUSS] Change project style guidelines to allow line
> > length 100
> >
> >
> > +1 for <= 100 chars long per line length.
> >
> > On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> > iwasakims@oss.nttdata.co.jp> wrote:
> >
> > > I'm +1 too.
> > > I feel 80 characters limit tends to degrade readability by
> introducing
> > > useless line breaks.
> > >
> > > >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >
> > ;
> > > I have no inconvenience on 100 characters for using Emacs and
> > side-by-side
> > > diff even on 13-inch MBP.
> > >
> > > Masatake Iwasaki
> > >
> > > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > > I'm +1 to allow <= 100 chars.
> > > >
> > > > FYI: There were some discussions long before:
> > > > -
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > <
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
> >;
> > > -
> > >
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> > >
> > <
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
> >;
> > >
> > > > Thanks,
> > > > Akira
> > > >
> > > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> > <sbusbey@apple.com.invalid>
> > > wrote:
> > > >>
> > > >> Hello!
> > > >>
> > > >> What do folks think about changing our line length
> > guidelines to allow
> > > for 100 character width?
> > > >>
> > > >> Currently, we tell folks to follow the sun style guide with
> > some
> > > exception unrelated to line length. That guide says width of 80 is
> the
> > > standard and our current check style rules act as enforcement.
> > > >>
> > > >> Looking at the current trunk codebase our nightly build
> > shows a total
> > > of ~15k line length violations; it’s about 18% of identified
> > checkstyle
> > > issues.
> > > >>
> > > >> The vast majority of those line length violations are <=
> 100
> > characters
> > > long. 100 characters happens to be the length for the Google Java
> > Style
> > > Guide, another commonly adopted style guide for java projects, so I
> > suspect
> > > these longer lines leaking past the checkstyle precommit warning
> > might be a
> > > reflection of committers working across multiple java codebases.
> > > >>
> > > >> I don’t feel strongly about lines being longer, but I would
> > like to
> > > move towards more consistent style enforcement as a project.
> Updating
> > our
> > > project guidance to allow for 100 character lines would reduce the
> > > likelihood that folks bringing in new contributions need a precommit
> > test
> > > cycle to get the formatting correct.
> > > >>
> > > >> Does anyone feel strongly about keeping the line length
> > limit at 80
> > > characters?
> > > >>
> > > >> Does anyone feel strongly about contributions coming in
> that
> > clear up
> > > line length violations?
> > > >>
> > > >>
> > > >>
> > ---------------------------------------------------------------------
> > > >> To unsubscribe, e-mail:
> > common-dev-unsubscribe@hadoop.apache.org
> > > >> For additional commands, e-mail:
> > common-dev-help@hadoop.apache.org
> > > >>
> > > >
> > > >
> > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > > > For additional commands, e-mail:
> > common-dev-help@hadoop.apache.org
> > > >
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> > >
> > >
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi Bhavik!
What concerns do you have about back porting patches to earlier release branches?
If we change our style guidelines then presumably we can do that for all branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style check on the destination branch unless something changed in the backporting.
If you are referring to patches for clearing up line length violations, my usual preference is to aim for my changes to be on all active release lines. So at least in the case of the patches coming from me or being committed by me, there’d be effort to make sure all branches end up as easy to backport to as they were prior to the clean up.
> On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com> wrote:
>
> I am just worried about the backporting of the Jira to child branch!! How
> we are planning to handle this?
>
> On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <ma...@qq.com>> wrote:
>
>> +1 100 is reasonable.
>>
>>
>>
>> ---Original---
>> From: "Xiaoqiao He"<hexiaoqiao@apache.org <ma...@apache.org>>
>> Date: Thu, May 20, 2021 13:35 PM
>> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <ma...@oss.nttdata.co.jp>>;
>> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop Common"<
>> common-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <ma...@hadoop.apache.org>
>> >;"yarn-dev"<yarn-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"mapreduce-dev"<
>> mapreduce-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;
>> Subject: Re: [DISCUSS] Change project style guidelines to allow line
>> length 100
>>
>>
>> +1 for <= 100 chars long per line length.
>>
>> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
>> iwasakims@oss.nttdata.co.jp> wrote:
>>
>> > I'm +1 too.
>> > I feel 80 characters limit tends to degrade readability by introducing
>> > useless line breaks.
>> >
>> > >
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>
>> ;
>> > I have no inconvenience on 100 characters for using Emacs and
>> side-by-side
>> > diff even on 13-inch MBP.
>> >
>> > Masatake Iwasaki
>> >
>> > On 2021/05/20 11:00, Akira Ajisaka wrote:
>> > > I'm +1 to allow <= 100 chars.
>> > >
>> > > FYI: There were some discussions long before:
>> > > -
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> > -
>> >
>> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> >
>> > > Thanks,
>> > > Akira
>> > >
>> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
>> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
>> > wrote:
>> > >>
>> > >> Hello!
>> > >>
>> > >> What do folks think about changing our line length
>> guidelines to allow
>> > for 100 character width?
>> > >>
>> > >> Currently, we tell folks to follow the sun style guide with
>> some
>> > exception unrelated to line length. That guide says width of 80 is the
>> > standard and our current check style rules act as enforcement.
>> > >>
>> > >> Looking at the current trunk codebase our nightly build
>> shows a total
>> > of ~15k line length violations; it’s about 18% of identified
>> checkstyle
>> > issues.
>> > >>
>> > >> The vast majority of those line length violations are <= 100
>> characters
>> > long. 100 characters happens to be the length for the Google Java
>> Style
>> > Guide, another commonly adopted style guide for java projects, so I
>> suspect
>> > these longer lines leaking past the checkstyle precommit warning
>> might be a
>> > reflection of committers working across multiple java codebases.
>> > >>
>> > >> I don’t feel strongly about lines being longer, but I would
>> like to
>> > move towards more consistent style enforcement as a project. Updating
>> our
>> > project guidance to allow for 100 character lines would reduce the
>> > likelihood that folks bringing in new contributions need a precommit
>> test
>> > cycle to get the formatting correct.
>> > >>
>> > >> Does anyone feel strongly about keeping the line length
>> limit at 80
>> > characters?
>> > >>
>> > >> Does anyone feel strongly about contributions coming in that
>> clear up
>> > line length violations?
>> > >>
>> > >>
>> > >>
>> ---------------------------------------------------------------------
>> > >> To unsubscribe, e-mail:
>> common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >> For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >>
>> > >
>> > >
>> ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > > For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > For additional commands, e-mail: common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> >
>> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi Bhavik!
What concerns do you have about back porting patches to earlier release branches?
If we change our style guidelines then presumably we can do that for all branches, so a backport from e.g. trunk to branch-3.3 won’t fail a style check on the destination branch unless something changed in the backporting.
If you are referring to patches for clearing up line length violations, my usual preference is to aim for my changes to be on all active release lines. So at least in the case of the patches coming from me or being committed by me, there’d be effort to make sure all branches end up as easy to backport to as they were prior to the clean up.
> On May 20, 2021, at 2:27 AM, Bhavik Patel <bh...@gmail.com> wrote:
>
> I am just worried about the backporting of the Jira to child branch!! How
> we are planning to handle this?
>
> On Thu, May 20, 2021, 11:09 AM Qi Zhu <821684824@qq.com <ma...@qq.com>> wrote:
>
>> +1 100 is reasonable.
>>
>>
>>
>> ---Original---
>> From: "Xiaoqiao He"<hexiaoqiao@apache.org <ma...@apache.org>>
>> Date: Thu, May 20, 2021 13:35 PM
>> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp <ma...@oss.nttdata.co.jp>>;
>> Cc: "Akira Ajisaka"<aajisaka@apache.org <ma...@apache.org>>;"Hadoop Common"<
>> common-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org <ma...@hadoop.apache.org>
>> >;"yarn-dev"<yarn-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;"mapreduce-dev"<
>> mapreduce-dev@hadoop.apache.org <ma...@hadoop.apache.org>>;
>> Subject: Re: [DISCUSS] Change project style guidelines to allow line
>> length 100
>>
>>
>> +1 for <= 100 chars long per line length.
>>
>> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
>> iwasakims@oss.nttdata.co.jp> wrote:
>>
>> > I'm +1 too.
>> > I feel 80 characters limit tends to degrade readability by introducing
>> > useless line breaks.
>> >
>> > >
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>
>> ;
>> > I have no inconvenience on 100 characters for using Emacs and
>> side-by-side
>> > diff even on 13-inch MBP.
>> >
>> > Masatake Iwasaki
>> >
>> > On 2021/05/20 11:00, Akira Ajisaka wrote:
>> > > I'm +1 to allow <= 100 chars.
>> > >
>> > > FYI: There were some discussions long before:
>> > > -
>> >
>> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> > -
>> >
>> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>
>> >
>> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>>;
>> >
>> > > Thanks,
>> > > Akira
>> > >
>> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
>> <sbusbey@apple.com.invalid <ma...@apple.com.invalid>>
>> > wrote:
>> > >>
>> > >> Hello!
>> > >>
>> > >> What do folks think about changing our line length
>> guidelines to allow
>> > for 100 character width?
>> > >>
>> > >> Currently, we tell folks to follow the sun style guide with
>> some
>> > exception unrelated to line length. That guide says width of 80 is the
>> > standard and our current check style rules act as enforcement.
>> > >>
>> > >> Looking at the current trunk codebase our nightly build
>> shows a total
>> > of ~15k line length violations; it’s about 18% of identified
>> checkstyle
>> > issues.
>> > >>
>> > >> The vast majority of those line length violations are <= 100
>> characters
>> > long. 100 characters happens to be the length for the Google Java
>> Style
>> > Guide, another commonly adopted style guide for java projects, so I
>> suspect
>> > these longer lines leaking past the checkstyle precommit warning
>> might be a
>> > reflection of committers working across multiple java codebases.
>> > >>
>> > >> I don’t feel strongly about lines being longer, but I would
>> like to
>> > move towards more consistent style enforcement as a project. Updating
>> our
>> > project guidance to allow for 100 character lines would reduce the
>> > likelihood that folks bringing in new contributions need a precommit
>> test
>> > cycle to get the formatting correct.
>> > >>
>> > >> Does anyone feel strongly about keeping the line length
>> limit at 80
>> > characters?
>> > >>
>> > >> Does anyone feel strongly about contributions coming in that
>> clear up
>> > line length violations?
>> > >>
>> > >>
>> > >>
>> ---------------------------------------------------------------------
>> > >> To unsubscribe, e-mail:
>> common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >> For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >>
>> > >
>> > >
>> ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > > For additional commands, e-mail:
>> common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org <ma...@hadoop.apache.org>
>> > For additional commands, e-mail: common-dev-help@hadoop.apache.org <ma...@hadoop.apache.org>
>> >
>> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Bhavik Patel <bh...@gmail.com>.
I am just worried about the backporting of the Jira to child branch!! How
we are planning to handle this?
On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> +1 100 is reasonable.
>
>
>
> ---Original---
> From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> Date: Thu, May 20, 2021 13:35 PM
> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> mapreduce-dev@hadoop.apache.org>;
> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> length 100
>
>
> +1 for <= 100 chars long per line length.
>
> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> iwasakims@oss.nttdata.co.jp> wrote:
>
> > I'm +1 too.
> > I feel 80 characters limit tends to degrade readability by introducing
> > useless line breaks.
> >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>
> ;
> > I have no inconvenience on 100 characters for using Emacs and
> side-by-side
> > diff even on 13-inch MBP.
> >
> > Masatake Iwasaki
> >
> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > I'm +1 to allow <= 100 chars.
> > >
> > > FYI: There were some discussions long before:
> > > -
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> > -
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> >
> > > Thanks,
> > > Akira
> > >
> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> <sbusbey@apple.com.invalid>
> > wrote:
> > >>
> > >> Hello!
> > >>
> > >> What do folks think about changing our line length
> guidelines to allow
> > for 100 character width?
> > >>
> > >> Currently, we tell folks to follow the sun style guide with
> some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >>
> > >> Looking at the current trunk codebase our nightly build
> shows a total
> > of ~15k line length violations; it’s about 18% of identified
> checkstyle
> > issues.
> > >>
> > >> The vast majority of those line length violations are <= 100
> characters
> > long. 100 characters happens to be the length for the Google Java
> Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning
> might be a
> > reflection of committers working across multiple java codebases.
> > >>
> > >> I don’t feel strongly about lines being longer, but I would
> like to
> > move towards more consistent style enforcement as a project. Updating
> our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit
> test
> > cycle to get the formatting correct.
> > >>
> > >> Does anyone feel strongly about keeping the line length
> limit at 80
> > characters?
> > >>
> > >> Does anyone feel strongly about contributions coming in that
> clear up
> > line length violations?
> > >>
> > >>
> > >>
> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > >> For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >>
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Bhavik Patel <bh...@gmail.com>.
I am just worried about the backporting of the Jira to child branch!! How
we are planning to handle this?
On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> +1 100 is reasonable.
>
>
>
> ---Original---
> From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> Date: Thu, May 20, 2021 13:35 PM
> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> mapreduce-dev@hadoop.apache.org>;
> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> length 100
>
>
> +1 for <= 100 chars long per line length.
>
> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> iwasakims@oss.nttdata.co.jp> wrote:
>
> > I'm +1 too.
> > I feel 80 characters limit tends to degrade readability by introducing
> > useless line breaks.
> >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>
> ;
> > I have no inconvenience on 100 characters for using Emacs and
> side-by-side
> > diff even on 13-inch MBP.
> >
> > Masatake Iwasaki
> >
> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > I'm +1 to allow <= 100 chars.
> > >
> > > FYI: There were some discussions long before:
> > > -
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> > -
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> >
> > > Thanks,
> > > Akira
> > >
> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> <sbusbey@apple.com.invalid>
> > wrote:
> > >>
> > >> Hello!
> > >>
> > >> What do folks think about changing our line length
> guidelines to allow
> > for 100 character width?
> > >>
> > >> Currently, we tell folks to follow the sun style guide with
> some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >>
> > >> Looking at the current trunk codebase our nightly build
> shows a total
> > of ~15k line length violations; it’s about 18% of identified
> checkstyle
> > issues.
> > >>
> > >> The vast majority of those line length violations are <= 100
> characters
> > long. 100 characters happens to be the length for the Google Java
> Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning
> might be a
> > reflection of committers working across multiple java codebases.
> > >>
> > >> I don’t feel strongly about lines being longer, but I would
> like to
> > move towards more consistent style enforcement as a project. Updating
> our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit
> test
> > cycle to get the formatting correct.
> > >>
> > >> Does anyone feel strongly about keeping the line length
> limit at 80
> > characters?
> > >>
> > >> Does anyone feel strongly about contributions coming in that
> clear up
> > line length violations?
> > >>
> > >>
> > >>
> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > >> For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >>
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Bhavik Patel <bh...@gmail.com>.
I am just worried about the backporting of the Jira to child branch!! How
we are planning to handle this?
On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> +1 100 is reasonable.
>
>
>
> ---Original---
> From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> Date: Thu, May 20, 2021 13:35 PM
> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> mapreduce-dev@hadoop.apache.org>;
> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> length 100
>
>
> +1 for <= 100 chars long per line length.
>
> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> iwasakims@oss.nttdata.co.jp> wrote:
>
> > I'm +1 too.
> > I feel 80 characters limit tends to degrade readability by introducing
> > useless line breaks.
> >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>
> ;
> > I have no inconvenience on 100 characters for using Emacs and
> side-by-side
> > diff even on 13-inch MBP.
> >
> > Masatake Iwasaki
> >
> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > I'm +1 to allow <= 100 chars.
> > >
> > > FYI: There were some discussions long before:
> > > -
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> > -
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> >
> > > Thanks,
> > > Akira
> > >
> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> <sbusbey@apple.com.invalid>
> > wrote:
> > >>
> > >> Hello!
> > >>
> > >> What do folks think about changing our line length
> guidelines to allow
> > for 100 character width?
> > >>
> > >> Currently, we tell folks to follow the sun style guide with
> some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >>
> > >> Looking at the current trunk codebase our nightly build
> shows a total
> > of ~15k line length violations; it’s about 18% of identified
> checkstyle
> > issues.
> > >>
> > >> The vast majority of those line length violations are <= 100
> characters
> > long. 100 characters happens to be the length for the Google Java
> Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning
> might be a
> > reflection of committers working across multiple java codebases.
> > >>
> > >> I don’t feel strongly about lines being longer, but I would
> like to
> > move towards more consistent style enforcement as a project. Updating
> our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit
> test
> > cycle to get the formatting correct.
> > >>
> > >> Does anyone feel strongly about keeping the line length
> limit at 80
> > characters?
> > >>
> > >> Does anyone feel strongly about contributions coming in that
> clear up
> > line length violations?
> > >>
> > >>
> > >>
> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > >> For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >>
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Bhavik Patel <bh...@gmail.com>.
I am just worried about the backporting of the Jira to child branch!! How
we are planning to handle this?
On Thu, May 20, 2021, 11:09 AM Qi Zhu <82...@qq.com> wrote:
> +1 100 is reasonable.
>
>
>
> ---Original---
> From: "Xiaoqiao He"<hexiaoqiao@apache.org>
> Date: Thu, May 20, 2021 13:35 PM
> To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
> Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<
> common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org
> >;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<
> mapreduce-dev@hadoop.apache.org>;
> Subject: Re: [DISCUSS] Change project style guidelines to allow line
> length 100
>
>
> +1 for <= 100 chars long per line length.
>
> On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
> iwasakims@oss.nttdata.co.jp> wrote:
>
> > I'm +1 too.
> > I feel 80 characters limit tends to degrade readability by introducing
> > useless line breaks.
> >
> > >
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>
> ;
> > I have no inconvenience on 100 characters for using Emacs and
> side-by-side
> > diff even on 13-inch MBP.
> >
> > Masatake Iwasaki
> >
> > On 2021/05/20 11:00, Akira Ajisaka wrote:
> > > I'm +1 to allow <= 100 chars.
> > >
> > > FYI: There were some discussions long before:
> > > -
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> > -
> >
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> <https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E>>;
> >
> > > Thanks,
> > > Akira
> > >
> > > On Thu, May 20, 2021 at 6:36 AM Sean Busbey
> <sbusbey@apple.com.invalid>
> > wrote:
> > >>
> > >> Hello!
> > >>
> > >> What do folks think about changing our line length
> guidelines to allow
> > for 100 character width?
> > >>
> > >> Currently, we tell folks to follow the sun style guide with
> some
> > exception unrelated to line length. That guide says width of 80 is the
> > standard and our current check style rules act as enforcement.
> > >>
> > >> Looking at the current trunk codebase our nightly build
> shows a total
> > of ~15k line length violations; it’s about 18% of identified
> checkstyle
> > issues.
> > >>
> > >> The vast majority of those line length violations are <= 100
> characters
> > long. 100 characters happens to be the length for the Google Java
> Style
> > Guide, another commonly adopted style guide for java projects, so I
> suspect
> > these longer lines leaking past the checkstyle precommit warning
> might be a
> > reflection of committers working across multiple java codebases.
> > >>
> > >> I don’t feel strongly about lines being longer, but I would
> like to
> > move towards more consistent style enforcement as a project. Updating
> our
> > project guidance to allow for 100 character lines would reduce the
> > likelihood that folks bringing in new contributions need a precommit
> test
> > cycle to get the formatting correct.
> > >>
> > >> Does anyone feel strongly about keeping the line length
> limit at 80
> > characters?
> > >>
> > >> Does anyone feel strongly about contributions coming in that
> clear up
> > line length violations?
> > >>
> > >>
> > >>
> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail:
> common-dev-unsubscribe@hadoop.apache.org
> > >> For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >>
> > >
> > >
> ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > > For additional commands, e-mail:
> common-dev-help@hadoop.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
> >
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Qi Zhu <82...@qq.com>.
+1 100 is reasonable.
---Original---
From: "Xiaoqiao He"<hexiaoqiao@apache.org>
Date: Thu, May 20, 2021 13:35 PM
To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org>;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<mapreduce-dev@hadoop.apache.org>;
Subject: Re: [DISCUSS] Change project style guidelines to allow line length 100
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sbusbey@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Qi Zhu <82...@qq.com>.
+1 100 is reasonable.
---Original---
From: "Xiaoqiao He"<hexiaoqiao@apache.org>
Date: Thu, May 20, 2021 13:35 PM
To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org>;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<mapreduce-dev@hadoop.apache.org>;
Subject: Re: [DISCUSS] Change project style guidelines to allow line length 100
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sbusbey@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Qi Zhu <82...@qq.com>.
+1 100 is reasonable.
---Original---
From: "Xiaoqiao He"<hexiaoqiao@apache.org>
Date: Thu, May 20, 2021 13:35 PM
To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org>;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<mapreduce-dev@hadoop.apache.org>;
Subject: Re: [DISCUSS] Change project style guidelines to allow line length 100
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sbusbey@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Qi Zhu <82...@qq.com>.
+1 100 is reasonable.
---Original---
From: "Xiaoqiao He"<hexiaoqiao@apache.org>
Date: Thu, May 20, 2021 13:35 PM
To: "Masatake Iwasaki"<iwasakims@oss.nttdata.co.jp>;
Cc: "Akira Ajisaka"<aajisaka@apache.org>;"Hadoop Common"<common-dev@hadoop.apache.org>;"Hdfs-dev"<hdfs-dev@hadoop.apache.org>;"yarn-dev"<yarn-dev@hadoop.apache.org>;"mapreduce-dev"<mapreduce-dev@hadoop.apache.org>;
Subject: Re: [DISCUSS] Change project style guidelines to allow line length 100
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sbusbey@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Xiaoqiao He <he...@apache.org>.
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Xiaoqiao He <he...@apache.org>.
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Xiaoqiao He <he...@apache.org>.
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Xiaoqiao He <he...@apache.org>.
+1 for <= 100 chars long per line length.
On Thu, May 20, 2021 at 10:28 AM Masatake Iwasaki <
iwasakims@oss.nttdata.co.jp> wrote:
> I'm +1 too.
> I feel 80 characters limit tends to degrade readability by introducing
> useless line breaks.
>
> >
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
>
> I have no inconvenience on 100 characters for using Emacs and side-by-side
> diff even on 13-inch MBP.
>
> Masatake Iwasaki
>
> On 2021/05/20 11:00, Akira Ajisaka wrote:
> > I'm +1 to allow <= 100 chars.
> >
> > FYI: There were some discussions long before:
> > -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> > -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
> >
> > Thanks,
> > Akira
> >
> > On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >>
> >> Hello!
> >>
> >> What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >>
> >> Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >>
> >> Looking at the current trunk codebase our nightly build shows a total
> of ~15k line length violations; it’s about 18% of identified checkstyle
> issues.
> >>
> >> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >>
> >> I don’t feel strongly about lines being longer, but I would like to
> move towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >>
> >> Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >>
> >> Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> >> For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length
100
Posted by Masatake Iwasaki <iw...@oss.nttdata.co.jp>.
I'm +1 too.
I feel 80 characters limit tends to degrade readability by introducing useless line breaks.
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
I have no inconvenience on 100 characters for using Emacs and side-by-side diff even on 13-inch MBP.
Masatake Iwasaki
On 2021/05/20 11:00, Akira Ajisaka wrote:
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> - https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> - https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>>
>> Hello!
>>
>> What do folks think about changing our line length guidelines to allow for 100 character width?
>>
>> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>>
>> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>>
>> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>>
>> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>>
>> Does anyone feel strongly about keeping the line length limit at 80 characters?
>>
>> Does anyone feel strongly about contributions coming in that clear up line length violations?
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
>> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length
100
Posted by Masatake Iwasaki <iw...@oss.nttdata.co.jp>.
I'm +1 too.
I feel 80 characters limit tends to degrade readability by introducing useless line breaks.
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
I have no inconvenience on 100 characters for using Emacs and side-by-side diff even on 13-inch MBP.
Masatake Iwasaki
On 2021/05/20 11:00, Akira Ajisaka wrote:
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> - https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> - https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>>
>> Hello!
>>
>> What do folks think about changing our line length guidelines to allow for 100 character width?
>>
>> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>>
>> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>>
>> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>>
>> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>>
>> Does anyone feel strongly about keeping the line length limit at 80 characters?
>>
>> Does anyone feel strongly about contributions coming in that clear up line length violations?
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
>> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length
100
Posted by Masatake Iwasaki <iw...@oss.nttdata.co.jp>.
I'm +1 too.
I feel 80 characters limit tends to degrade readability by introducing useless line breaks.
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
I have no inconvenience on 100 characters for using Emacs and side-by-side diff even on 13-inch MBP.
Masatake Iwasaki
On 2021/05/20 11:00, Akira Ajisaka wrote:
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> - https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> - https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>>
>> Hello!
>>
>> What do folks think about changing our line length guidelines to allow for 100 character width?
>>
>> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>>
>> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>>
>> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>>
>> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>>
>> Does anyone feel strongly about keeping the line length limit at 80 characters?
>>
>> Does anyone feel strongly about contributions coming in that clear up line length violations?
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
>> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
+1 for 100 instead of 80.
I can see that some projects have already changed to 120.
Akira Ajisaka <aa...@apache.org> 于2021年5月20日周四 上午10:01写道：
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
+1 for 100 instead of 80.
I can see that some projects have already changed to 120.
Akira Ajisaka <aa...@apache.org> 于2021年5月20日周四 上午10:01写道：
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
+1 for 100 instead of 80.
I can see that some projects have already changed to 120.
Akira Ajisaka <aa...@apache.org> 于2021年5月20日周四 上午10:01写道：
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by "张铎 (Duo Zhang)" <pa...@gmail.com>.
+1 for 100 instead of 80.
I can see that some projects have already changed to 120.
Akira Ajisaka <aa...@apache.org> 于2021年5月20日周四 上午10:01写道：
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> -
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> -
> https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid>
> wrote:
> >
> > Hello!
> >
> > What do folks think about changing our line length guidelines to allow
> for 100 character width?
> >
> > Currently, we tell folks to follow the sun style guide with some
> exception unrelated to line length. That guide says width of 80 is the
> standard and our current check style rules act as enforcement.
> >
> > Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
> >
> > The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
> >
> > I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
> >
> > Does anyone feel strongly about keeping the line length limit at 80
> characters?
> >
> > Does anyone feel strongly about contributions coming in that clear up
> line length violations?
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> > For additional commands, e-mail: common-dev-help@hadoop.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length
100
Posted by Masatake Iwasaki <iw...@oss.nttdata.co.jp>.
I'm +1 too.
I feel 80 characters limit tends to degrade readability by introducing useless line breaks.
> https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
I have no inconvenience on 100 characters for using Emacs and side-by-side diff even on 13-inch MBP.
Masatake Iwasaki
On 2021/05/20 11:00, Akira Ajisaka wrote:
> I'm +1 to allow <= 100 chars.
>
> FYI: There were some discussions long before:
> - https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
> - https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
>
> Thanks,
> Akira
>
> On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>>
>> Hello!
>>
>> What do folks think about changing our line length guidelines to allow for 100 character width?
>>
>> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>>
>> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>>
>> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>>
>> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>>
>> Does anyone feel strongly about keeping the line length limit at 80 characters?
>>
>> Does anyone feel strongly about contributions coming in that clear up line length violations?
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
>> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
I'm +1 to allow <= 100 chars.
FYI: There were some discussions long before:
- https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
- https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
Thanks,
Akira
On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
I'm +1 to allow <= 100 chars.
FYI: There were some discussions long before:
- https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
- https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
Thanks,
Akira
On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
I'm +1 to allow <= 100 chars.
FYI: There were some discussions long before:
- https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
- https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
Thanks,
Akira
On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Steve Loughran <st...@cloudera.com.INVALID>.
+1
if you look closely the hadoop-azure module went to 100 lines a while back
and all is good
On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
> Hello!
>
> What do folks think about changing our line length guidelines to allow for
> 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception
> unrelated to line length. That guide says width of 80 is the standard and
> our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80
> characters?
>
> Does anyone feel strongly about contributions coming in that clear up line
> length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Steve Loughran <st...@cloudera.com.INVALID>.
+1
if you look closely the hadoop-azure module went to 100 lines a while back
and all is good
On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
> Hello!
>
> What do folks think about changing our line length guidelines to allow for
> 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception
> unrelated to line length. That guide says width of 80 is the standard and
> our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80
> characters?
>
> Does anyone feel strongly about contributions coming in that clear up line
> length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Steve Loughran <st...@cloudera.com.INVALID>.
+1
if you look closely the hadoop-azure module went to 100 lines a while back
and all is good
On Wed, 19 May 2021 at 22:13, Sean Busbey <sb...@apple.com.invalid> wrote:
> Hello!
>
> What do folks think about changing our line length guidelines to allow for
> 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception
> unrelated to line length. That guide says width of 80 is the standard and
> our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of
> ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters
> long. 100 characters happens to be the length for the Google Java Style
> Guide, another commonly adopted style guide for java projects, so I suspect
> these longer lines leaking past the checkstyle precommit warning might be a
> reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move
> towards more consistent style enforcement as a project. Updating our
> project guidance to allow for 100 character lines would reduce the
> likelihood that folks bringing in new contributions need a precommit test
> cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80
> characters?
>
> Does anyone feel strongly about contributions coming in that clear up line
> length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
>
>
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi folks!
The consensus seems pretty strongly in favor of increasing the line length limit. Do folks still want to see a formal VOTE thread?
> On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Akira Ajisaka <aa...@apache.org>.
I'm +1 to allow <= 100 chars.
FYI: There were some discussions long before:
- https://lists.apache.org/thread.html/7813c2f8a49b1d1e7655dad180f2d915a280b2f4d562cfe981e1dd4e%401406489966%40%3Ccommon-dev.hadoop.apache.org%3E
- https://lists.apache.org/thread.html/3e1785cbbe14dcab9bb970fa0f534811cfe00795a8cd1100580f27dc%401430849118%40%3Ccommon-dev.hadoop.apache.org%3E
Thanks,
Akira
On Thu, May 20, 2021 at 6:36 AM Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
> For additional commands, e-mail: common-dev-help@hadoop.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi folks!
The consensus seems pretty strongly in favor of increasing the line length limit. Do folks still want to see a formal VOTE thread?
> On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org
Re: [DISCUSS] Change project style guidelines to allow line length 100
Posted by Sean Busbey <sb...@apple.com.INVALID>.
Hi folks!
The consensus seems pretty strongly in favor of increasing the line length limit. Do folks still want to see a formal VOTE thread?
> On May 19, 2021, at 4:22 PM, Sean Busbey <sb...@apple.com.invalid> wrote:
>
> Hello!
>
> What do folks think about changing our line length guidelines to allow for 100 character width?
>
> Currently, we tell folks to follow the sun style guide with some exception unrelated to line length. That guide says width of 80 is the standard and our current check style rules act as enforcement.
>
> Looking at the current trunk codebase our nightly build shows a total of ~15k line length violations; it’s about 18% of identified checkstyle issues.
>
> The vast majority of those line length violations are <= 100 characters long. 100 characters happens to be the length for the Google Java Style Guide, another commonly adopted style guide for java projects, so I suspect these longer lines leaking past the checkstyle precommit warning might be a reflection of committers working across multiple java codebases.
>
> I don’t feel strongly about lines being longer, but I would like to move towards more consistent style enforcement as a project. Updating our project guidance to allow for 100 character lines would reduce the likelihood that folks bringing in new contributions need a precommit test cycle to get the formatting correct.
>
> Does anyone feel strongly about keeping the line length limit at 80 characters?
>
> Does anyone feel strongly about contributions coming in that clear up line length violations?
>
---------------------------------------------------------------------
To unsubscribe, e-mail: mapreduce-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: mapreduce-dev-help@hadoop.apache.org