[jira] Updated: (HADOOP-6926) SocketInputStream incorrectly implements read()

["Tom White (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-6926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tom White updated HADOOP-6926:
------------------------------

    Attachment: HADOOP-6926.patch

+1

The javac compilation error was due to:

{noformat}
<     [javac] /Users/tom/workspace/hadoop-common-trunk/src/test/core/org/apache/hadoop/net/TestSocketIOWithTimeout.java:112: warning: [cast] redundant cast to int
<     [javac]       assertEquals((int)(byteWithHighBit & 0xff), in.read());
{noformat}

Here's a new patch with the cast removed.

> SocketInputStream incorrectly implements read()
> -----------------------------------------------
>
>                 Key: HADOOP-6926
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6926
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.20.2, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6926.patch, hadoop-6926.txt
>
>
> SocketInputStream's read() implementation doesn't upcast to int correctly, so it can't read bytes > 0x80. This is the same bug as HADOOP-6925, but in a different spot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.