You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/08/25 02:24:34 UTC

[GitHub] [hadoop] wzhallright commented on a change in pull request #3328: HDFS-16183. RBF: Delete unnecessary metric of proxyOpComplete in routerRpcClient

wzhallright commented on a change in pull request #3328:
URL: https://github.com/apache/hadoop/pull/3328#discussion_r695342310



##########
File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -517,7 +517,6 @@ private Object invokeMethod(
           // Communication retries are handled by the retry policy
           if (this.rpcMonitor != null) {
             this.rpcMonitor.proxyOpFailureCommunicate();
-            this.rpcMonitor.proxyOpComplete(false);

Review comment:
       If boolean is false, proxyOpComplete in FederationRPCPerformanceMonitor will do nothing, so maybe it can be deleted?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org