You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ian Eure (JIRA)" <ji...@apache.org> on 2009/07/13 20:29:14 UTC

[jira] Created: (CASSANDRA-290) Superfluous .jar files should be removed

Superfluous .jar files should be removed
----------------------------------------

                 Key: CASSANDRA-290
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-290
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Ian Eure
            Priority: Minor


There appear to be quite a few .jar files in lib/ which aren't used:

commons-javaflow-1.0-SNAPSHOT.jar
commons-logging-1.0.4.jar
commons-math-1.1.jar
lucene-core-2.2.0.jar
stringtemplate-3.0.jar
zookeeper-3.0.0.jar

The unit and system tests run fine after removing all these files, and I saw no mention of them when I grepped src, so I believe they should be safe to remove.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-290) Superfluous .jar files should be removed

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Greene updated CASSANDRA-290:
-------------------------------------

    Component/s: Core

> Superfluous .jar files should be removed
> ----------------------------------------
>
>                 Key: CASSANDRA-290
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-290
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Ian Eure
>            Assignee: Ian Eure
>            Priority: Minor
>             Fix For: 0.4
>
>
> There appear to be quite a few .jar files in lib/ which aren't used:
> commons-javaflow-1.0-SNAPSHOT.jar
> commons-logging-1.0.4.jar
> commons-math-1.1.jar
> lucene-core-2.2.0.jar
> stringtemplate-3.0.jar
> zookeeper-3.0.0.jar
> The unit and system tests run fine after removing all these files, and I saw no mention of them when I grepped src, so I believe they should be safe to remove.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-290) Superfluous .jar files should be removed

Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730465#action_12730465 ] 

Michael Greene commented on CASSANDRA-290:
------------------------------------------

javaflow and zookeeper at least are actually referenced in the code (I'm not sure if they're actually *used*, I don't think zookeeper is) so there will need to be a patch in addition to the jar removal.

> Superfluous .jar files should be removed
> ----------------------------------------
>
>                 Key: CASSANDRA-290
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-290
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ian Eure
>            Priority: Minor
>
> There appear to be quite a few .jar files in lib/ which aren't used:
> commons-javaflow-1.0-SNAPSHOT.jar
> commons-logging-1.0.4.jar
> commons-math-1.1.jar
> lucene-core-2.2.0.jar
> stringtemplate-3.0.jar
> zookeeper-3.0.0.jar
> The unit and system tests run fine after removing all these files, and I saw no mention of them when I grepped src, so I believe they should be safe to remove.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-290) Superfluous .jar files should be removed

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-290.
--------------------------------------

    Resolution: Fixed
      Assignee: Ian Eure

committed removal of all but javaflow and zookeeper.

removing those two will be nontrivial given the use in concurrent; I recommend leaving them alone unless you have the time to figure out what is actually going on there.  (I'm all for removing unused code, but only if I understand what it's for. :)

> Superfluous .jar files should be removed
> ----------------------------------------
>
>                 Key: CASSANDRA-290
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-290
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ian Eure
>            Assignee: Ian Eure
>            Priority: Minor
>
> There appear to be quite a few .jar files in lib/ which aren't used:
> commons-javaflow-1.0-SNAPSHOT.jar
> commons-logging-1.0.4.jar
> commons-math-1.1.jar
> lucene-core-2.2.0.jar
> stringtemplate-3.0.jar
> zookeeper-3.0.0.jar
> The unit and system tests run fine after removing all these files, and I saw no mention of them when I grepped src, so I believe they should be safe to remove.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-290) Superfluous .jar files should be removed

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730819#action_12730819 ] 

Hudson commented on CASSANDRA-290:
----------------------------------

Integrated in Cassandra #137 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/137/])
    r/m unused jars from lib/.  patch by Ian Eure; reviewed by jbellis for 


> Superfluous .jar files should be removed
> ----------------------------------------
>
>                 Key: CASSANDRA-290
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-290
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Ian Eure
>            Assignee: Ian Eure
>            Priority: Minor
>
> There appear to be quite a few .jar files in lib/ which aren't used:
> commons-javaflow-1.0-SNAPSHOT.jar
> commons-logging-1.0.4.jar
> commons-math-1.1.jar
> lucene-core-2.2.0.jar
> stringtemplate-3.0.jar
> zookeeper-3.0.0.jar
> The unit and system tests run fine after removing all these files, and I saw no mention of them when I grepped src, so I believe they should be safe to remove.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.