You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2024/12/09 17:49:29 UTC

[PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

raulcd opened a new pull request, #44981:
URL: https://github.com/apache/arrow/pull/44981

   ### Rationale for this change
   
   The job is currently failing.
   
   ### What changes are included in this PR?
   
   Remove unnecessary check on Java code.
   
   ### Are these changes tested?
   
   Via archery
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529087381

   Revision: 3deeecdcf2d592391affde2dfb484c6d0a92afdb
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-ab6d626f46](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ab6d626f46)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.11-spark-master|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-ab6d626f46-github-test-conda-python-3.11-spark-master)](https://github.com/ursacomputing/crossbow/actions/runs/12242249581/job/34149146678)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2528897345

   @github-actions crossbow submit test-*-spark-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529081440

   @github-actions crossbow submit test-*-spark-*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2528896215

   :warning: GitHub issue #44980 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #44981:
URL: https://github.com/apache/arrow/pull/44981#discussion_r1877175911


##########
ci/scripts/integration_spark.sh:
##########
@@ -47,8 +42,12 @@ pushd ${spark_dir}
   build/mvn -B -DskipTests package
 
   # Run pyarrow related Python tests only
+  # "pyspark.sql.tests.arrow.test_arrow_grouped_map" and
+  # "pyspark.sql.tests.arrow.test_arrow_cogrouped_map" currently fail.

Review Comment:
   Are they known issues? If so, could you add an issue number?
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of arrow version from Java on Spark integration and update test structure for pyspark [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529446171

   Revision: e661dea9f928497381a44c50d5927f53ed06dfbb
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-7f74565d52](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7f74565d52)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.11-spark-master|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-7f74565d52-github-test-conda-python-3.11-spark-master)](https://github.com/ursacomputing/crossbow/actions/runs/12244263149/job/34155627327)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2528905647

   Revision: c410de99d671db17e1e7cb19402943804557e50f
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-5eb2ac471e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5eb2ac471e)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.11-spark-master|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-5eb2ac471e-github-test-conda-python-3.11-spark-master)](https://github.com/ursacomputing/crossbow/actions/runs/12241352911/job/34146233454)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove unnecessary retrieval of arrow version from Java on Spark integration [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529066575

   Tests seem to be failing but this failure is not related to the original issue:
   ```
    Starting test(python): pyspark.sql.tests.test_arrow (temp output: /spark/python/target/71d33db2-ca30-4e89-8edf-6aed57761990/python__pyspark.sql.tests.test_arrow__kzeeud_w.log)
   /opt/conda/envs/arrow/bin/python: No module named pyspark.sql.tests.test_arrow
   
   Had test failures in pyspark.sql.tests.test_arrow with python; see logs.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #44981:
URL: https://github.com/apache/arrow/pull/44981


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of arrow version from Java on Spark integration and update test structure for pyspark [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529441463

   @github-actions crossbow submit test-conda-python-3.11-spark-master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2580411374

   After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 5db28433db2ed67704b06c0aeab7948403688d52.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/35376658527) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of arrow version from Java on Spark integration and update test structure for pyspark [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529229244

   Revision: 084399ae1b3bca9465bf575c5cf2cb09009497b6
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-f1ce0ab770](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f1ce0ab770)
   
   |Task|Status|
   |----|------|
   |test-conda-python-3.11-spark-master|[![GitHub Actions](https://github.com/ursacomputing/crossbow/actions/workflows/crossbow.yml/badge.svg?branch=actions-f1ce0ab770-github-test-conda-python-3.11-spark-master)](https://github.com/ursacomputing/crossbow/actions/runs/12243002821/job/34151554153)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of arrow version from Java on Spark integration and update test structure for pyspark [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #44981:
URL: https://github.com/apache/arrow/pull/44981#issuecomment-2529223094

   @github-actions crossbow submit test-conda-python-3.11-spark-master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-44980: [CI] Remove retrieval of Arrow version from Java on Spark integration and update test structure for PySpark [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #44981:
URL: https://github.com/apache/arrow/pull/44981#discussion_r1877666103


##########
ci/scripts/integration_spark.sh:
##########
@@ -47,8 +42,12 @@ pushd ${spark_dir}
   build/mvn -B -DskipTests package
 
   # Run pyarrow related Python tests only
+  # "pyspark.sql.tests.arrow.test_arrow_grouped_map" and
+  # "pyspark.sql.tests.arrow.test_arrow_cogrouped_map" currently fail.

Review Comment:
   I've added a comment with the issue: https://github.com/apache/arrow/issues/44986
    As shared on the new issue those tests were never run in the past but might be worth adding them as they are arrow related.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org