You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/11/06 11:09:55 UTC
Review Request 71725: Added end-to-end test for operator API
reservation updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
Added a new test to verify that reservations can be updated
using the operator API.
Diffs
-----
src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
Diff: https://reviews.apache.org/r/71725/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71725: Added end-to-end test for operator API
reservation updates.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218564
-----------------------------------------------------------
Bad review!
Reviews applied: [71725, 71729]
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Nov. 6, 2019, 3:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 3:54 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test to verify that reservations can be updated
> using the operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
>
>
> Diff: https://reviews.apache.org/r/71725/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71725: Added end-to-end test for operator API
reservation updates.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218553
-----------------------------------------------------------
Bad review!
Reviews applied: [71725, 71729]
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Nov. 6, 2019, 3:54 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 3:54 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test to verify that reservations can be updated
> using the operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
>
>
> Diff: https://reviews.apache.org/r/71725/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71725: Added end-to-end test for operator API
reservation updates.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/
-----------------------------------------------------------
(Updated Nov. 6, 2019, 3:54 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Add correct dependency.
Repository: mesos
Description
-------
Added a new test to verify that reservations can be updated
using the operator API.
Diffs
-----
src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
Diff: https://reviews.apache.org/r/71725/diff/2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71725: Added end-to-end test for operator API
reservation updates.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/
-----------------------------------------------------------
(Updated Nov. 6, 2019, 3:53 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed comments; removed bool parameter.
Repository: mesos
Description
-------
Added a new test to verify that reservations can be updated
using the operator API.
Diffs (updated)
-----
src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
Diff: https://reviews.apache.org/r/71725/diff/2/
Changes: https://reviews.apache.org/r/71725/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71725: Added end-to-end test for operator API
reservation updates.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218537
-----------------------------------------------------------
Fix it, then Ship it!
Nice approach to make the "meat" of the test more obvious through helpers.
src/tests/api_tests.cpp
Lines 1491 (patched)
<https://reviews.apache.org/r/71725/#comment306271>
Stray spaces
src/tests/api_tests.cpp
Lines 1519 (patched)
<https://reviews.apache.org/r/71725/#comment306273>
Nit: to more match the usage we could define this before `verifyReservation`.
src/tests/api_tests.cpp
Lines 1521 (patched)
<https://reviews.apache.org/r/71725/#comment306274>
We could name this `resources` for symmetry.
src/tests/api_tests.cpp
Lines 1553 (patched)
<https://reviews.apache.org/r/71725/#comment306272>
Line too long
- Benjamin Bannier
On Nov. 6, 2019, 12:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 12:09 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test to verify that reservations can be updated
> using the operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
>
>
> Diff: https://reviews.apache.org/r/71725/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71725: Added end-to-end test for operator API
reservation updates.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218531
-----------------------------------------------------------
Bad review!
Reviews applied: [71725, 71729]
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot
On Nov. 6, 2019, 12:09 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 12:09 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a new test to verify that reservations can be updated
> using the operator API.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a
>
>
> Diff: https://reviews.apache.org/r/71725/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>