[GitHub] [guacamole-client] necouchman commented on a diff in pull request #752: GUACAMOLE-1612: Fix/Add italian translations

["necouchman (via GitHub)" <gi...@apache.org>]

necouchman commented on code in PR #752:
URL: https://github.com/apache/guacamole-client/pull/752#discussion_r1135979991


##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-base/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,23 @@
+{
+
+    "DATA_SOURCE_CAS" : {
+        "NAME" : "CAS SSO Backend"

Review Comment:
   You can leave out any strings that you're not specifically translating, unless this is the Italian translation?



##########
extensions/guacamole-auth-duo/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,11 @@
+{
+
+    "DATA_SOURCE_DUO" : {
+     },

Review Comment:
   There's no reason to include a completely empty section.



##########
extensions/guacamole-auth-totp/src/main/resources/translations/it.json:
##########
@@ -0,0 +1,42 @@
+{
+
+    "DATA_SOURCE_TOTP" : {
+        "NAME" : "TOTP TFA Backend"
+    },
+
+    "LOGIN" : {
+    },

Review Comment:
   Please remove the empty section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org