[GitHub] [hadoop-ozone] anuengineer commented on a change in pull request #381: HDDS-2781. Add ObjectID and updateID to BucketInfo to avoid replaying transactions

[GitBox <gi...@apache.org>]

anuengineer commented on a change in pull request #381: HDDS-2781. Add ObjectID and updateID to BucketInfo to avoid replaying transactions
URL: https://github.com/apache/hadoop-ozone/pull/381#discussion_r364905128
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java
 ##########
 @@ -266,8 +266,6 @@ public static Builder newBuilder() {
     auditMap.put(OzoneConsts.STORAGE_TYPE,
         (this.storageType != null) ? this.storageType.name() : null);
     auditMap.put(OzoneConsts.CREATION_TIME, String.valueOf(this.creationTime));
-    auditMap.put(OzoneConsts.OBJECT_ID, String.valueOf(this.getObjectID()));
-    auditMap.put(OzoneConsts.UPDATE_ID, String.valueOf(this.getUpdateID()));
 
 Review comment:
   I am in 2 minds about this change. This is useful if someone deletes and re-creates a bucket with same name it would be easy for us to identify that information. No need to fix in this, just curious why you thought this is a bad idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org