You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by kawamuray <gi...@git.apache.org> on 2016/07/11 14:02:45 UTC
[GitHub] kafka pull request #1607: MINOR: Doc of 'retires' config should mention abou...
GitHub user kawamuray opened a pull request:
https://github.com/apache/kafka/pull/1607
MINOR: Doc of 'retires' config should mention about max.in.flight.requests.per.connection to avoid confusion
When I first read the doc of producer config `retries`, it was quite confusing because it sounds like there's no way to guarantee in-order message producing with keep it durable for broker failure.
If my understanding is correct, I felt it is much kind if the doc of `retries` mention about `max.in.flight.requests.per.connection`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kawamuray/kafka MINOR-retries-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1607.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1607
----
commit f4f0b00da6cf8daf01dea102f9442cc940661b0f
Author: Yuto Kawamura <ka...@gmail.com>
Date: 2016-07-11T13:47:14Z
MINOR: Doc of 'retires' config should mention about max.in.flight.requests.per.connection to avoid confusion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #1607: MINOR: Doc of 'retries' config should mention abou...
Posted by kawamuray <gi...@git.apache.org>.
GitHub user kawamuray reopened a pull request:
https://github.com/apache/kafka/pull/1607
MINOR: Doc of 'retries' config should mention about max.in.flight.requests.per.connection to avoid confusion
When I first read the doc of producer config `retries`, it was quite confusing because it sounds like there's no way to guarantee in-order message producing with keep it durable for broker failure.
If my understanding is correct, I felt it is much kind if the doc of `retries` mention about `max.in.flight.requests.per.connection`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kawamuray/kafka MINOR-retries-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1607.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1607
----
commit f4f0b00da6cf8daf01dea102f9442cc940661b0f
Author: Yuto Kawamura <ka...@gmail.com>
Date: 2016-07-11T13:47:14Z
MINOR: Doc of 'retires' config should mention about max.in.flight.requests.per.connection to avoid confusion
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #1607: MINOR: Doc of 'retries' config should mention abou...
Posted by kawamuray <gi...@git.apache.org>.
Github user kawamuray closed the pull request at:
https://github.com/apache/kafka/pull/1607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #1607: MINOR: Doc of 'retries' config should mention abou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/1607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---