You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oro-dev@jakarta.apache.org by "Mark F. Murphy" <ma...@tyrell.com> on 2001/05/10 22:24:41 UTC

Recent Patch...

I just sent off the patch for the new Upper and Lower case perl substitutions.

I apologize for it using Vector... but in my current development 
environment where I have these changes I cannot switch to JDK 1.2...

I figured the features found in the patch might outweigh the need to 
use ArrayList over Vector.

Not to mention that switching to ArrayList wouldn't be that difficult 
to do for anyone else who happens to have a JDK 1.2 they can 
work/test with.

Again, I apologize.

Hope these new features are useful.

I also tried to gain some performance by not making many instances of 
Strings (as was used in the previous approach).

Instead, I keep offset/count pairs in the Vector.

Ideally, I really wanted to just keep my own int[] to save memory and 
less object creation... growing the int[] as required past initial 
capacity.  Doing so would use scalars and not objects... and would be 
less overhead.

However, I wasn't sure how far I really wanted to modify the class's 
member vars... I know they are all private... but this is my first 
time submitting a patch so I didn't want to go overboard.

Let me know if the patch is acceptable or if there is other work I 
must to do get it up to par.

Looking forward to feedback.

mark

-- 
---------------------------------------------------------------------------
  Mark F. Murphy, Director Software Development   <ma...@tyrell.com>
  Tyrell Software Corp                            <http://www.tyrell.com>
  PowerPerl(tm), Add Power To Your Webpage!       <http://www.powerperl.com>
---------------------------------------------------------------------------
  Families Against Internet Censorship:        http://www.netfamilies.org/