You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by bric3 <gi...@git.apache.org> on 2015/06/08 15:32:25 UTC

[GitHub] activemq pull request: Renames env script to avoid possible GNU en...

GitHub user bric3 opened a pull request:

    https://github.com/apache/activemq/pull/109

    Renames env script to avoid possible GNU env exec shadowing

    Got an issue with other shell scripts, turns out that when one prepends `$PATH` by `activemq/bin`, `env` is shadowed by ActiveMQ's `env`.
    
    That means that script that want to run commands in customized environment will simple don't be executed like : 
    
    ```sh
    env A=aaa B=bbb mv ...
    ```
    
    Worse such lines won't fail, because this will return the `0` exit status. The workaround is simple, i.e. append in `%PATH` instead of prepend. But a proper fix is needed. This PR proposes to rename the shell script from `env` to `activemq-env`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bric3/activemq renames-env

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit 81d0529a8a84437e5161d41b21817b4e860b02eb
Author: Brice Dutheil <br...@gmail.com>
Date:   2015-06-08T13:24:38Z

    Renames env to avoid possible GNU env shadowing

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---