You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "serrislew (via GitHub)" <gi...@apache.org> on 2024/07/02 18:52:53 UTC
[PR] No remap rules matched metric [trafficserver]
serrislew opened a new pull request, #11506:
URL: https://github.com/apache/trafficserver/pull/11506
Add metric when none of the remap rules matched to client request and ATS returns 404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] No remap rules matched metric [trafficserver]
Posted by "serrislew (via GitHub)" <gi...@apache.org>.
serrislew merged PR #11506:
URL: https://github.com/apache/trafficserver/pull/11506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] No remap rules matched metric [trafficserver]
Posted by "mtorluemke (via GitHub)" <gi...@apache.org>.
mtorluemke commented on code in PR #11506:
URL: https://github.com/apache/trafficserver/pull/11506#discussion_r1663150634
##########
include/proxy/http/HttpConfig.h:
##########
@@ -125,6 +125,7 @@ struct HttpStatsBlock {
Metrics::Counter::AtomicType *misc_origin_server_bytes;
Metrics::Counter::AtomicType *misc_user_agent_bytes;
Metrics::Counter::AtomicType *missing_host_hdr;
+ Metrics::Counter::AtomicType *no_remap_404;
Review Comment:
Maybe better matching the ptr: "no_remap_matched" (404 here is a bit redundant).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] No remap rules matched metric [trafficserver]
Posted by "mtorluemke (via GitHub)" <gi...@apache.org>.
mtorluemke commented on code in PR #11506:
URL: https://github.com/apache/trafficserver/pull/11506#discussion_r1663151041
##########
src/proxy/http/HttpConfig.cc:
##########
@@ -335,6 +335,7 @@ register_stat_callbacks()
http_rsb.misc_origin_server_bytes = Metrics::Counter::createPtr("proxy.process.http.http_misc_origin_server_bytes");
http_rsb.misc_user_agent_bytes = Metrics::Counter::createPtr("proxy.process.http.misc_user_agent_bytes");
http_rsb.missing_host_hdr = Metrics::Counter::createPtr("proxy.process.http.missing_host_hdr");
+ http_rsb.no_remap_404 = Metrics::Counter::createPtr("proxy.process.http.no_remap_matched_404");
Review Comment:
I'd think 404 here is redundant; maybe just drop _404.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] No remap rules matched metric [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #11506:
URL: https://github.com/apache/trafficserver/pull/11506#issuecomment-2218382156
Cherry-picked to v10.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org