You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Geoffrey Jacoby (Jira)" <ji...@apache.org> on 2020/01/22 19:41:00 UTC

[jira] [Reopened] (PHOENIX-5677) Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code

     [ https://issues.apache.org/jira/browse/PHOENIX-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoffrey Jacoby reopened PHOENIX-5677:
--------------------------------------

Broke IndexScrutinyIT tests because of infinite recursion. Missed this because Phoenix Jenkins was broken for a few days, and I mistakenly thought I'd verified this locally. My apologies. 

> Replace System.currentTimeMillis with EnvironmentEdgeManager in non-test code
> -----------------------------------------------------------------------------
>
>                 Key: PHOENIX-5677
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5677
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5677-4.x-HBase-1.3.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Phoenix is inconsistent in using either system clock or EnvironmentEdgeManager to get current time. The EnvironmentEdgeManager is occasionally very useful in tests to control time deterministically without needing to sleep. Direct references to System.currentTimeMillis in non-test code should be switched over. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)