You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/09/08 19:35:42 UTC
Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/
-----------------------------------------------------------
Review request for geode, Anthony Baker and Dan Smith.
Repository: geode
Description
-------
This also disables default archive signing which requires GPG keys
Diffs
-----
build.gradle e112eb77847371f730ba72febfa350bfe9466832
gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
Diff: https://reviews.apache.org/r/51741/diff/
Testing
-------
Local building. The changes come into effect when using 'uploadArchives'.
Thanks,
Jens Deppe
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/#review148766
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Bretl
On Sept. 10, 2016, 8:15 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51741/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2016, 8:15 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This also disables default archive signing which requires GPG keys
>
>
> Diffs
> -----
>
> build.gradle e112eb77847371f730ba72febfa350bfe9466832
> gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
> gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
>
> Diff: https://reviews.apache.org/r/51741/diff/
>
>
> Testing
> -------
>
> Local building. The changes come into effect when using 'uploadArchives'.
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/#review148517
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Sept. 11, 2016, 3:15 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51741/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 3:15 a.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This also disables default archive signing which requires GPG keys
>
>
> Diffs
> -----
>
> build.gradle e112eb77847371f730ba72febfa350bfe9466832
> gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
> gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
>
> Diff: https://reviews.apache.org/r/51741/diff/
>
>
> Testing
> -------
>
> Local building. The changes come into effect when using 'uploadArchives'.
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Anthony Baker <ab...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/#review148492
-----------------------------------------------------------
Ship it!
Ship It!
- Anthony Baker
On Sept. 11, 2016, 3:15 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51741/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2016, 3:15 a.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This also disables default archive signing which requires GPG keys
>
>
> Diffs
> -----
>
> build.gradle e112eb77847371f730ba72febfa350bfe9466832
> gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
> gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
>
> Diff: https://reviews.apache.org/r/51741/diff/
>
>
> Testing
> -------
>
> Local building. The changes come into effect when using 'uploadArchives'.
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/
-----------------------------------------------------------
(Updated Sept. 11, 2016, 3:15 a.m.)
Review request for geode, Anthony Baker and Dan Smith.
Repository: geode
Description
-------
This also disables default archive signing which requires GPG keys
Diffs (updated)
-----
build.gradle e112eb77847371f730ba72febfa350bfe9466832
gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
Diff: https://reviews.apache.org/r/51741/diff/
Testing
-------
Local building. The changes come into effect when using 'uploadArchives'.
Thanks,
Jens Deppe
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/
-----------------------------------------------------------
(Updated Sept. 11, 2016, 2:20 a.m.)
Review request for geode, Anthony Baker and Dan Smith.
Changes
-------
Restore '-SNAPSHOT' releaseType. Enable signing by default but allow for overriding.
Repository: geode
Description
-------
This also disables default archive signing which requires GPG keys
Diffs (updated)
-----
build.gradle e112eb77847371f730ba72febfa350bfe9466832
gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
Diff: https://reviews.apache.org/r/51741/diff/
Testing
-------
Local building. The changes come into effect when using 'uploadArchives'.
Thanks,
Jens Deppe
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/#review148351
-----------------------------------------------------------
The changes look good, but I don't think we want to disable release signing by default. Geode releases should be signed with gpg.
- Dan Smith
On Sept. 8, 2016, 7:35 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51741/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 7:35 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This also disables default archive signing which requires GPG keys
>
>
> Diffs
> -----
>
> build.gradle e112eb77847371f730ba72febfa350bfe9466832
> gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
> gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
>
> Diff: https://reviews.apache.org/r/51741/diff/
>
>
> Testing
> -------
>
> Local building. The changes come into effect when using 'uploadArchives'.
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Dan Smith <ds...@pivotal.io>.
> On Sept. 9, 2016, 7:52 p.m., Mark Bretl wrote:
> > gradle.properties, line 33
> > <https://reviews.apache.org/r/51741/diff/1/?file=1494641#file1494641line33>
> >
> > Do we want to remove '-SNAPSHOT' while on the develop branch? This will cause issues with the nightly upload. I would expect this to change on the release branch.
Good catch! I agree, we definitely don't want to remove -SNAPSHOT on develop!
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/#review148360
-----------------------------------------------------------
On Sept. 8, 2016, 7:35 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51741/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 7:35 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This also disables default archive signing which requires GPG keys
>
>
> Diffs
> -----
>
> build.gradle e112eb77847371f730ba72febfa350bfe9466832
> gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
> gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
>
> Diff: https://reviews.apache.org/r/51741/diff/
>
>
> Testing
> -------
>
> Local building. The changes come into effect when using 'uploadArchives'.
>
>
> Thanks,
>
> Jens Deppe
>
>
Re: Review Request 51741: [GEODE-1817] Prepare for 'release quality'
publishing
Posted by Mark Bretl <mb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51741/#review148360
-----------------------------------------------------------
gradle.properties (line 32)
<https://reviews.apache.org/r/51741/#comment215818>
Do we want to remove '-SNAPSHOT' while on the develop branch? This will cause issues with the nightly upload. I would expect this to change on the release branch.
gradle.properties (line 51)
<https://reviews.apache.org/r/51741/#comment215820>
I agree with Dan. I don't think we want this disabled by default as artifacts need to be signed to be uploaded to Apache repositories
- Mark Bretl
On Sept. 8, 2016, 12:35 p.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51741/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2016, 12:35 p.m.)
>
>
> Review request for geode, Anthony Baker and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This also disables default archive signing which requires GPG keys
>
>
> Diffs
> -----
>
> build.gradle e112eb77847371f730ba72febfa350bfe9466832
> gradle.properties 06855c7a3782cb83cce9731460d3197749de42f3
> gradle/publish.gradle 2258da6537b69afad0c3188d06f91da9fd8c08c3
>
> Diff: https://reviews.apache.org/r/51741/diff/
>
>
> Testing
> -------
>
> Local building. The changes come into effect when using 'uploadArchives'.
>
>
> Thanks,
>
> Jens Deppe
>
>