[GitHub] [hadoop] ayushtkn commented on pull request #4461: HADOOP-18303. Remove shading exclusion of javax.ws.rs-api from hadoop-client-runtime

[GitBox <gi...@apache.org>]

ayushtkn commented on PR #4461:
URL: https://github.com/apache/hadoop/pull/4461#issuecomment-1161637780

   >I'm getting really confused now. Before this PR, conflicting imports were both being shaded. Now they are being merged in unshaded and the issue is which ones not to shade?
   
   I am also confused....
   
    No, one was shaded one wasn't, the one not shaded is getting added here because kirby & spark are crying due to missing classes. 
   
   The question is yes which one to shade and which one not to, In Ideal situation only one these jars should be there because they provide similar classes and to be used by different version.
   
   In our case Jackson use the new Jar, and Jersey uses the old Jar, so we need both Jar in hadoop. If we upgrade Jersey also, both Jackson & Jersey will need the new jar and we can remove one jar and this conflict.
   
   Let us assume we did something with the shading, but Projects like Tez, when they add Hadoop as dependency they get both Jars and both have similar classes, so that creates a mess, something similar error message like here:
   https://stackoverflow.com/questions/23277429/java-lang-abstractmethoderror-javax-ws-rs-core-uribuilder-uri/26767488#26767488
   
   Regarding Solution: I don't have a perfect solution, and definitely need pointers, Not sure what we can do with shading, if we figure out may be spark/kriby may be happy. But if we exclude the old jar who will be unhappy god knows....
   
   Shading won't solve Hive/Tez issue....
   
   Jersey upgrade: Not sure we can do for a maintenance release, people have objections for protobuf as well, and post that also I guess downstream also have to upgrade Jersey, that won't be easy either.
   
   That is all what I know or can think of, Not sure what all is Right/Wrong. 
   
   Hope I didn't contribute more to the confusion.....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org