You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/08 13:06:28 UTC
[GitHub] [incubator-kyuubi] yaooqinn opened a new issue #2062: [Improvement] Add a job or step for shell script style in Github Action
yaooqinn opened a new issue #2062:
URL: https://github.com/apache/incubator-kyuubi/issues/2062
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
### Search before asking
- [X] I have searched in the [issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and found no similar issues.
### What would you like to be improved?
shell script style consistency
### How should we improve?
Maybe adding https://github.com/marketplace/actions/shell-linter in sytle.yaml is a good choice, or something else
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] RishiKumarRay commented on issue #2062: [Improvement] Add a job or step for shell script style in Github Action
Posted by GitBox <gi...@apache.org>.
RishiKumarRay commented on issue #2062:
URL: https://github.com/apache/incubator-kyuubi/issues/2062#issuecomment-1061763282
@yaooqinn yeah i can try , can you elaborate what needs to be done ? Please, i am not able to understand completely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2062: [Improvement] Add a job or step for shell script style in Github Action
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2062:
URL: https://github.com/apache/incubator-kyuubi/issues/2062#issuecomment-1061804758
You may check the repo yourself, this way is better for getting familiar with the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2062: [Improvement] Add a job or step for shell script style in Github Action
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2062:
URL: https://github.com/apache/incubator-kyuubi/issues/2062#issuecomment-1061757168
cc @RishiKumarRay, can you help with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on issue #2062: [Improvement] Add a job or step for shell script style in Github Action
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on issue #2062:
URL: https://github.com/apache/incubator-kyuubi/issues/2062#issuecomment-1061768533
It is a style checker for code written in shell
For example, Kyuubi is mainly written in scala and java, so we already have style checkers for them, see https://github.com/apache/incubator-kyuubi/blob/master/.github/workflows/style.yml#L49
We need to introduce a consistent style/format for the existing and coming shell scripts, like `bin/kyuubi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] RishiKumarRay commented on issue #2062: [Improvement] Add a job or step for shell script style in Github Action
Posted by GitBox <gi...@apache.org>.
RishiKumarRay commented on issue #2062:
URL: https://github.com/apache/incubator-kyuubi/issues/2062#issuecomment-1061771732
@yaooqinn ok, let me try this , assign me also the path of the scripts that needs to be checked is bin/kyuubi ? Or path where the scripts are present is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org