You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by Joe Witt <jo...@apache.org> on 2018/03/22 16:11:32 UTC

[VOTE] Release Apache NiFi 1.6.0

Hello,

I am pleased to be calling this vote for the source release of Apache
NiFi nifi-1.6.0.

The source zip, including signatures, digests, etc. can be found at:
https://repository.apache.org/content/repositories/orgapachenifi-1122

The Git tag is nifi-1.6.0-RC1
The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=49a71f4740c9fac38958961f78dd3cde874b0e45

Checksums of nifi-1.6.0-source-release.zip:
SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891
SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f75519e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/joewitt.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/nifi/KEYS

135 issues were closed/resolved for this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12342422

Release note highlights can be found here:
https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.6.0

The vote will be open for 72 hours.
Please download the release candidate and evaluate the necessary items
including checking hashes, signatures, build
from source, and test.  The please vote:

[ ] +1 Release this package as nifi-1.6.0
[ ] +0 no opinion
[ ] -1 Do not release this package because...

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Aldrin Piri <al...@gmail.com>.
+1, binding


comments:

* the listed commit is the new one for 1.7.0 development, its parent
99bc762a181892aa9ac50b0c6c81e8159b052137 matches the source (
https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=99bc762a181892aa9ac50b0c6c81e8159b052137
)
* signature and hashes look good
* build, tests, and contrib were all good on Debian 9, CentOS 7, and OS X
10.12
* ran some simple flows and functionality looked good
* did a cursory inspection of generated L&N files and didn't see anything
egregious.  We should make sure to update our copyright to 2018 for our
next release where applicable [1]

A lot of great additions for this release.  Great work by all the
contributors!

--aldrin

[1] https://issues.apache.org/jira/browse/NIFI-5006


On Thu, Mar 22, 2018 at 3:25 PM, otto@apache.org <ot...@apache.org> wrote:

> +1
>
> Signed correctly
> Checksums correct
> Builds with checks
> Runs with simple flow
> Versions correct in about and documentation
> Documentation links work
>
> nice job.
>
> ottO/ottobackwards
>
>
> On March 22, 2018 at 12:11:35, Joe Witt (joewitt@apache.org) wrote:
>
> Hello,
>
> I am pleased to be calling this vote for the source release of Apache
> NiFi nifi-1.6.0.
>
> The source zip, including signatures, digests, etc. can be found at:
> https://repository.apache.org/content/repositories/orgapachenifi-1122
>
> The Git tag is nifi-1.6.0-RC1
> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;
> h=49a71f4740c9fac38958961f78dd3cde874b0e45
>
> Checksums of nifi-1.6.0-source-release.zip:
> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891
> SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f755
> 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/joewitt.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/nifi/KEYS
>
> 135 issues were closed/resolved for this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> ctId=12316020&version=12342422
>
> Release note highlights can be found here:
> https://cwiki.apache.org/confluence/display/NIFI/Release+
> Notes#ReleaseNotes-Version1.6.0
>
> The vote will be open for 72 hours.
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build
> from source, and test. The please vote:
>
> [ ] +1 Release this package as nifi-1.6.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because...
>
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by "otto@apache.org" <ot...@apache.org>.
+1

Signed correctly
Checksums correct
Builds with checks
Runs with simple flow
Versions correct in about and documentation
Documentation links work

nice job.

ottO/ottobackwards


On March 22, 2018 at 12:11:35, Joe Witt (joewitt@apache.org) wrote:

Hello, 

I am pleased to be calling this vote for the source release of Apache 
NiFi nifi-1.6.0. 

The source zip, including signatures, digests, etc. can be found at: 
https://repository.apache.org/content/repositories/orgapachenifi-1122 

The Git tag is nifi-1.6.0-RC1 
The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45 
https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=49a71f4740c9fac38958961f78dd3cde874b0e45 

Checksums of nifi-1.6.0-source-release.zip: 
SHA1: 4fb82f386a0aa83614cc01449e540527443811ce 
SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891 
SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f75519e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a 

Release artifacts are signed with the following key: 
https://people.apache.org/keys/committer/joewitt.asc 

KEYS file available here: 
https://dist.apache.org/repos/dist/release/nifi/KEYS 

135 issues were closed/resolved for this release: 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12342422 

Release note highlights can be found here: 
https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.6.0 

The vote will be open for 72 hours. 
Please download the release candidate and evaluate the necessary items 
including checking hashes, signatures, build 
from source, and test. The please vote: 

[ ] +1 Release this package as nifi-1.6.0 
[ ] +0 no opinion 
[ ] -1 Do not release this package because... 

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Sivaprasanna <si...@gmail.com>.
Yeah. Tested and found the bug when using the Schema Registry service. I
have made the changes and raised PR #2581
<https://github.com/apache/nifi/pull/2581>

I have tested that both the scenario works as expected:

   1. Original reason why the ticket was raised i.e. to reload new
   resources found
   2. The schema registry bug

@Bryan and others,

Please review and check it.

Thanks,

Sivaprasanna

On Sat, Mar 24, 2018 at 3:23 AM, Bryan Bende <bb...@gmail.com> wrote:

> After voting I happened to be using the RC to test something else and
> came across a bug that I think warrants changing my vote to a -1.
>
> I created a simple two node cluster and made a standard convert record
> flow. When I ran the flow I got a schema not found exception, so I
> used the debugger which showed AvroSchemaRegistry had no schemas, even
> though there was one in the UI.
>
> I then used the debugger to make sure the onPropertyModified was
> getting when a schema was added, and it was which meant some after
> adding the schema but before running the flow, it was being removed.
>
> As far as I can tell, the issue is related to changes introduced in
> NIFI-4864... the intent here was for components with property
> descriptors that have "dynamically modifies classpath" to be able to
> smartly reload when they are started based on knowing if more
> classpath resources were added.
>
> The issue is that for components that don't have any property
> descriptors like this, they have a null fingerprint, and before
> starting it compares null to the fingerprint of empty string, and
> decides to reload [2].
>
> I think the fix should be fairly easy to just short-circuit at the
> beginning of that method and return immediately if
> additionalResourcesFingerprint is null, but will have to do some
> testing.
>
> [1] https://issues.apache.org/jira/browse/NIFI-4864
> [2] https://github.com/apache/nifi/blob/master/nifi-nar-
> bundles/nifi-framework-bundle/nifi-framework/nifi-framework-
> core-api/src/main/java/org/apache/nifi/controller/
> AbstractConfiguredComponent.java#L313-L314
>
>
> On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman <ma...@gmail.com>
> wrote:
> > +1 (binding) Release this package as nifi-1.6.0
> >
> > Executed the release helper and verified new granular restrictions with
> > regards to flow versioning.
> >
> > Thanks for RMing Joe!
> >
> > Matt
> >
> > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <mo...@gmail.com>
> wrote:
> >
> >> +1 (binding)
> >>
> >> Ran through release helper to verify the release and run NiFi on Ubuntu
> >> 16.04.  It worked as expected with no new comments to add.
> >>
> >> -- Mike
> >>
> >>
> >> On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <sc...@gmail.com>
> >> wrote:
> >>
> >> > +1 (binding)
> >> >
> >> > - Ran through release helper
> >> > - Setup secure NiFi and verified a test flow
> >> >
> >> > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bb...@gmail.com>
> wrote:
> >> >
> >> > > +1 (binding)
> >> > >
> >> > > - Ran through release helper and everything checked out
> >> > > - Verified some test flows with the restricted components + keytab
> CS
> >> > >
> >> > >
> >> > >
> >> > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com>
> >> > wrote:
> >> > > > +1 (binding)
> >> > > >
> >> > > > Was able to verify hashes, build with contrib-check, and start up
> >> > > application. Performed some basic functionality tests and all
> worked as
> >> > > expected.
> >> > > >
> >> > > > Thanks!
> >> > > > -Mark
> >> > > >
> >> > > >
> >> > > >> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <
> >> tasanuma@yahoo-corp.jp
> >> > >
> >> > > wrote:
> >> > > >>
> >> > > >> Thanks for all your efforts, Joe.
> >> > > >>
> >> > > >> I have one question. The version of the generated package is
> >> > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> >> > > +1(non-binding).
> >> > > >>
> >> > > >> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> >> > > >> - Started secure cluster mode
> >> > > >> - Verified sample dataflows work fine
> >> > > >> - Verified the whitelist feature(NIFI-4761) works fine
> >> > > >>
> >> > > >> -Takanobu Asanuma
> >> > > >>
> >> > > >> -----Original Message-----
> >> > > >> From: Joe Witt [mailto:joewitt@apache.org]
> >> > > >> Sent: Friday, March 23, 2018 1:12 AM
> >> > > >> To: dev@nifi.apache.org
> >> > > >> Subject: [VOTE] Release Apache NiFi 1.6.0
> >> > > >>
> >> > > >> Hello,
> >> > > >>
> >> > > >> I am pleased to be calling this vote for the source release of
> >> Apache
> >> > > NiFi nifi-1.6.0.
> >> > > >>
> >> > > >> The source zip, including signatures, digests, etc. can be found
> at:
> >> > > >> https://repository.apache.org/content/repositories/
> >> orgapachenifi-1122
> >> > > >>
> >> > > >> The Git tag is nifi-1.6.0-RC1
> >> > > >> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> >> > > >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> >> > > 49a71f4740c9fac38958961f78dd3cde874b0e45
> >> > > >>
> >> > > >> Checksums of nifi-1.6.0-source-release.zip:
> >> > > >> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> >> > > >> SHA256: 4df6638ec87a5bee12e7978abc6413
> >> 7ee5da5fc8c399e34cf34ca1c3720a
> >> > > c891
> >> > > >> SHA512: 6fa536f9618c6c153c04df5db59913
> >> eaf3dd54ae2389368129ac6237f755
> >> > > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7
> 934e013a
> >> > > >>
> >> > > >> Release artifacts are signed with the following key:
> >> > > >> https://people.apache.org/keys/committer/joewitt.asc
> >> > > >>
> >> > > >> KEYS file available here:
> >> > > >> https://dist.apache.org/repos/dist/release/nifi/KEYS
> >> > > >>
> >> > > >> 135 issues were closed/resolved for this release:
> >> > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> > > projectId=12316020&version=12342422
> >> > > >>
> >> > > >> Release note highlights can be found here:
> >> > > >> https://cwiki.apache.org/confluence/display/NIFI/
> >> > > Release+Notes#ReleaseNotes-Version1.6.0
> >> > > >>
> >> > > >> The vote will be open for 72 hours.
> >> > > >> Please download the release candidate and evaluate the necessary
> >> items
> >> > > including checking hashes, signatures, build from source, and test.
> >> The
> >> > > please vote:
> >> > > >>
> >> > > >> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ]
> -1
> >> Do
> >> > > not release this package because...
> >> > > >
> >> > >
> >> >
> >>
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Sivaprasanna <si...@gmail.com>.
Is it not possible to review/verify the improvements made to NIFI-4864
issue and then go ahead with the 1.6.0 release process? The new change is
relatively minor so if possible, we can verify whether everything is intact
and not going to introduce new problems. Maybe, if that’s the case, we can
still go ahead? Having said that, I don’t intend to mean a rushed up
review/release process.

Cheers,
Sivaprasanna

On Sun, 25 Mar 2018 at 7:43 PM, Joey Frazee <jo...@icloud.com> wrote:

> -1
>
> Ran through the usual release helper stuff, but it seems like the
> fingerprint issue is going to cause problems, so not sure how useful
> putting 1.6.0 out there will be if 1.6.1 will have to be turned around
> immediately.
>
> Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the
> tag got pushed.
>
> -joey
>
> On Mar 24, 2018, 12:38 AM -0500, Pierre Villard <
> pierre.villard.fr@gmail.com>, wrote:
> > -1 (binding)
> >
> > I confirm the issue mentioned by Bryan. That's actually what Matt and I
> > experienced when trying the PR about the S2S Metrics Reporting task [1].
> I
> > thought it was due to my change but it appears it's not the case.
> >
> > [1] https://github.com/apache/nifi/pull/2575
> >
> > 2018-03-23 22:53 GMT+01:00 Bryan Bende <bb...@gmail.com>:
> >
> > > After voting I happened to be using the RC to test something else and
> > > came across a bug that I think warrants changing my vote to a -1.
> > >
> > > I created a simple two node cluster and made a standard convert record
> > > flow. When I ran the flow I got a schema not found exception, so I
> > > used the debugger which showed AvroSchemaRegistry had no schemas, even
> > > though there was one in the UI.
> > >
> > > I then used the debugger to make sure the onPropertyModified was
> > > getting when a schema was added, and it was which meant some after
> > > adding the schema but before running the flow, it was being removed.
> > >
> > > As far as I can tell, the issue is related to changes introduced in
> > > NIFI-4864... the intent here was for components with property
> > > descriptors that have "dynamically modifies classpath" to be able to
> > > smartly reload when they are started based on knowing if more
> > > classpath resources were added.
> > >
> > > The issue is that for components that don't have any property
> > > descriptors like this, they have a null fingerprint, and before
> > > starting it compares null to the fingerprint of empty string, and
> > > decides to reload [2].
> > >
> > > I think the fix should be fairly easy to just short-circuit at the
> > > beginning of that method and return immediately if
> > > additionalResourcesFingerprint is null, but will have to do some
> > > testing.
> > >
> > > [1] https://issues.apache.org/jira/browse/NIFI-4864
> > > [2] https://github.com/apache/nifi/blob/master/nifi-nar-
> > > bundles/nifi-framework-bundle/nifi-framework/nifi-framework-
> > > core-api/src/main/java/org/apache/nifi/controller/
> > > AbstractConfiguredComponent.java#L313-L314
> > >
> > >
> > > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman <matt.c.gilman@gmail.com
> > > wrote:
> > > > +1 (binding) Release this package as nifi-1.6.0
> > > >
> > > > Executed the release helper and verified new granular restrictions
> with
> > > > regards to flow versioning.
> > > >
> > > > Thanks for RMing Joe!
> > > >
> > > > Matt
> > > >
> > > > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <moser.mw@gmail.com
> > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > Ran through release helper to verify the release and run NiFi on
> Ubuntu
> > > > > 16.04. It worked as expected with no new comments to add.
> > > > >
> > > > > -- Mike
> > > > >
> > > > >
> > > > > On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <
> scottyaslan@gmail.com
> > > > > wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > - Ran through release helper
> > > > > > - Setup secure NiFi and verified a test flow
> > > > > >
> > > > > > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bbende@gmail.com
> > > wrote:
> > > > > >
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > > - Ran through release helper and everything checked out
> > > > > > > - Verified some test flows with the restricted components +
> keytab
> > > CS
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <
> markap14@hotmail.com
> > > > > > wrote:
> > > > > > > > +1 (binding)
> > > > > > > >
> > > > > > > > Was able to verify hashes, build with contrib-check, and
> start up
> > > > > > > application. Performed some basic functionality tests and all
> > > worked as
> > > > > > > expected.
> > > > > > > >
> > > > > > > > Thanks!
> > > > > > > > -Mark
> > > > > > > >
> > > > > > > >
> > > > > > > > > On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <
> > > > > tasanuma@yahoo-corp.jp
> > > > > > >
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > Thanks for all your efforts, Joe.
> > > > > > > > >
> > > > > > > > > I have one question. The version of the generated package
> is
> > > > > > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> > > > > > > +1(non-binding).
> > > > > > > > >
> > > > > > > > > - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> > > > > > > > > - Started secure cluster mode
> > > > > > > > > - Verified sample dataflows work fine
> > > > > > > > > - Verified the whitelist feature(NIFI-4761) works fine
> > > > > > > > >
> > > > > > > > > -Takanobu Asanuma
> > > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: Joe Witt [mailto:joewitt@apache.org]
> > > > > > > > > Sent: Friday, March 23, 2018 1:12 AM
> > > > > > > > > To: dev@nifi.apache.org
> > > > > > > > > Subject: [VOTE] Release Apache NiFi 1.6.0
> > > > > > > > >
> > > > > > > > > Hello,
> > > > > > > > >
> > > > > > > > > I am pleased to be calling this vote for the source
> release of
> > > > > Apache
> > > > > > > NiFi nifi-1.6.0.
> > > > > > > > >
> > > > > > > > > The source zip, including signatures, digests, etc. can be
> found
> > > at:
> > > > > > > > > https://repository.apache.org/content/repositories/
> > > > > orgapachenifi-1122
> > > > > > > > >
> > > > > > > > > The Git tag is nifi-1.6.0-RC1
> > > > > > > > > The Git commit ID is
> 49a71f4740c9fac38958961f78dd3cde874b0e45
> > > > > > > > >
> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> > > > > > > 49a71f4740c9fac38958961f78dd3cde874b0e45
> > > > > > > > >
> > > > > > > > > Checksums of nifi-1.6.0-source-release.zip:
> > > > > > > > > SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> > > > > > > > > SHA256: 4df6638ec87a5bee12e7978abc6413
> > > > > 7ee5da5fc8c399e34cf34ca1c3720a
> > > > > > > c891
> > > > > > > > > SHA512: 6fa536f9618c6c153c04df5db59913
> > > > > eaf3dd54ae2389368129ac6237f755
> > > > > > > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7
> > > 934e013a
> > > > > > > > >
> > > > > > > > > Release artifacts are signed with the following key:
> > > > > > > > > https://people.apache.org/keys/committer/joewitt.asc
> > > > > > > > >
> > > > > > > > > KEYS file available here:
> > > > > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS
> > > > > > > > >
> > > > > > > > > 135 issues were closed/resolved for this release:
> > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > > > projectId=12316020&version=12342422
> > > > > > > > >
> > > > > > > > > Release note highlights can be found here:
> > > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/
> > > > > > > Release+Notes#ReleaseNotes-Version1.6.0
> > > > > > > > >
> > > > > > > > > The vote will be open for 72 hours.
> > > > > > > > > Please download the release candidate and evaluate the
> necessary
> > > > > items
> > > > > > > including checking hashes, signatures, build from source, and
> test.
> > > > > The
> > > > > > > please vote:
> > > > > > > > >
> > > > > > > > > [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no
> opinion [ ]
> > > -1
> > > > > Do
> > > > > > > not release this package because...
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > >
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Joey Frazee <jo...@icloud.com>.
-1

Ran through the usual release helper stuff, but it seems like the fingerprint issue is going to cause problems, so not sure how useful putting 1.6.0 out there will be if 1.6.1 will have to be turned around immediately.

Did you mean to say there's a nifi-1.6.0 -RC tag? It doesn't look like the tag got pushed.

-joey

On Mar 24, 2018, 12:38 AM -0500, Pierre Villard <pi...@gmail.com>, wrote:
> -1 (binding)
>
> I confirm the issue mentioned by Bryan. That's actually what Matt and I
> experienced when trying the PR about the S2S Metrics Reporting task [1]. I
> thought it was due to my change but it appears it's not the case.
>
> [1] https://github.com/apache/nifi/pull/2575
>
> 2018-03-23 22:53 GMT+01:00 Bryan Bende <bb...@gmail.com>:
>
> > After voting I happened to be using the RC to test something else and
> > came across a bug that I think warrants changing my vote to a -1.
> >
> > I created a simple two node cluster and made a standard convert record
> > flow. When I ran the flow I got a schema not found exception, so I
> > used the debugger which showed AvroSchemaRegistry had no schemas, even
> > though there was one in the UI.
> >
> > I then used the debugger to make sure the onPropertyModified was
> > getting when a schema was added, and it was which meant some after
> > adding the schema but before running the flow, it was being removed.
> >
> > As far as I can tell, the issue is related to changes introduced in
> > NIFI-4864... the intent here was for components with property
> > descriptors that have "dynamically modifies classpath" to be able to
> > smartly reload when they are started based on knowing if more
> > classpath resources were added.
> >
> > The issue is that for components that don't have any property
> > descriptors like this, they have a null fingerprint, and before
> > starting it compares null to the fingerprint of empty string, and
> > decides to reload [2].
> >
> > I think the fix should be fairly easy to just short-circuit at the
> > beginning of that method and return immediately if
> > additionalResourcesFingerprint is null, but will have to do some
> > testing.
> >
> > [1] https://issues.apache.org/jira/browse/NIFI-4864
> > [2] https://github.com/apache/nifi/blob/master/nifi-nar-
> > bundles/nifi-framework-bundle/nifi-framework/nifi-framework-
> > core-api/src/main/java/org/apache/nifi/controller/
> > AbstractConfiguredComponent.java#L313-L314
> >
> >
> > On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman <matt.c.gilman@gmail.com
> > wrote:
> > > +1 (binding) Release this package as nifi-1.6.0
> > >
> > > Executed the release helper and verified new granular restrictions with
> > > regards to flow versioning.
> > >
> > > Thanks for RMing Joe!
> > >
> > > Matt
> > >
> > > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <moser.mw@gmail.com
> > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > Ran through release helper to verify the release and run NiFi on Ubuntu
> > > > 16.04. It worked as expected with no new comments to add.
> > > >
> > > > -- Mike
> > > >
> > > >
> > > > On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <scottyaslan@gmail.com
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > - Ran through release helper
> > > > > - Setup secure NiFi and verified a test flow
> > > > >
> > > > > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bbende@gmail.com
> > wrote:
> > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > > - Ran through release helper and everything checked out
> > > > > > - Verified some test flows with the restricted components + keytab
> > CS
> > > > > >
> > > > > >
> > > > > >
> > > > > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <markap14@hotmail.com
> > > > > wrote:
> > > > > > > +1 (binding)
> > > > > > >
> > > > > > > Was able to verify hashes, build with contrib-check, and start up
> > > > > > application. Performed some basic functionality tests and all
> > worked as
> > > > > > expected.
> > > > > > >
> > > > > > > Thanks!
> > > > > > > -Mark
> > > > > > >
> > > > > > >
> > > > > > > > On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <
> > > > tasanuma@yahoo-corp.jp
> > > > > >
> > > > > > wrote:
> > > > > > > >
> > > > > > > > Thanks for all your efforts, Joe.
> > > > > > > >
> > > > > > > > I have one question. The version of the generated package is
> > > > > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> > > > > > +1(non-binding).
> > > > > > > >
> > > > > > > > - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> > > > > > > > - Started secure cluster mode
> > > > > > > > - Verified sample dataflows work fine
> > > > > > > > - Verified the whitelist feature(NIFI-4761) works fine
> > > > > > > >
> > > > > > > > -Takanobu Asanuma
> > > > > > > >
> > > > > > > > -----Original Message-----
> > > > > > > > From: Joe Witt [mailto:joewitt@apache.org]
> > > > > > > > Sent: Friday, March 23, 2018 1:12 AM
> > > > > > > > To: dev@nifi.apache.org
> > > > > > > > Subject: [VOTE] Release Apache NiFi 1.6.0
> > > > > > > >
> > > > > > > > Hello,
> > > > > > > >
> > > > > > > > I am pleased to be calling this vote for the source release of
> > > > Apache
> > > > > > NiFi nifi-1.6.0.
> > > > > > > >
> > > > > > > > The source zip, including signatures, digests, etc. can be found
> > at:
> > > > > > > > https://repository.apache.org/content/repositories/
> > > > orgapachenifi-1122
> > > > > > > >
> > > > > > > > The Git tag is nifi-1.6.0-RC1
> > > > > > > > The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> > > > > > > > https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> > > > > > 49a71f4740c9fac38958961f78dd3cde874b0e45
> > > > > > > >
> > > > > > > > Checksums of nifi-1.6.0-source-release.zip:
> > > > > > > > SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> > > > > > > > SHA256: 4df6638ec87a5bee12e7978abc6413
> > > > 7ee5da5fc8c399e34cf34ca1c3720a
> > > > > > c891
> > > > > > > > SHA512: 6fa536f9618c6c153c04df5db59913
> > > > eaf3dd54ae2389368129ac6237f755
> > > > > > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7
> > 934e013a
> > > > > > > >
> > > > > > > > Release artifacts are signed with the following key:
> > > > > > > > https://people.apache.org/keys/committer/joewitt.asc
> > > > > > > >
> > > > > > > > KEYS file available here:
> > > > > > > > https://dist.apache.org/repos/dist/release/nifi/KEYS
> > > > > > > >
> > > > > > > > 135 issues were closed/resolved for this release:
> > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > > projectId=12316020&version=12342422
> > > > > > > >
> > > > > > > > Release note highlights can be found here:
> > > > > > > > https://cwiki.apache.org/confluence/display/NIFI/
> > > > > > Release+Notes#ReleaseNotes-Version1.6.0
> > > > > > > >
> > > > > > > > The vote will be open for 72 hours.
> > > > > > > > Please download the release candidate and evaluate the necessary
> > > > items
> > > > > > including checking hashes, signatures, build from source, and test.
> > > > The
> > > > > > please vote:
> > > > > > > >
> > > > > > > > [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ]
> > -1
> > > > Do
> > > > > > not release this package because...
> > > > > > >
> > > > > >
> > > > >
> > > >
> >

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Pierre Villard <pi...@gmail.com>.
-1 (binding)

I confirm the issue mentioned by Bryan. That's actually what Matt and I
experienced when trying the PR about the S2S Metrics Reporting task [1]. I
thought it was due to my change but it appears it's not the case.

[1] https://github.com/apache/nifi/pull/2575

2018-03-23 22:53 GMT+01:00 Bryan Bende <bb...@gmail.com>:

> After voting I happened to be using the RC to test something else and
> came across a bug that I think warrants changing my vote to a -1.
>
> I created a simple two node cluster and made a standard convert record
> flow. When I ran the flow I got a schema not found exception, so I
> used the debugger which showed AvroSchemaRegistry had no schemas, even
> though there was one in the UI.
>
> I then used the debugger to make sure the onPropertyModified was
> getting when a schema was added, and it was which meant some after
> adding the schema but before running the flow, it was being removed.
>
> As far as I can tell, the issue is related to changes introduced in
> NIFI-4864... the intent here was for components with property
> descriptors that have "dynamically modifies classpath" to be able to
> smartly reload when they are started based on knowing if more
> classpath resources were added.
>
> The issue is that for components that don't have any property
> descriptors like this, they have a null fingerprint, and before
> starting it compares null to the fingerprint of empty string, and
> decides to reload [2].
>
> I think the fix should be fairly easy to just short-circuit at the
> beginning of that method and return immediately if
> additionalResourcesFingerprint is null, but will have to do some
> testing.
>
> [1] https://issues.apache.org/jira/browse/NIFI-4864
> [2] https://github.com/apache/nifi/blob/master/nifi-nar-
> bundles/nifi-framework-bundle/nifi-framework/nifi-framework-
> core-api/src/main/java/org/apache/nifi/controller/
> AbstractConfiguredComponent.java#L313-L314
>
>
> On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman <ma...@gmail.com>
> wrote:
> > +1 (binding) Release this package as nifi-1.6.0
> >
> > Executed the release helper and verified new granular restrictions with
> > regards to flow versioning.
> >
> > Thanks for RMing Joe!
> >
> > Matt
> >
> > On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <mo...@gmail.com>
> wrote:
> >
> >> +1 (binding)
> >>
> >> Ran through release helper to verify the release and run NiFi on Ubuntu
> >> 16.04.  It worked as expected with no new comments to add.
> >>
> >> -- Mike
> >>
> >>
> >> On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <sc...@gmail.com>
> >> wrote:
> >>
> >> > +1 (binding)
> >> >
> >> > - Ran through release helper
> >> > - Setup secure NiFi and verified a test flow
> >> >
> >> > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bb...@gmail.com>
> wrote:
> >> >
> >> > > +1 (binding)
> >> > >
> >> > > - Ran through release helper and everything checked out
> >> > > - Verified some test flows with the restricted components + keytab
> CS
> >> > >
> >> > >
> >> > >
> >> > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com>
> >> > wrote:
> >> > > > +1 (binding)
> >> > > >
> >> > > > Was able to verify hashes, build with contrib-check, and start up
> >> > > application. Performed some basic functionality tests and all
> worked as
> >> > > expected.
> >> > > >
> >> > > > Thanks!
> >> > > > -Mark
> >> > > >
> >> > > >
> >> > > >> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <
> >> tasanuma@yahoo-corp.jp
> >> > >
> >> > > wrote:
> >> > > >>
> >> > > >> Thanks for all your efforts, Joe.
> >> > > >>
> >> > > >> I have one question. The version of the generated package is
> >> > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> >> > > +1(non-binding).
> >> > > >>
> >> > > >> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> >> > > >> - Started secure cluster mode
> >> > > >> - Verified sample dataflows work fine
> >> > > >> - Verified the whitelist feature(NIFI-4761) works fine
> >> > > >>
> >> > > >> -Takanobu Asanuma
> >> > > >>
> >> > > >> -----Original Message-----
> >> > > >> From: Joe Witt [mailto:joewitt@apache.org]
> >> > > >> Sent: Friday, March 23, 2018 1:12 AM
> >> > > >> To: dev@nifi.apache.org
> >> > > >> Subject: [VOTE] Release Apache NiFi 1.6.0
> >> > > >>
> >> > > >> Hello,
> >> > > >>
> >> > > >> I am pleased to be calling this vote for the source release of
> >> Apache
> >> > > NiFi nifi-1.6.0.
> >> > > >>
> >> > > >> The source zip, including signatures, digests, etc. can be found
> at:
> >> > > >> https://repository.apache.org/content/repositories/
> >> orgapachenifi-1122
> >> > > >>
> >> > > >> The Git tag is nifi-1.6.0-RC1
> >> > > >> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> >> > > >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> >> > > 49a71f4740c9fac38958961f78dd3cde874b0e45
> >> > > >>
> >> > > >> Checksums of nifi-1.6.0-source-release.zip:
> >> > > >> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> >> > > >> SHA256: 4df6638ec87a5bee12e7978abc6413
> >> 7ee5da5fc8c399e34cf34ca1c3720a
> >> > > c891
> >> > > >> SHA512: 6fa536f9618c6c153c04df5db59913
> >> eaf3dd54ae2389368129ac6237f755
> >> > > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7
> 934e013a
> >> > > >>
> >> > > >> Release artifacts are signed with the following key:
> >> > > >> https://people.apache.org/keys/committer/joewitt.asc
> >> > > >>
> >> > > >> KEYS file available here:
> >> > > >> https://dist.apache.org/repos/dist/release/nifi/KEYS
> >> > > >>
> >> > > >> 135 issues were closed/resolved for this release:
> >> > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >> > > projectId=12316020&version=12342422
> >> > > >>
> >> > > >> Release note highlights can be found here:
> >> > > >> https://cwiki.apache.org/confluence/display/NIFI/
> >> > > Release+Notes#ReleaseNotes-Version1.6.0
> >> > > >>
> >> > > >> The vote will be open for 72 hours.
> >> > > >> Please download the release candidate and evaluate the necessary
> >> items
> >> > > including checking hashes, signatures, build from source, and test.
> >> The
> >> > > please vote:
> >> > > >>
> >> > > >> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ]
> -1
> >> Do
> >> > > not release this package because...
> >> > > >
> >> > >
> >> >
> >>
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Bryan Bende <bb...@gmail.com>.
After voting I happened to be using the RC to test something else and
came across a bug that I think warrants changing my vote to a -1.

I created a simple two node cluster and made a standard convert record
flow. When I ran the flow I got a schema not found exception, so I
used the debugger which showed AvroSchemaRegistry had no schemas, even
though there was one in the UI.

I then used the debugger to make sure the onPropertyModified was
getting when a schema was added, and it was which meant some after
adding the schema but before running the flow, it was being removed.

As far as I can tell, the issue is related to changes introduced in
NIFI-4864... the intent here was for components with property
descriptors that have "dynamically modifies classpath" to be able to
smartly reload when they are started based on knowing if more
classpath resources were added.

The issue is that for components that don't have any property
descriptors like this, they have a null fingerprint, and before
starting it compares null to the fingerprint of empty string, and
decides to reload [2].

I think the fix should be fairly easy to just short-circuit at the
beginning of that method and return immediately if
additionalResourcesFingerprint is null, but will have to do some
testing.

[1] https://issues.apache.org/jira/browse/NIFI-4864
[2] https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java#L313-L314


On Fri, Mar 23, 2018 at 4:20 PM, Matt Gilman <ma...@gmail.com> wrote:
> +1 (binding) Release this package as nifi-1.6.0
>
> Executed the release helper and verified new granular restrictions with
> regards to flow versioning.
>
> Thanks for RMing Joe!
>
> Matt
>
> On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <mo...@gmail.com> wrote:
>
>> +1 (binding)
>>
>> Ran through release helper to verify the release and run NiFi on Ubuntu
>> 16.04.  It worked as expected with no new comments to add.
>>
>> -- Mike
>>
>>
>> On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <sc...@gmail.com>
>> wrote:
>>
>> > +1 (binding)
>> >
>> > - Ran through release helper
>> > - Setup secure NiFi and verified a test flow
>> >
>> > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bb...@gmail.com> wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > - Ran through release helper and everything checked out
>> > > - Verified some test flows with the restricted components + keytab CS
>> > >
>> > >
>> > >
>> > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com>
>> > wrote:
>> > > > +1 (binding)
>> > > >
>> > > > Was able to verify hashes, build with contrib-check, and start up
>> > > application. Performed some basic functionality tests and all worked as
>> > > expected.
>> > > >
>> > > > Thanks!
>> > > > -Mark
>> > > >
>> > > >
>> > > >> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <
>> tasanuma@yahoo-corp.jp
>> > >
>> > > wrote:
>> > > >>
>> > > >> Thanks for all your efforts, Joe.
>> > > >>
>> > > >> I have one question. The version of the generated package is
>> > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
>> > > +1(non-binding).
>> > > >>
>> > > >> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
>> > > >> - Started secure cluster mode
>> > > >> - Verified sample dataflows work fine
>> > > >> - Verified the whitelist feature(NIFI-4761) works fine
>> > > >>
>> > > >> -Takanobu Asanuma
>> > > >>
>> > > >> -----Original Message-----
>> > > >> From: Joe Witt [mailto:joewitt@apache.org]
>> > > >> Sent: Friday, March 23, 2018 1:12 AM
>> > > >> To: dev@nifi.apache.org
>> > > >> Subject: [VOTE] Release Apache NiFi 1.6.0
>> > > >>
>> > > >> Hello,
>> > > >>
>> > > >> I am pleased to be calling this vote for the source release of
>> Apache
>> > > NiFi nifi-1.6.0.
>> > > >>
>> > > >> The source zip, including signatures, digests, etc. can be found at:
>> > > >> https://repository.apache.org/content/repositories/
>> orgapachenifi-1122
>> > > >>
>> > > >> The Git tag is nifi-1.6.0-RC1
>> > > >> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
>> > > >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
>> > > 49a71f4740c9fac38958961f78dd3cde874b0e45
>> > > >>
>> > > >> Checksums of nifi-1.6.0-source-release.zip:
>> > > >> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
>> > > >> SHA256: 4df6638ec87a5bee12e7978abc6413
>> 7ee5da5fc8c399e34cf34ca1c3720a
>> > > c891
>> > > >> SHA512: 6fa536f9618c6c153c04df5db59913
>> eaf3dd54ae2389368129ac6237f755
>> > > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
>> > > >>
>> > > >> Release artifacts are signed with the following key:
>> > > >> https://people.apache.org/keys/committer/joewitt.asc
>> > > >>
>> > > >> KEYS file available here:
>> > > >> https://dist.apache.org/repos/dist/release/nifi/KEYS
>> > > >>
>> > > >> 135 issues were closed/resolved for this release:
>> > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > > projectId=12316020&version=12342422
>> > > >>
>> > > >> Release note highlights can be found here:
>> > > >> https://cwiki.apache.org/confluence/display/NIFI/
>> > > Release+Notes#ReleaseNotes-Version1.6.0
>> > > >>
>> > > >> The vote will be open for 72 hours.
>> > > >> Please download the release candidate and evaluate the necessary
>> items
>> > > including checking hashes, signatures, build from source, and test.
>> The
>> > > please vote:
>> > > >>
>> > > >> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1
>> Do
>> > > not release this package because...
>> > > >
>> > >
>> >
>>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Matt Gilman <ma...@gmail.com>.
+1 (binding) Release this package as nifi-1.6.0

Executed the release helper and verified new granular restrictions with
regards to flow versioning.

Thanks for RMing Joe!

Matt

On Fri, Mar 23, 2018 at 4:12 PM, Michael Moser <mo...@gmail.com> wrote:

> +1 (binding)
>
> Ran through release helper to verify the release and run NiFi on Ubuntu
> 16.04.  It worked as expected with no new comments to add.
>
> -- Mike
>
>
> On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <sc...@gmail.com>
> wrote:
>
> > +1 (binding)
> >
> > - Ran through release helper
> > - Setup secure NiFi and verified a test flow
> >
> > On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bb...@gmail.com> wrote:
> >
> > > +1 (binding)
> > >
> > > - Ran through release helper and everything checked out
> > > - Verified some test flows with the restricted components + keytab CS
> > >
> > >
> > >
> > > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com>
> > wrote:
> > > > +1 (binding)
> > > >
> > > > Was able to verify hashes, build with contrib-check, and start up
> > > application. Performed some basic functionality tests and all worked as
> > > expected.
> > > >
> > > > Thanks!
> > > > -Mark
> > > >
> > > >
> > > >> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <
> tasanuma@yahoo-corp.jp
> > >
> > > wrote:
> > > >>
> > > >> Thanks for all your efforts, Joe.
> > > >>
> > > >> I have one question. The version of the generated package is
> > > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> > > +1(non-binding).
> > > >>
> > > >> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> > > >> - Started secure cluster mode
> > > >> - Verified sample dataflows work fine
> > > >> - Verified the whitelist feature(NIFI-4761) works fine
> > > >>
> > > >> -Takanobu Asanuma
> > > >>
> > > >> -----Original Message-----
> > > >> From: Joe Witt [mailto:joewitt@apache.org]
> > > >> Sent: Friday, March 23, 2018 1:12 AM
> > > >> To: dev@nifi.apache.org
> > > >> Subject: [VOTE] Release Apache NiFi 1.6.0
> > > >>
> > > >> Hello,
> > > >>
> > > >> I am pleased to be calling this vote for the source release of
> Apache
> > > NiFi nifi-1.6.0.
> > > >>
> > > >> The source zip, including signatures, digests, etc. can be found at:
> > > >> https://repository.apache.org/content/repositories/
> orgapachenifi-1122
> > > >>
> > > >> The Git tag is nifi-1.6.0-RC1
> > > >> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> > > >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> > > 49a71f4740c9fac38958961f78dd3cde874b0e45
> > > >>
> > > >> Checksums of nifi-1.6.0-source-release.zip:
> > > >> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> > > >> SHA256: 4df6638ec87a5bee12e7978abc6413
> 7ee5da5fc8c399e34cf34ca1c3720a
> > > c891
> > > >> SHA512: 6fa536f9618c6c153c04df5db59913
> eaf3dd54ae2389368129ac6237f755
> > > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
> > > >>
> > > >> Release artifacts are signed with the following key:
> > > >> https://people.apache.org/keys/committer/joewitt.asc
> > > >>
> > > >> KEYS file available here:
> > > >> https://dist.apache.org/repos/dist/release/nifi/KEYS
> > > >>
> > > >> 135 issues were closed/resolved for this release:
> > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > projectId=12316020&version=12342422
> > > >>
> > > >> Release note highlights can be found here:
> > > >> https://cwiki.apache.org/confluence/display/NIFI/
> > > Release+Notes#ReleaseNotes-Version1.6.0
> > > >>
> > > >> The vote will be open for 72 hours.
> > > >> Please download the release candidate and evaluate the necessary
> items
> > > including checking hashes, signatures, build from source, and test.
> The
> > > please vote:
> > > >>
> > > >> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1
> Do
> > > not release this package because...
> > > >
> > >
> >
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Michael Moser <mo...@gmail.com>.
+1 (binding)

Ran through release helper to verify the release and run NiFi on Ubuntu
16.04.  It worked as expected with no new comments to add.

-- Mike


On Fri, Mar 23, 2018 at 4:02 PM, Scott Aslan <sc...@gmail.com> wrote:

> +1 (binding)
>
> - Ran through release helper
> - Setup secure NiFi and verified a test flow
>
> On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bb...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > - Ran through release helper and everything checked out
> > - Verified some test flows with the restricted components + keytab CS
> >
> >
> >
> > On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com>
> wrote:
> > > +1 (binding)
> > >
> > > Was able to verify hashes, build with contrib-check, and start up
> > application. Performed some basic functionality tests and all worked as
> > expected.
> > >
> > > Thanks!
> > > -Mark
> > >
> > >
> > >> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <tasanuma@yahoo-corp.jp
> >
> > wrote:
> > >>
> > >> Thanks for all your efforts, Joe.
> > >>
> > >> I have one question. The version of the generated package is
> > nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> > +1(non-binding).
> > >>
> > >> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> > >> - Started secure cluster mode
> > >> - Verified sample dataflows work fine
> > >> - Verified the whitelist feature(NIFI-4761) works fine
> > >>
> > >> -Takanobu Asanuma
> > >>
> > >> -----Original Message-----
> > >> From: Joe Witt [mailto:joewitt@apache.org]
> > >> Sent: Friday, March 23, 2018 1:12 AM
> > >> To: dev@nifi.apache.org
> > >> Subject: [VOTE] Release Apache NiFi 1.6.0
> > >>
> > >> Hello,
> > >>
> > >> I am pleased to be calling this vote for the source release of Apache
> > NiFi nifi-1.6.0.
> > >>
> > >> The source zip, including signatures, digests, etc. can be found at:
> > >> https://repository.apache.org/content/repositories/orgapachenifi-1122
> > >>
> > >> The Git tag is nifi-1.6.0-RC1
> > >> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> > >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> > 49a71f4740c9fac38958961f78dd3cde874b0e45
> > >>
> > >> Checksums of nifi-1.6.0-source-release.zip:
> > >> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> > >> SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720a
> > c891
> > >> SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f755
> > 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
> > >>
> > >> Release artifacts are signed with the following key:
> > >> https://people.apache.org/keys/committer/joewitt.asc
> > >>
> > >> KEYS file available here:
> > >> https://dist.apache.org/repos/dist/release/nifi/KEYS
> > >>
> > >> 135 issues were closed/resolved for this release:
> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12316020&version=12342422
> > >>
> > >> Release note highlights can be found here:
> > >> https://cwiki.apache.org/confluence/display/NIFI/
> > Release+Notes#ReleaseNotes-Version1.6.0
> > >>
> > >> The vote will be open for 72 hours.
> > >> Please download the release candidate and evaluate the necessary items
> > including checking hashes, signatures, build from source, and test.  The
> > please vote:
> > >>
> > >> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1 Do
> > not release this package because...
> > >
> >
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Scott Aslan <sc...@gmail.com>.
+1 (binding)

- Ran through release helper
- Setup secure NiFi and verified a test flow

On Fri, Mar 23, 2018 at 3:29 PM, Bryan Bende <bb...@gmail.com> wrote:

> +1 (binding)
>
> - Ran through release helper and everything checked out
> - Verified some test flows with the restricted components + keytab CS
>
>
>
> On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com> wrote:
> > +1 (binding)
> >
> > Was able to verify hashes, build with contrib-check, and start up
> application. Performed some basic functionality tests and all worked as
> expected.
> >
> > Thanks!
> > -Mark
> >
> >
> >> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <ta...@yahoo-corp.jp>
> wrote:
> >>
> >> Thanks for all your efforts, Joe.
> >>
> >> I have one question. The version of the generated package is
> nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok,
> +1(non-binding).
> >>
> >> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> >> - Started secure cluster mode
> >> - Verified sample dataflows work fine
> >> - Verified the whitelist feature(NIFI-4761) works fine
> >>
> >> -Takanobu Asanuma
> >>
> >> -----Original Message-----
> >> From: Joe Witt [mailto:joewitt@apache.org]
> >> Sent: Friday, March 23, 2018 1:12 AM
> >> To: dev@nifi.apache.org
> >> Subject: [VOTE] Release Apache NiFi 1.6.0
> >>
> >> Hello,
> >>
> >> I am pleased to be calling this vote for the source release of Apache
> NiFi nifi-1.6.0.
> >>
> >> The source zip, including signatures, digests, etc. can be found at:
> >> https://repository.apache.org/content/repositories/orgapachenifi-1122
> >>
> >> The Git tag is nifi-1.6.0-RC1
> >> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=
> 49a71f4740c9fac38958961f78dd3cde874b0e45
> >>
> >> Checksums of nifi-1.6.0-source-release.zip:
> >> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> >> SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720a
> c891
> >> SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f755
> 19e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
> >>
> >> Release artifacts are signed with the following key:
> >> https://people.apache.org/keys/committer/joewitt.asc
> >>
> >> KEYS file available here:
> >> https://dist.apache.org/repos/dist/release/nifi/KEYS
> >>
> >> 135 issues were closed/resolved for this release:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12316020&version=12342422
> >>
> >> Release note highlights can be found here:
> >> https://cwiki.apache.org/confluence/display/NIFI/
> Release+Notes#ReleaseNotes-Version1.6.0
> >>
> >> The vote will be open for 72 hours.
> >> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build from source, and test.  The
> please vote:
> >>
> >> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1 Do
> not release this package because...
> >
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Bryan Bende <bb...@gmail.com>.
+1 (binding)

- Ran through release helper and everything checked out
- Verified some test flows with the restricted components + keytab CS



On Fri, Mar 23, 2018 at 2:42 PM, Mark Payne <ma...@hotmail.com> wrote:
> +1 (binding)
>
> Was able to verify hashes, build with contrib-check, and start up application. Performed some basic functionality tests and all worked as expected.
>
> Thanks!
> -Mark
>
>
>> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <ta...@yahoo-corp.jp> wrote:
>>
>> Thanks for all your efforts, Joe.
>>
>> I have one question. The version of the generated package is nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok, +1(non-binding).
>>
>> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
>> - Started secure cluster mode
>> - Verified sample dataflows work fine
>> - Verified the whitelist feature(NIFI-4761) works fine
>>
>> -Takanobu Asanuma
>>
>> -----Original Message-----
>> From: Joe Witt [mailto:joewitt@apache.org]
>> Sent: Friday, March 23, 2018 1:12 AM
>> To: dev@nifi.apache.org
>> Subject: [VOTE] Release Apache NiFi 1.6.0
>>
>> Hello,
>>
>> I am pleased to be calling this vote for the source release of Apache NiFi nifi-1.6.0.
>>
>> The source zip, including signatures, digests, etc. can be found at:
>> https://repository.apache.org/content/repositories/orgapachenifi-1122
>>
>> The Git tag is nifi-1.6.0-RC1
>> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
>> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=49a71f4740c9fac38958961f78dd3cde874b0e45
>>
>> Checksums of nifi-1.6.0-source-release.zip:
>> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
>> SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891
>> SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f75519e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
>>
>> Release artifacts are signed with the following key:
>> https://people.apache.org/keys/committer/joewitt.asc
>>
>> KEYS file available here:
>> https://dist.apache.org/repos/dist/release/nifi/KEYS
>>
>> 135 issues were closed/resolved for this release:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12342422
>>
>> Release note highlights can be found here:
>> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.6.0
>>
>> The vote will be open for 72 hours.
>> Please download the release candidate and evaluate the necessary items including checking hashes, signatures, build from source, and test.  The please vote:
>>
>> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1 Do not release this package because...
>

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Mark Payne <ma...@hotmail.com>.
+1 (binding)

Was able to verify hashes, build with contrib-check, and start up application. Performed some basic functionality tests and all worked as expected.

Thanks!
-Mark


> On Mar 23, 2018, at 6:02 AM, Takanobu Asanuma <ta...@yahoo-corp.jp> wrote:
> 
> Thanks for all your efforts, Joe. 
> 
> I have one question. The version of the generated package is nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok, +1(non-binding).
> 
> - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
> - Started secure cluster mode
> - Verified sample dataflows work fine
> - Verified the whitelist feature(NIFI-4761) works fine
> 
> -Takanobu Asanuma
> 
> -----Original Message-----
> From: Joe Witt [mailto:joewitt@apache.org] 
> Sent: Friday, March 23, 2018 1:12 AM
> To: dev@nifi.apache.org
> Subject: [VOTE] Release Apache NiFi 1.6.0
> 
> Hello,
> 
> I am pleased to be calling this vote for the source release of Apache NiFi nifi-1.6.0.
> 
> The source zip, including signatures, digests, etc. can be found at:
> https://repository.apache.org/content/repositories/orgapachenifi-1122
> 
> The Git tag is nifi-1.6.0-RC1
> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=49a71f4740c9fac38958961f78dd3cde874b0e45
> 
> Checksums of nifi-1.6.0-source-release.zip:
> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891
> SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f75519e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
> 
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/joewitt.asc
> 
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/nifi/KEYS
> 
> 135 issues were closed/resolved for this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12342422
> 
> Release note highlights can be found here:
> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.6.0
> 
> The vote will be open for 72 hours.
> Please download the release candidate and evaluate the necessary items including checking hashes, signatures, build from source, and test.  The please vote:
> 
> [ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1 Do not release this package because...


RE: [VOTE] Release Apache NiFi 1.6.0

Posted by Takanobu Asanuma <ta...@yahoo-corp.jp>.
Thanks for all your efforts, Joe. 

I have one question. The version of the generated package is nifi-1.7.0-SNAPSHOT. Is this correct at this stage? If it's ok, +1(non-binding).

 - Succeeded "mvn -T 2.0C clean install -DskipTests -Prpm"
 - Started secure cluster mode
 - Verified sample dataflows work fine
 - Verified the whitelist feature(NIFI-4761) works fine

-Takanobu Asanuma

-----Original Message-----
From: Joe Witt [mailto:joewitt@apache.org] 
Sent: Friday, March 23, 2018 1:12 AM
To: dev@nifi.apache.org
Subject: [VOTE] Release Apache NiFi 1.6.0

Hello,

I am pleased to be calling this vote for the source release of Apache NiFi nifi-1.6.0.

The source zip, including signatures, digests, etc. can be found at:
https://repository.apache.org/content/repositories/orgapachenifi-1122

The Git tag is nifi-1.6.0-RC1
The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=49a71f4740c9fac38958961f78dd3cde874b0e45

Checksums of nifi-1.6.0-source-release.zip:
SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891
SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f75519e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/joewitt.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/nifi/KEYS

135 issues were closed/resolved for this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12342422

Release note highlights can be found here:
https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.6.0

The vote will be open for 72 hours.
Please download the release candidate and evaluate the necessary items including checking hashes, signatures, build from source, and test.  The please vote:

[ ] +1 Release this package as nifi-1.6.0 [ ] +0 no opinion [ ] -1 Do not release this package because...

Re: [VOTE] Release Apache NiFi 1.6.0

Posted by Andrew Lim <an...@gmail.com>.
+1 (non-binding)

-Ran full clean install on OS X (10.11.6)
-Tested integration with Secure NiFi Registry (1.5.0)
-Tested fine grained restricted component policies.  Found two minor issues:
	Components are marked with the "restricted" red shield icon, but are not tagged as “restricted" [1]
	PutParquet processor should require "write filesystem” permission [2]
-Reviewed documentation

Drew

[1] https://issues.apache.org/jira/browse/NIFI-5008
[2] https://issues.apache.org/jira/browse/NIFI-5009

> On Mar 22, 2018, at 12:11 PM, Joe Witt <jo...@apache.org> wrote:
> 
> Hello,
> 
> I am pleased to be calling this vote for the source release of Apache
> NiFi nifi-1.6.0.
> 
> The source zip, including signatures, digests, etc. can be found at:
> https://repository.apache.org/content/repositories/orgapachenifi-1122
> 
> The Git tag is nifi-1.6.0-RC1
> The Git commit ID is 49a71f4740c9fac38958961f78dd3cde874b0e45
> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h=49a71f4740c9fac38958961f78dd3cde874b0e45
> 
> Checksums of nifi-1.6.0-source-release.zip:
> SHA1: 4fb82f386a0aa83614cc01449e540527443811ce
> SHA256: 4df6638ec87a5bee12e7978abc64137ee5da5fc8c399e34cf34ca1c3720ac891
> SHA512: 6fa536f9618c6c153c04df5db59913eaf3dd54ae2389368129ac6237f75519e1eee7ba0ca70145a95de01517a1c3ea1f36975895d9d72bb04abb56b7934e013a
> 
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/joewitt.asc
> 
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/nifi/KEYS
> 
> 135 issues were closed/resolved for this release:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316020&version=12342422
> 
> Release note highlights can be found here:
> https://cwiki.apache.org/confluence/display/NIFI/Release+Notes#ReleaseNotes-Version1.6.0
> 
> The vote will be open for 72 hours.
> Please download the release candidate and evaluate the necessary items
> including checking hashes, signatures, build
> from source, and test.  The please vote:
> 
> [ ] +1 Release this package as nifi-1.6.0
> [ ] +0 no opinion
> [ ] -1 Do not release this package because...