You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/06/04 01:00:50 UTC
Review Request 35037: Added doxygen link to home.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Added doxygen link to home.md.
Diffs
-----
docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
Diff: https://reviews.apache.org/r/35037/diff/
Testing
-------
Thanks,
Niklas Nielsen
Re: Review Request 35037: Added doxygen link to home.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/#review86542
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35037]
All tests passed.
- Mesos ReviewBot
On June 3, 2015, 11 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35037/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 11 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doxygen link to home.md.
>
>
> Diffs
> -----
>
> docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
>
> Diff: https://reviews.apache.org/r/35037/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 35037: Added doxygen link to home.md.
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 3, 2015, 4:37 p.m., Ben Mahler wrote:
> > docs/home.md, line 36
> > <https://reviews.apache.org/r/35037/diff/1/?file=977892#file977892line36>
> >
> > Should this be linking to the framework part of the C++ API? For example: http://mesos.apache.org/api/latest/c++/namespacemesos.html
> > That way, we don't have to say "internal C++ API" in the framework development section, which seems a bit odd?
> >
> > Also, can we have the top-level link you have here in the 'contributing to mesos' section?
Great suggestions! Will get that in.
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/#review86510
-----------------------------------------------------------
On June 3, 2015, 4 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35037/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 4 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doxygen link to home.md.
>
>
> Diffs
> -----
>
> docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
>
> Diff: https://reviews.apache.org/r/35037/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 35037: Added doxygen link to home.md.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/#review86510
-----------------------------------------------------------
Ship it!
Thanks Nik!
docs/home.md
<https://reviews.apache.org/r/35037/#comment138570>
Should this be linking to the framework part of the C++ API? For example: http://mesos.apache.org/api/latest/c++/namespacemesos.html
That way, we don't have to say "internal C++ API" in the framework development section, which seems a bit odd?
Also, can we have the top-level link you have here in the 'contributing to mesos' section?
- Ben Mahler
On June 3, 2015, 11 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35037/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 11 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added doxygen link to home.md.
>
>
> Diffs
> -----
>
> docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
>
> Diff: https://reviews.apache.org/r/35037/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 35037: Added doxygen link to home.md.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/
-----------------------------------------------------------
(Updated June 8, 2015, 4:41 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Addressed Ben's comments
Repository: mesos
Description
-------
Added doxygen link to home.md.
Diffs (updated)
-----
docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684
Diff: https://reviews.apache.org/r/35037/diff/
Testing
-------
Thanks,
Niklas Nielsen