[GitHub] [arrow-datafusion] yahoNanJing commented on a change in pull request #2111: Introduce datafusion-objectstore-hdfs as optional features in the datafusion core

[GitBox <gi...@apache.org>]

yahoNanJing commented on a change in pull request #2111:
URL: https://github.com/apache/arrow-datafusion/pull/2111#discussion_r839110416



##########
File path: datafusion/core/Cargo.toml
##########
@@ -60,9 +62,10 @@ async-trait = "0.1.41"
 avro-rs = { version = "0.13", features = ["snappy"], optional = true }
 chrono = { version = "0.4", default-features = false }
 datafusion-common = { path = "../common", version = "7.0.0", features = ["parquet"] }
-datafusion-data-access = { path = "../../data-access", version = "1.0.0" }
+datafusion-data-access = { git = "https://github.com/apache/arrow-datafusion.git", rev = "41b4e491663029f653e491b110d0b5e74d08a0b6" }

Review comment:
       Hi @alamb, with the datafusion-data-access module spitted out, now the dependencies are as follows:
   <pre>
                         ballista
                              ⬇️ 
                       datafusion   ➡️   objectstore-hdfs
                              ⬇️             ⬇️ 
                          datafusion-data-access
   </pre>
   
   Therefore, there's no cyclic dependency. Maybe it's better to split the datafusion-data-access into a separate repository and make a first version of release. Then both the datafusion and objectstore-hdfs can depend on the specified version of datafusion-data-access rather than leveraging the rev way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org