[jira] Closed: (THRIFT-941) Make PHP C Extension use the defined Protocol writeMessageBegin function

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-941.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.6

I just committed this. Thanks for the patch, Chris!

> Make PHP C Extension use the defined Protocol writeMessageBegin function
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-941
>                 URL: https://issues.apache.org/jira/browse/THRIFT-941
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Library
>            Reporter: Chris Goffinet
>            Assignee: Chris Goffinet
>            Priority: Minor
>             Fix For: 0.6
>
>         Attachments: 0001-Support-custom-writeMessageBegin-functions-from-user.patch
>
>
> The current PHP C Extension implementation hard codes writeMessageBegin that is from TBinaryProtocol in C land. I think the correct implementation should support calling into user-land from PHP if you have a protocol that might change how writeMessageBegin works. I built a tracing library that needed to pass additional fields with the RPC request. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.