You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/01/30 00:29:17 UTC
svn commit: r1727663 -
/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Author: pmouawad
Date: Fri Jan 29 23:29:17 2016
New Revision: 1727663
URL: http://svn.apache.org/viewvc?rev=1727663&view=rev
Log:
Bug 57696 HTTP Request : Improve responseMessage when resource download fails
Bugzilla Id: 57696
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java?rev=1727663&r1=1727662&r2=1727663&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java Fri Jan 29 23:29:17 2016
@@ -1368,7 +1368,7 @@ public abstract class HTTPSamplerBase ex
if (!escapedUrl.equals(url)) {
if(log.isDebugEnabled()) {
log.debug("Url '" + url + "' has been escaped to '" + escapedUrl
- + "'. Please corect your webpage.");
+ + "'. Please correct your webpage.");
}
}
return escapedUrl;
@@ -1414,7 +1414,20 @@ public abstract class HTTPSamplerBase ex
if(!IGNORE_FAILED_EMBEDDED_RESOURCES) {
res.setSuccessful(initialValue);
if(!initialValue) {
- res.setResponseMessage("Embedded resource download error"); //$NON-NLS-1$
+ StringBuilder detailedMessage = new StringBuilder(80);
+ detailedMessage.append("Embedded resource download error:"); //$NON-NLS-1$
+ for (SampleResult subResult : res.getSubResults()) {
+ HTTPSampleResult httpSampleResult = (HTTPSampleResult) subResult;
+ if(!httpSampleResult.isSuccessful()) {
+ detailedMessage.append(httpSampleResult.getURL())
+ .append(" code:") //$NON-NLS-1$
+ .append(httpSampleResult.getResponseCode())
+ .append(" message:") //$NON-NLS-1$
+ .append(httpSampleResult.getResponseMessage())
+ .append(", "); //$NON-NLS-1$
+ }
+ }
+ res.setResponseMessage(detailedMessage.toString()); //$NON-NLS-1$
}
}
}